From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3389 invoked by alias); 25 Jan 2006 11:07:50 -0000 Received: (qmail 3378 invoked by uid 22791); 25 Jan 2006 11:07:49 -0000 X-Spam-Check-By: sourceware.org Received: from main.gmane.org (HELO ciao.gmane.org) (80.91.229.2) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 25 Jan 2006 11:07:47 +0000 Received: from list by ciao.gmane.org with local (Exim 4.43) id 1F1iV4-0006lA-8Y for gdb-patches@sources.redhat.com; Wed, 25 Jan 2006 12:07:42 +0100 Received: from zigzag.lvk.cs.msu.su ([158.250.17.23]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 25 Jan 2006 12:07:42 +0100 Received: from ghost by zigzag.lvk.cs.msu.su with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 25 Jan 2006 12:07:42 +0100 To: gdb-patches@sources.redhat.com From: Vladimir Prus Subject: Re: [PATCH] Add fullname field for MI -break-info command Date: Wed, 25 Jan 2006 11:07:00 -0000 Message-ID: References: <200601241932.16022.ghost@cs.msu.su> <20060124165136.GF28357@brasko.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7Bit User-Agent: KNode/0.8.2 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-01/txt/msg00402.txt.bz2 Bob Rossi wrote: > On Tue, Jan 24, 2006 at 07:32:15PM +0300, Vladimir Prus wrote: >> >> Hello! >> >> The attached patch adds the "fullname" field to the output of MI >> -break-info command. > > The patch seems good to me at first glance. However, you should also > update the testsuite, and send in the patch for that as well. I'm looking into this right now, and have a question. Inside the test, I need to get the absolute path to the source file. If I use: "${srcdir}/${subdir}/${srcfile}" the result is: "../.././gdb/testsuite/gdb.mi/basics.c" while output of gdb has absolute path name. So: how do I convert relative path to an absolute one inside a test? (I don't know anything about Tcl, so it's not obvious for me). BTW, it would be nice in gdbint explicitly said how one can run a specific test from testsuite. > Also, don't forget about the documentation. Well, at the moment the -break-info command is not documented at all, so there's no place where I can add the extra "fullname" field. - Volodya