Re: [PATCH] Add fullname field for MI -break-info command

Bob Rossi
2006-01-25T12:10:01Z

On Wed, Jan 25, 2006 at 02:07:28PM +0300, Vladimir Prus wrote:
> Bob Rossi wrote:
>
> > On Tue, Jan 24, 2006 at 07:32:15PM +0300, Vladimir Prus wrote:
> >>
> >> Hello!
> >>
> >> The attached patch adds the "fullname" field to the output of MI
> >> -break-info command.
> >
> > The patch seems good to me at first glance. However, you should also
> > update the testsuite, and send in the patch for that as well.
>
> I'm looking into this right now, and have a question. Inside the test, I
> need to get the absolute path to the source file. If I use:
>
> "${srcdir}/${subdir}/${srcfile}"
>
> the result is:
>
> "../.././gdb/testsuite/gdb.mi/basics.c"

No, please user ${fullname_syntax}${srcfile}. That will provide you with
a regular expression that matches the fullname, and end in the source
file you are interestd in. You can see how this is done in
mi2-stack.exp.

> while output of gdb has absolute path name. So: how do I convert relative
> path to an absolute one inside a test? (I don't know anything about Tcl, so
> it's not obvious for me).
>
> BTW, it would be nice in gdbint explicitly said how one can run a specific
> test from testsuite.

Yeah, I totally agree. I forget every time. Try 'runtest mi2-stack.exp',
to run just that test.

> > Also, don't forget about the documentation.
>
> Well, at the moment the -break-info command is not documented at all, so
> there's no place where I can add the extra "fullname" field.

Hmm, there is a section in the gdb.texinfo manual that says
@c REDUNDANT???
Get information about a single breakpoint.
how is this command useful, instead of just using -break-list?

Thanks,
Bob Rossi