From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id acbTHVc9tWqpPz0AWB0awg (envelope-from ) for ; Thu, 24 Sep 2026 11:10:15 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=selector1 header.b=Dj6J8RHp; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 623961E06B; Thu, 24 Sep 2026 11:10:15 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 83F271E01F for ; Thu, 24 Sep 2026 11:10:14 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 344874BB58CA for ; Thu, 24 Sep 2026 15:10:13 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 344874BB58CA Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=selector1 header.b=Dj6J8RHp Received: from YQZPR01CU011.outbound.protection.outlook.com (mail-canadaeastazlp170100000.outbound.protection.outlook.com [IPv6:2a01:111:f403:c104::]) by sourceware.org (Postfix) with ESMTPS id 7802548F36B5 for ; Thu, 24 Sep 2026 15:08:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7802548F36B5 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7802548F36B5 Authentication-Results: sourceware.org; arc=pass smtp.remote-ip=2a01:111:f403:c104:: ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1790262487; cv=pass; b=ZrHysPQmJOMOSQy0tzUcW3KxyqaXb87Xr7WNgX/GdP81pHOF1xoCMlAzK1rmvpGwpk32EMKTNlpoK3FrKVDUe2Nzt6amKAN+BwIWCjXq6gvxMdRnOBOqL4REexnZ2ds7nW1HvkqdY91UH+zhgToCvGeHUhB7YHceONqPr43eKO0= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1790262487; c=relaxed/simple; bh=D5/19qrspSh9UB+R+7vRA14B76MGOU/kHwAZlY6zCdU=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=pESq4M4EEsj2Jhvt2ea+/p/IAkCAmWD2Nm8LCpW/NqAJJG18bEOyXWICNfTlnmMh63v218pQbcOZfR6Kg19t7nUU4ReYMUHfzWAOlNnMY4duCR9iz9JL0IpSfjQWdTIBOs9bNQbWvPnfuT7skB9VtrlLhqPfLrLjqX4GJCKvgnU= ARC-Authentication-Results: i=2; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=selector1 header.b=Dj6J8RHp DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7802548F36B5 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=pLMx8NGfO3SQnEMUBAbPruhjZWM5DQMltM2dV8Za9fLGfkdavUhdcO5xuVaUW1SHQ6fG5pQ53e9pJE/ADUz5Rvuz0fZEFUoTMkl4Xy6eETu16dL+AOqp4bAURGnmVS1Zex5I2siDfeAIMoPFzNCQkzOEZbxwC7kT8FvfZa7d61mf7vI0zfbI6bz/mxNzTRB84QzBUZwgt1vjRT8Din3k/bEPGkmmRPbXnA4EpqTaNCHjW04rHCHyn7RGpOAeBtBxG71pvdlMV9RMi3SaOJEYOKuC7gdpP8qUdVspbqwLSSOieREjnjoXYZFz/7HFfrKRNL/ksqtB7FNwFbnxBKVQSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6X/UV6zAqwtU2/r1SLXJwpc5SBgEv7qImUUJs4G6Kmo=; b=vo1byn+kqwdvKMKj2rvEahfjZH5xSssR2IsCEINPCFpPDFaUu4iyj/dDY3o9UD/6DEh7cXYboz00Dujekx0DavOLhRcvZvNjDB+rmg6GCH6lwFSPAe1gBXYUJqOoDKrrA4+jXWMjTo411Zj7yBBjE2xAsJcaLYDCxzSXErUKZWVsz9PcfWJjvC0ZR4+AC+I6M6BtOFhxtMn6wXKQz4Zhf/3NRcy/E6zp6mgLJt0/qfSErNjD55x7qPguatW0BVTU0qG6+o+M0H1zX5du6oW8FHB4BcQC9K4JQFmkhi10u8EUgVhjlrBa3GhJyUJWQuzZH1Phdo46OKMdz6n3igrmMQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=efficios.com; dmarc=pass action=none header.from=efficios.com; dkim=pass header.d=efficios.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6X/UV6zAqwtU2/r1SLXJwpc5SBgEv7qImUUJs4G6Kmo=; b=Dj6J8RHpc6UmVbHkiz7LplajvGZQT6ynco7l5USo3wdZVxK3ReD/Zwfvw3rRmD3ZwIQqE6nEy6/qNHmhrS9rZheC5MYQZ4QUC5AqNge4uAKK0iTrlEMAoIqQe7Lnjy2ycV11RFQWFc4DdVCYPJuSeCScfW5CDRTotgKWm3qfkTQDwIXmh54Y5HD8dD/gbLN9GjvGfGEtpT3WrZ315KCNros7kgAPExD2hAFNdtbNqP/iWgTgfTgccsClE3lDGE86w1mIqN7o/4JjHZhgkIAXqeBvV09FVdginSe3tJ/pG6MP/iHXj4X/WSbfOomnFuL2/ww2pJCOXETTKCJpys24aQ== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=efficios.com; Received: from YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:2c::6) by YT3PR01MB10844.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:12b::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.451.18; Thu, 24 Sep 2026 15:08:01 +0000 Received: from YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM ([fe80::bbfa:179f:fdc8:b15d]) by YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM ([fe80::bbfa:179f:fdc8:b15d%7]) with mapi id 15.21.0451.014; Thu, 24 Sep 2026 15:08:01 +0000 Message-ID: Date: Thu, 24 Sep 2026 11:07:59 -0400 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] gdb: resolve class name via DW_AT_signature in cooked index To: Andrew Burgess , gdb-patches@sourceware.org References: <20260924050002.1539783-3-simon.marchi@efficios.com> <874iff2asj.fsf@redhat.com> Content-Language: fr From: Simon Marchi In-Reply-To: <874iff2asj.fsf@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: YQBPR0101CA0287.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:6d::13) To YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:2c::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: YQXPR01MB5418:EE_|YT3PR01MB10844:EE_ X-MS-Office365-Filtering-Correlation-Id: 96df0991-0fec-4bd1-f402-08df1a4d9ff7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|23010399003|376014|366016|1800799024|5023799004|6133799003|10067099003|56012099006|4143699003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: je3LTxAB1Jabwr/jNDFIrrTDxhMqKao3Y47lBbuOK4ajl0B7TNIu7tGXmHSQStaQkuNEqdSJWu4jwOfqRUD1/NCBnOkKqoKfPRltV/NCjqetxypToTgAjBKwFA2STZAFoiM+0l7Y9bUYid1sQq/oWn573BquU51wUzgyxR97RGjLHotKed1Bq+95AmS3yt+buEaDyZHSzfLgXClQI2XOZXYd70vKtPLIAfYOtsumB3dFbzA65LTYRs/ERePdpa6ITJ0KT/jQLRZYxAvHiaLKJ1Lbrq+KxeEz7sfB45JLnS2WRvapZ+aJgXQAi88R4GVjMJ7eOLgCLprnn/InME5qPso6WnAqdhdaKVNFtniPjFhROV6i14BQsN/syEmMLyuPb0T5vQWDLzGBL6E/LNfI59IQ9/3aI5m3RtYEIPIT5dYhfja9sVy4Y61WJV/n4CworIFmKrTZ6cJpzZlhrCxeD5cITDSz3dFcWsVIQsjiR9LfNxN8iiWctVhrToZsufyCfWXD13OCSaxUNBX8p/2U/kwmfQaA2bvBs6WZo1zQjNWUDKkTiQJqp+Pt3d3iRlnk/N4jPuewHhQU3yw/4JZZIZn4wNZ+8vdbvSH8QfAaMrznoLLT6PEtSdIZi5Ar8AykI9f8HMGppncmiI7uxdQHnEadILKjlySrBJKRadWKEUM= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230040)(23010399003)(376014)(366016)(1800799024)(5023799004)(6133799003)(10067099003)(56012099006)(4143699003)(18002099003)(22082099003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dmovNEd3SVVMa2Z5dlRNM0VYTVpOelY3QkJFOFNpY05iQk1TTU9OdW15OExB?= =?utf-8?B?eFRyOWJsV2pJRGpod1k4cytzd1AyK0trbTFURDRKL3liRGtBeldoNkN3bEI5?= =?utf-8?B?ZWd3cStzMkttZThzUUxCd0paOStQNXl6dHFtUW1XRmd4VWY4cEM1dERSUnp5?= =?utf-8?B?dWNNUjJMMFRyZkF0Z3ZEVHRtc3kyZHY1YWx3bFdOV2NTemxaQXlwQzViM2xx?= =?utf-8?B?ZzN3WXNLTWlKK1hGMFgwMnJRNXBJV0NzZTI4c3drT2pLU3FNV0lSWUt2aWZD?= =?utf-8?B?S0lOUGc1SXU5a1RkMGVMb2FKNFZzZHBUblFKZzM3WHhTUmFOV1BoVFFxRFQx?= =?utf-8?B?dUZPUFEyY2wyQzlkLzhYaGpzSUh5aHVDY3lJOUpxaUY1Wi8yeU9HQk9lRXdX?= =?utf-8?B?Qm00TjNJSEVqWlBPcFdkckdKUndnZVNJOUFGeW50WmxrWjdYUUVySFhYVVV5?= =?utf-8?B?T3VIZk81Um80WWtMTlFoMmloVEJFTWl5ZmNmNG9IanBOWDdHN2l1cFo0aFlC?= =?utf-8?B?R2p3UnBBbGhRMERQYmhYcFFCL2o3YzJqRExuWmJxaDRXZ0hURStoc3F1Nklp?= =?utf-8?B?aEowdG9HaTZlc0hRMnNBVWhBVEg1a1JPZlROVlBMdjVGSnFQUTMyRWErWHJv?= =?utf-8?B?UVNZTHJTS3NhcFNJaW0rMDVsVU1EZVo5TTA3Y0w2Smp3MHZUdmV5V2FQYmpn?= =?utf-8?B?VzE1YmVpck9nYnBkV1FiWGdMV2FqQnBSQmZUK2ZSUUtuOGIzZGdISjBmUTZo?= =?utf-8?B?N1ZxVmdtRWpFd2w5djZjL1FQU0trdVZVb29BbSt3aEMvSnh0UVpYblRWbXEx?= =?utf-8?B?OFNsYVVDaEM1WGdxTkFJU1dvdTk4MU96VkdSNTZQWTYzSEtnRWIzcmc2ZWIz?= =?utf-8?B?dTdMNHpUODNZSWNxSFJpUGVzSzVGaEtFZitMckdHc1BQQmxFTUNhbGhNdmpx?= =?utf-8?B?QS9kQTVPZHBJUllJZEJkSURxcnhud2prRnVGcjFxaG5DR21jVjNkQTVHelB4?= =?utf-8?B?SWV0cDczaXYvMGhjMVFoUUVLdmdDL2NwNWl2aC9RVFZlL2doM0RoWHFmMVFC?= =?utf-8?B?RldscG1rSTRPRDFkclBFWE9GREpYakRuTWdTOVFGRkI5N2xwbXZqTjN5WnM1?= =?utf-8?B?UzNIRWVOdk9ZaUtxVURhUXl6Tzdubkl6NUljZ3dnZGhjQkZUWmE5VFV1MjJW?= =?utf-8?B?cUJBSi9HR2ZNTWpZU1hpbGNqQVFMNmxkcU8rTENTYU53NFJaZjU0a3MxVzg0?= =?utf-8?B?YkRvWUpleGNKZ29lZ3dhV21ienJRMExzWVhETnUweVdzUlk1STJMRXhjZWda?= =?utf-8?B?RGJhM2wxMDBCNFM5REE2WEVXdmhtNW52cStyaDdRUlNPYVkwNWV6TlB1Zmpt?= =?utf-8?B?b05NV2NjcXA2c29FVGZHVTAzb003TXhPMFRXZk9pVGQyOERUUVhONFFjV2pR?= =?utf-8?B?bjNvZlRvM0xDK0o4L2ZUTkxNZ1FVZHNxNWsvSnRXWEphZ2E1UzRDZ0hJd2o0?= =?utf-8?B?RHhLR05ld0dzQzdzRzdMelJId29GcnRIcUN2dXZOcjVURHBURldJbkJZcko2?= =?utf-8?B?ZWYyZ2xrS2V6MWg4TkZWSnVucStabFlHVTRFdVFFY1NIT0c5VmVJTWxjdEJM?= =?utf-8?B?Y0w5czN3V1ByUUgxUVRjMENIcHoyWlhVd0RUaWcrclhldEVhVXhrZ1dQbjBl?= =?utf-8?B?U2Y5bllYclhlNjB0Nm9kbUd3c3V5SE5aRkdPMk1nVHlDZkQ2OC9ZUnZ2RDF2?= =?utf-8?B?UC9EY1hHSkEwSkFZbmNqOFhPZVVhSVNNQ0ZHTzlOYTJaa2FCSnJhbmVMQ3Nz?= =?utf-8?B?SDNTWTBoa041Q3gwOThaOS9Ic0YxbW9OMFA4c0xFZUQwWDk4Um1IdG5ldkla?= =?utf-8?B?MWdlR0ZMd2h5R0hiWkpQRFo3czRLemtXdGFqdmVjYVFVOUJGcFdYN0pBcEhR?= =?utf-8?B?aGQydTIvbHRORklwTk1WazNXQUhwak5QOFF5Q1NGaFVmZEJpNDJYYlVOcnFo?= =?utf-8?B?MTBLVXNHL1BSQWpYRmdqTllraDF1ckFrbVJnaXlOcHhockNxWUdhWmVpYUR5?= =?utf-8?B?NlVzVjJ5aEszQ2UxY0dmWUlpeXQzdjFkbFdscktSQ25PNXMwclR0QVJVcGRx?= =?utf-8?B?WEFoM3VUcUp0d0MvYjdkVVVvcTd5RDNEa0J3WnN4OWY2bElDaEZrK3FicHJL?= =?utf-8?B?cDh0L0xHVERPZjZNV0h2MjlGZnZwZUtlL25yNExlZXk1NzY2RExsMlA4eE5S?= =?utf-8?B?WnU4Z1dnNDZTRFBtMHJBVEphYnFLRGhRTjB3bkNraU5WSFh5RjhTOFZ6STIy?= =?utf-8?B?eEdXU2lidFFMRGo3cjVmeG01azg3cEE4Zlk2M1RGWnVzSERXYWdHZz09?= X-OriginatorOrg: efficios.com X-MS-Exchange-CrossTenant-Network-Message-Id: 96df0991-0fec-4bd1-f402-08df1a4d9ff7 X-MS-Exchange-CrossTenant-AuthSource: YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Sep 2026 15:08:01.3613 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4f278736-4ab6-415c-957e-1f55336bd31e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +jQqNG7w+rwCSYrpPxhncL+EDJA16kmBhZVUf1LCPheTAsOcV3rKoIm4Q+kClAZsaHaTaubMzUlk0CpUSVTRNA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YT3PR01MB10844 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 9/24/26 6:39 AM, Andrew Burgess wrote: > > Simon, > > Thanks for working on this. This looks great, I have a couple of minor > comments. > > Simon Marchi writes: > >> From: Andrew Burgess > > I'd be fine if you wanted to change yourself to be the author, you've > put a lot of work into this iteration. But I feel you should at least > add a Co-Authored-By tag if nothing else :) Done (Co-Authored-By). >> diff --git a/gdb/dwarf2/cooked-index-entry.h b/gdb/dwarf2/cooked-index-entry.h >> index 60ea581cbbe5..a2e007b7cf69 100644 >> --- a/gdb/dwarf2/cooked-index-entry.h >> +++ b/gdb/dwarf2/cooked-index-entry.h >> @@ -47,6 +47,8 @@ enum cooked_index_flag_enum : unsigned char >> /* True if this is a function that has DW_AT_inline set in a way >> that indicates it was inlined. */ >> IS_INLINED = 64, >> + /* True is m_name.deferred has a value rather than m_name.resolved. */ > > Typo: 'True IF m_name.deferred ....' Done. >> + IS_NAME_DEFERRED = 128, > > In cooked-index-entry.c you need to update: > > std::string to_string (cooked_index_flag flags) > > which converts these flags to strings. Done. >> + >> +/* See cooked-index.h. */ >> + >> void >> cooked_index::start_canonicalize_names () >> { >> @@ -124,10 +207,14 @@ cooked_index::start_canonicalize_names () >> { >> group.add_task ([this, this_shard = shard.get ()] () >> { >> + complaint_interceptor complaint_handler; >> + > > I think you should add the complaint_interceptor to > cooked_index::start_resolve_deferred_parents and > cooked_index::start_prune_nameless_entries too. > > It's not needed in those cases, but it's not needed here either. > > My reasoning is that adding it is cheap, especially if no complaints are > emitted, and it's done in a worker thread, so we notice the impact even > less. > > But, if we ever add a complaint in the future then you need to remember > to add the complaint_interceptor, or hope someone catches it during > review. > > Given we're adding the infrastructure now, lets just add the > complaint_interceptor to all cases, then we're covered for future > growth. I agree, done. > With these fixes: > > Approved-By: Andrew Burgess > > Thanks, > Andrew Thanks for the review, I will push it later today (to both master and gdb-18-branch). Hopefully Tom has some time to give it a quick look today, just to get another pair of eyes on it. Simon