From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 93716 invoked by alias); 10 Apr 2017 09:26:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 93691 invoked by uid 89); 10 Apr 2017 09:26:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=Hx-languages-length:506 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 10 Apr 2017 09:26:55 +0000 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DF56E61B90; Mon, 10 Apr 2017 09:26:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com DF56E61B90 Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com DF56E61B90 Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.phx2.redhat.com [10.5.9.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3FD0577DEC; Mon, 10 Apr 2017 09:26:55 +0000 (UTC) Subject: Re: [RFA 04/14] Introduce gdb_dlopen_up To: Tom Tromey , gdb-patches@sourceware.org References: <20170408201208.2672-1-tom@tromey.com> <20170408201208.2672-5-tom@tromey.com> From: Pedro Alves Message-ID: Date: Mon, 10 Apr 2017 09:26:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20170408201208.2672-5-tom@tromey.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-04/txt/msg00229.txt.bz2 Hi! On 04/08/2017 09:11 PM, Tom Tromey wrote: > This introduces gdb_dlopen_up, a unique_ptr that can close a dlopen'd > library. All the functions working with dlopen handles are updated to > use this new type. > gdb_dlopen_up would sound to me like something that owns a pointer to dlopen? Since this is a unique pointer that instead owns a _handle_ that is returned by dlopen, I'd suggest naming it dlhandle_up or gdb_dlhandle_up instead. Thanks, Pedro Alves