From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23736 invoked by alias); 21 May 2014 06:20:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23725 invoked by uid 89); 21 May 2014 06:20:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.7 required=5.0 tests=AWL,BAYES_00,MIME_BASE64_BLANKS,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: na01-by2-obe.outbound.protection.outlook.com Received: from mail-by2lp0244.outbound.protection.outlook.com (HELO na01-by2-obe.outbound.protection.outlook.com) (207.46.163.244) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 21 May 2014 06:20:36 +0000 Received: from BL2FFO11FD042.protection.gbl (10.173.160.33) by BL2FFO11HUB046.protection.gbl (10.173.161.122) with Microsoft SMTP Server (TLS) id 15.0.949.9; Wed, 21 May 2014 06:20:32 +0000 Received: from xsj-gw1 (149.199.60.83) by BL2FFO11FD042.mail.protection.outlook.com (10.173.161.138) with Microsoft SMTP Server id 15.0.949.9 via Frontend Transport; Wed, 21 May 2014 06:20:32 +0000 Received: from unknown-38-66.xilinx.com ([149.199.38.66] helo=xsj-smtp1) by xsj-gw1 with esmtp (Exim 4.63) (envelope-from ) id 1Wmzt9-0000oc-HY; Tue, 20 May 2014 23:20:31 -0700 From: Ajit Kumar Agarwal To: Michael Eager , "gdb-patches@sourceware.org" , Joel Brobecker CC: Vinod Kathail , Vidhumouli Hunsigida , Nagaraju Mekala Subject: RE: [Patch, microblaze]: Add slr and shr regs and little-endian breakpoint Date: Wed, 21 May 2014 06:20:00 -0000 References: <537BC5B9.10601@eagercon.com> In-Reply-To: <537BC5B9.10601@eagercon.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-RCIS-Action: ALLOW Message-ID: X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:149.199.60.83;CTRY:US;IPV:NLI;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(6009001)(438001)(479174003)(199002)(51704005)(54534003)(189002)(24454002)(377424004)(31696002)(83322001)(23676002)(21056001)(80022001)(50466002)(20776003)(47776003)(64706001)(77982001)(74316001)(33646001)(81542001)(81342001)(70736001)(74662001)(76482001)(85852003)(83072002)(46102001)(87936001)(31966008)(2656002)(92566001)(92726001)(99396002)(53416003)(19580395003)(19580405001)(44976005)(74502001)(86362001)(4396001)(50986999)(54356999)(76176999);DIR:OUT;SFP:;SCL:1;SRVR:BL2FFO11HUB046;H:xsj-gw1;FPR:;MLV:sfv;PTR:unknown-60-83.xilinx.com;A:1;MX:1;LANG:en; X-OriginatorOrg: xilinx.onmicrosoft.com X-Forefront-PRVS: 0218A015FA Received-SPF: Pass (: domain of xilinx.com designates 149.199.60.83 as permitted sender) receiver=; client-ip=149.199.60.83; helo=xsj-gw1; Authentication-Results: spf=pass (sender IP is 149.199.60.83) smtp.mailfrom=ajit.kumar.agarwal@xilinx.com; X-SW-Source: 2014-05/txt/msg00454.txt.bz2 DQoNCk9uIDA1LzIwLzE0IDA5OjI1LCBBaml0IEt1bWFyIEFnYXJ3YWwgd3Jv dGU6DQo+IEhlbGxvIEpvZWw6DQo+DQo+IEkgaGF2ZSBzcGxpdCB0aGUgcGF0 Y2hlcyBhcyB5b3UgaGF2ZSByZWNvbW1lbmRlZCBhbmQgdGhlIGZvbGxvd2lu ZyBpcyB0aGUgZmlyc3Qgb2YgdGhlIHBhdGNoLg0KPg0KPiAgIFtQYXRjaCwg bWljcm9ibGF6ZV06IEFkZCBzbHIgYW5kIHNociByZWdzIGFuZCBsaXR0bGUt ZW5kaWFuIGJyZWFrcG9pbnQNCg0KPj5XaGF0IGlzIHRoZSByZWxhdGlvbnNo aXAgYmV0d2VlbiBhZGRpbmcgc2xyL3NociByZWdpc3RlcnMgYW5kIGxpdHRs ZS1lbmRpYW4gYnJlYXBvaW50cz8NCg0KVGhlIHNoci9zbHIgcmVnaXN0ZXJz IGFuZCBsaXR0bGUgZW5kaWFuIGJyZWFrcG9pbnRzIGFyZSByZWxhdGVkIGFz IGl0IGZpeGVkIHRoZSBjb21tb24gcHJvYmxlbSBvZiBQYWNrZXQgDQpUcmFu c2ZlciBlcnJvciB3aGVuIGNvbm5lY3RpbmcgdG8gdGhlIHRhcmdldCByZW1v dGUgaG9zdCAgdGhyb3VnaCB0YXIgcmVtb3RlIGluIGdkYiBmb3IgbWljcm9i bGF6ZS4NCg0KPg0KPiAgICAgIENoYW5nZUxvZzoNCj4NCj4gICAgICAyMDE0 LTA1LTIwIEFqaXQgQWdhcndhbCA8YWppdGt1bUB4aWxpbnguY29tPg0KPg0K PiAgICAgICAgICAqIGdkYi9nZGJzZXJ2ZXIvTWFrZWZpbGUuaW4gKG1pY3Jv YmxhemUtbGludXguYyk6IE5ldyBydWxlLg0KPg0KPiAgICAgICAgICAqIGdk Yi9taWNyb2JsYXplLXRkZXAuYyAobWljcm9ibGF6ZV9yZWdpc3Rlcl9uYW1l cyk6IEFkZGVkDQo+ICAgICAgICAgIHRoZSByc2hyIGFuZCByc2xyIHJlZ2lz dGVyIG5hbWVzLg0KPiAgICAgICAgICAobWljcm9ibGF6ZV9icmVha3BvaW50 X2Zyb21fcGMpOiBBZGRlZCBEZWNsYXJhdGlvbiBvZiBieXRlX29yZGVyDQo+ ICAgICAgICAgIGFuZCBicmVha19pbnNuX2xlLiBDaGVjayBvZiBieXRlIG9y ZGVyIGJ5IEJGRF9FTkRJQU5fQklHLg0KPg0KPiAgICAgICAgICAqIGdkYi9t aWNyb2JsYXplLXRkZXAuaCAobWljcm9ibGF6ZV9yZWdfbnVtKTogQWRkaXRp b24gb2YNCj4gICAgICAgICAgZmllbGQgTUlDUk9CTEFaRV9TTFJfUkVHTlVN IGFuZCBNSUNST0JMQVpFX1NIUl9SRUdOVU0uDQo+ICAgICAgICAgIChNSUNS T0JMQVpFX0JSRUFLUE9JTlRfTEUpOiBOZXcgTWFjcm8uDQo+ICAgICAgICAg IChtaWNyb2JsYXplX2ZyYW1lX2NhY2hlKTogQ2hhbmdlIGluIHRoZSBpbmRl eCBvZg0KPiAgICAgICAgICByZWdpc3Rlcl9vZmZzZXRzLg0KPg0KPiAgICAg ICAgICAqIGdkYi9yZWdmb3JtYXRzL3JlZy1taWNyb2JsYXplLmRhdDogTmV3 IFJlZ2lzdGVyIGRhdGEgZmlsZS4NCj4NCj4gICAgICBTaWduZWQtb2ZmLWJ5 OkFqaXQgQWdhcndhbCBhaml0a3VtQHhpbGlueC5jb20NCj4NCj4gVGhhbmtz ICYgUmVnYXJkcw0KPiBBaml0DQo+DQoNClRoYW5rcyAmIFJlZ2FyZHMNCkFq aXQNCi0tIA0KTWljaGFlbCBFYWdlcgkgZWFnZXJAZWFnZXJjb24uY29tDQox OTYwIFBhcmsgQmx2ZC4sIFBhbG8gQWx0bywgQ0EgOTQzMDYgIDY1MC0zMjUt ODA3Nw0K >From gdb-patches-return-112617-listarch-gdb-patches=sources.redhat.com@sourceware.org Wed May 21 06:52:05 2014 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 6584 invoked by alias); 21 May 2014 06:52:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 6574 invoked by uid 89); 21 May 2014 06:52:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mga01.intel.com Received: from mga01.intel.com (HELO mga01.intel.com) (192.55.52.88) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 21 May 2014 06:52:02 +0000 Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP; 20 May 2014 23:52:01 -0700 X-ExtLoop1: 1 Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by fmsmga002.fm.intel.com with ESMTP; 20 May 2014 23:52:00 -0700 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.98]) by IRSMSX102.ger.corp.intel.com ([169.254.2.173]) with mapi id 14.03.0123.003; Wed, 21 May 2014 07:51:04 +0100 From: "Metzger, Markus T" To: Pedro Alves CC: "gdb-patches@sourceware.org" Subject: RE: [PATCH] Make the dcache (code/stack cache) handle line reading errors better. Date: Wed, 21 May 2014 06:52:00 -0000 Message-ID: References: <1396601586-24380-1-git-send-email-markus.t.metzger@intel.com> <53760BDF.2080500@redhat.com> <537A7A80.3050801@redhat.com> <537B389C.4080901@redhat.com> <537B8DA6.4080601@redhat.com> In-Reply-To: <537B8DA6.4080601@redhat.com> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2014-05/txt/msg00455.txt.bz2 Content-length: 2362 > -----Original Message----- > From: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] On Behalf Of Pedro Alves > Sent: Tuesday, May 20, 2014 7:15 PM > 8<--------------- > From: Pedro Alves > Date: Tue, 20 May 2014 12:26:01 +0100 > Subject: [PATCH] Make the dcache (code/stack cache) handle line reading > errors > better. >=20 > The dcache (code/stack cache) is supposed to be transparent, but it's > actually not in one case. dcache tries to read chunks (cache lines) > at a time off of the target. This may end up trying to read > unaccessible or unavailable memory. Currently the caller an xfer error 'gets' is missing. > in this case. But if the specific bits of memory the caller actually > wanted are available and accessible, then the caller should get the > memory it wanted, not an error. > + Copyright 2012-2014 Free Software Foundation, Inc. Why 2012-? > +void *first_mapped_page; > +void *first_unmapped_page; > +void *last_mapped_page; > +void *last_unmapped_page; The _unmapped_page variants seem not to be used. > + /* Disassembling 0s should behave on all targets. */ > + memset (p, 0, pg_count * pg_size); Shouldn't be necessary. The pages are supposed to be zero-initialized. > +# Test that dcache behaves correctly when reading a cache line fails. > + > +standard_testfile > + > +if { [prepare_for_testing "failed to prepare" ${testfile}] } { And I always thought you had to supply $srcfile, as well. Can prepare_for_testing derive the source name from the executable name and some path magic? > +proc disassemble { what } { > + global hex gdb_prompt > + > + set cmd "disassemble $what" > + gdb_test_multiple $cmd $cmd { > + -re "Cannot access memory.*$gdb_prompt $" { > + fail $cmd > + } > + -re "End of assembler dump\.\r\n$gdb_prompt $" { > + pass $cmd > + } Wouldn't simply checking for "End of assembler dump\.\r\n" suffice? Wouldn't it even be more robust as it would catch all kinds of errors? Regards, Markus. Intel GmbH Dornacher Strasse 1 85622 Feldkirchen/Muenchen, Deutschland Sitz der Gesellschaft: Feldkirchen bei Muenchen Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk Registergericht: Muenchen HRB 47456 Ust.-IdNr./VAT Registration No.: DE129385895 Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052