From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id xeYJB8a5c2LacwQAWB0awg (envelope-from ) for ; Thu, 05 May 2022 07:49:26 -0400 Received: by simark.ca (Postfix, from userid 112) id 169981E058; Thu, 5 May 2022 07:49:26 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=Q1BmToc5; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 53BC51E00D for ; Thu, 5 May 2022 07:49:25 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id ECD583856DF1 for ; Thu, 5 May 2022 11:49:24 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org ECD583856DF1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1651751365; bh=vBhBzJKLitHQUR7FInPN9WGGyXG2YfKRqRSNUqkygqM=; h=Date:Subject:To:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=Q1BmToc5sFoB4UgHr6hxUPf9gVth+racpDIvdSej0Q7vluXz5Xmp6KTtd37c4CwVM uMQ+7mV5OIum7/HSL7CiTHFO4jrK+YU86u22Tat0wW3J7SN52wU8WNY69GeN+F5cHu gKbJSdOBs8RCqzYF9KMStROurQVVNPxZuVtN88Wg= Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id 121373856DCC for ; Thu, 5 May 2022 11:49:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 121373856DCC Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 3E2031F8D1; Thu, 5 May 2022 11:49:04 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 28C2E13A65; Thu, 5 May 2022 11:49:04 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id kt3lCLC5c2JubgAAMHmgww (envelope-from ); Thu, 05 May 2022 11:49:04 +0000 Content-Type: multipart/mixed; boundary="------------E6rpMkLTTQ0t3g0xE3AbVY63" Message-ID: Date: Thu, 5 May 2022 13:49:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: [PATCH][gdb/tdep] Support catch syscall pipe2 for i386 Content-Language: en-US To: gdb-patches@sourceware.org References: <20220503145732.GA26729@delia.home> In-Reply-To: X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Tom de Vries via Gdb-patches Reply-To: Tom de Vries Cc: Sergio Durigan Junior Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" This is a multi-part message in MIME format. --------------E6rpMkLTTQ0t3g0xE3AbVY63 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit [ was: Re: [PATCH, v2][gdb/testsuite] Handle pipe2 syscall in gdb.base/catch-syscall.exp ] On 5/5/22 13:47, Tom de Vries wrote: > On 5/3/22 16:57, Tom de Vries wrote: >> Hi, >> >> When running test-case gdb.reverse/pipe-reverse.exp on openSUSE >> Tumbleweed, >> I run into: >> ... >> (gdb) continue^M >> Continuing.^M >> ^M >> Catchpoint 2 (returned from syscall pipe2), in pipe () from >> /lib64/libc.so.6^M >> (gdb) FAIL: gdb.base/catch-syscall.exp: without arguments: \ >>    syscall pipe has returned >> ... >> >> The current glibc on Tumbleweed is 2.35, which contains commit >> "linux: Implement pipe in terms of __NR_pipe2", and consequently >> syscall pipe2 >> is used in stead of syscall pipe. >> >> Fix this by detecting whether syscall pipe or pipe2 is used before >> running the tests. >> >> Tested on x86_64-linux, specifically on: >> - openSUSE Tumbleweed (with glibc 2.35), and >> - openSUSE Leap 15.3 (with glibc 2.31). >> >> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=29056 >> >> Any comments? >> > > I'm submitting a v2.  I found out that with target board unix/-m32, > pipe2 is not recognized as syscall name (which I'll fix in a follow-up > patch), so I made the test robust against this, by using the syscall > number instead. And this is that follow-up patch. Any comments? Thanks, - Tom --------------E6rpMkLTTQ0t3g0xE3AbVY63 Content-Type: text/x-patch; charset=UTF-8; name="0009-gdb-tdep-Support-catch-syscall-pipe2-for-i386.patch" Content-Disposition: attachment; filename="0009-gdb-tdep-Support-catch-syscall-pipe2-for-i386.patch" Content-Transfer-Encoding: base64 W2dkYi90ZGVwXSBTdXBwb3J0IGNhdGNoIHN5c2NhbGwgcGlwZTIgZm9yIGkzODYKCldpdGgg dGVzdC1jYXNlIGdkYi5iYXNlL2NhdGNoLXN5c2NhbGwuZXhwIGFuZCB0YXJnZXQgYm9hcmQg dW5peC8tbTMyLCB3ZSBydW4KaW50bzoKLi4uCihnZGIpIGNhdGNoIHN5c2NhbGwgcGlwZTJe TQpVbmtub3duIHN5c2NhbGwgbmFtZSAncGlwZTInLl5NCihnZGIpIEZBSUw6IGdkYi5iYXNl L2NhdGNoLXN5c2NhbGwuZXhwOiBkZXRlcm1pbmUgcGlwZSBzeXNjYWxsOiBjYXRjaCBzeXNj YWxsIHBpcGUyCi4uLgoKRml4IHRoaXMgYnk6Ci0gYWRkaW5nIGEgcGlwZTIgZW50cnkgaW4g Z2RiL3N5c2NhbGxzL2kzODYtbGludXgueG1sLmluLCBhbmQKLSByZWdlbmVyYXRpbmcgZ2Ri L3N5c2NhbGxzL2kzODYtbGludXgueG1sIHVzaW5nCiAgInhzbHRwcm9jIC0tb3V0cHV0IGkz ODYtbGludXgueG1sIGFwcGx5LWRlZmF1bHRzLnhzbCBpMzg2LWxpbnV4LnhtbC5pbiIuCgpU ZXN0ZWQgb24geDg2XzY0LWxpbnV4IHdpdGggbmF0aXZlIGFuZCB1bml4Ly1tMzIuCgpCdWc6 IGh0dHBzOi8vc291cmNld2FyZS5vcmcvYnVnemlsbGEvc2hvd19idWcuY2dpP2lkPTI5MDU2 CgotLS0KIGdkYi9zeXNjYWxscy9pMzg2LWxpbnV4LnhtbCAgICB8IDEgKwogZ2RiL3N5c2Nh bGxzL2kzODYtbGludXgueG1sLmluIHwgMSArCiAyIGZpbGVzIGNoYW5nZWQsIDIgaW5zZXJ0 aW9ucygrKQoKZGlmZiAtLWdpdCBhL2dkYi9zeXNjYWxscy9pMzg2LWxpbnV4LnhtbCBiL2dk Yi9zeXNjYWxscy9pMzg2LWxpbnV4LnhtbAppbmRleCBhNzgzZGQxMGFmMy4uNGE3YTIzNDUx ODYgMTAwNjQ0Ci0tLSBhL2dkYi9zeXNjYWxscy9pMzg2LWxpbnV4LnhtbAorKysgYi9nZGIv c3lzY2FsbHMvaTM4Ni1saW51eC54bWwKQEAgLTMzNCw0ICszMzQsNSBAQAogICA8c3lzY2Fs bCBuYW1lPSJldmVudGZkIiBudW1iZXI9IjMyMyIgZ3JvdXBzPSJkZXNjcmlwdG9yIi8+CiAg IDxzeXNjYWxsIG5hbWU9ImZhbGxvY2F0ZSIgbnVtYmVyPSIzMjQiIGdyb3Vwcz0iZGVzY3Jp cHRvciIvPgogICA8c3lzY2FsbCBuYW1lPSJ0aW1lcmZkX3NldHRpbWUiIG51bWJlcj0iMzI1 IiBncm91cHM9ImRlc2NyaXB0b3IiLz4KKyAgPHN5c2NhbGwgbmFtZT0icGlwZTIiIG51bWJl cj0iMzMxIiBncm91cHM9ImRlc2NyaXB0b3IiLz4KIDwvc3lzY2FsbHNfaW5mbz4KZGlmZiAt LWdpdCBhL2dkYi9zeXNjYWxscy9pMzg2LWxpbnV4LnhtbC5pbiBiL2dkYi9zeXNjYWxscy9p Mzg2LWxpbnV4LnhtbC5pbgppbmRleCBlNzc4YWI1NDA0My4uMTNjNGQxZDk5ZDQgMTAwNjQ0 Ci0tLSBhL2dkYi9zeXNjYWxscy9pMzg2LWxpbnV4LnhtbC5pbgorKysgYi9nZGIvc3lzY2Fs bHMvaTM4Ni1saW51eC54bWwuaW4KQEAgLTMzNyw0ICszMzcsNSBAQAogICA8c3lzY2FsbCBu YW1lPSJldmVudGZkIiBudW1iZXI9IjMyMyIvPgogICA8c3lzY2FsbCBuYW1lPSJmYWxsb2Nh dGUiIG51bWJlcj0iMzI0Ii8+CiAgIDxzeXNjYWxsIG5hbWU9InRpbWVyZmRfc2V0dGltZSIg bnVtYmVyPSIzMjUiLz4KKyAgPHN5c2NhbGwgbmFtZT0icGlwZTIiIG51bWJlcj0iMzMxIi8+ CiA8L3N5c2NhbGxzX2luZm8+Cg== --------------E6rpMkLTTQ0t3g0xE3AbVY63--