From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id gYYXJaBwGmEmDAAAWB0awg (envelope-from ) for ; Mon, 16 Aug 2021 10:05:20 -0400 Received: by simark.ca (Postfix, from userid 112) id 854B81EDFB; Mon, 16 Aug 2021 10:05:20 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E170B1EA7E for ; Mon, 16 Aug 2021 10:05:19 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7638B394AC39 for ; Mon, 16 Aug 2021 14:05:19 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7638B394AC39 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1629122719; bh=gPHpvlNq2qK4Tnv9TxagROsPGjxE+O/DER92c9o32yY=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=u6ayk8I4ibrFYc0+gpmaKCXT0MsRUksA8QUlToxCjk3LOqUAcbnb96Rf7Tyd/0BtT +Cn/mkkUo++vHiKdLkP8aeuPL8GfhGTI/VRHcqvkgzn+k5Z6glelGw4tuXim8U8BVw 18GVK+tJfan02D8F36bIXoomY/EyYlsioP6wHXvw= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 056D9383B432 for ; Mon, 16 Aug 2021 14:04:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 056D9383B432 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 17GE4YPQ004081 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 16 Aug 2021 10:04:39 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 17GE4YPQ004081 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 8607D1EA7E; Mon, 16 Aug 2021 10:04:34 -0400 (EDT) Subject: Re: [PATCH] Notify observer of breakpoint auto-disabling To: Patrick Monnerat , gdb-patches@sourceware.org References: <20210816124420.255018-1-patrick@monnerat.net> Message-ID: Date: Mon, 16 Aug 2021 10:04:34 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210816124420.255018-1-patrick@monnerat.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Mon, 16 Aug 2021 14:04:34 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 2021-08-16 8:44 a.m., Patrick Monnerat via Gdb-patches wrote: > As breakpoint_modified observer is currently notified upon breakpoint stop > before handling auto-disabling when enable count is reached, the observer > is never notified of the disabling. > > The problem affects: > - The MI interpreter enabled= value when reporting =breakpoint-modified > - A Python event handler for breakpoint_modified using the "enabled" > member of its parameter > - insight: breakpoint GUI window is not properly updated upon auto-disable > > This patch moves the observer notification after the auto-disabling > code and implements corresponding tests for the MI and Python cases. > > Fixes https://sourceware.org/bugzilla/show_bug.cgi?id=23336 Thanks, this is ok to push. Do you have push access? Would you like to push this on your behalf? Simon