From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 74741 invoked by alias); 28 Aug 2018 16:03:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 74727 invoked by uid 89); 28 Aug 2018 16:03:23 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:586 X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 28 Aug 2018 16:03:20 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id w7SG3CW9018838 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 28 Aug 2018 12:03:17 -0400 Received: by simark.ca (Postfix, from userid 112) id CB2181E186; Tue, 28 Aug 2018 12:03:12 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 8E3481E05F; Tue, 28 Aug 2018 12:03:11 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 28 Aug 2018 16:03:00 -0000 From: Simon Marchi To: Alan Hayward Cc: gdb-patches@sourceware.org, nd@arm.com Subject: Re: [PATCH 3/4] Aarch64: Float register detection for return values. In-Reply-To: <20180820092933.83224-4-alan.hayward@arm.com> References: <20180820092933.83224-1-alan.hayward@arm.com> <20180820092933.83224-4-alan.hayward@arm.com> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.6 X-IsSubscribed: yes X-SW-Source: 2018-08/txt/msg00691.txt.bz2 On 2018-08-20 05:29, Alan Hayward wrote: > Use aapcs_is_vfp_call_or_return_candidate to detect float register > args. > > Remove the no longer used is_hfa_or_hva(). > > 2018-08-20 Alan Hayward > > PR gdb/22943: > * aarch64-tdep.c (is_hfa_or_hva): Remove function. > (aarch64_extract_return_value): Use > aapcs_is_vfp_call_or_return_candidate. > (aarch64_return_in_memory): Likewise. > (aarch64_store_return_value): Likewise. LGTM too, with the same disclaimer as the previous patches. Simon