From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12590 invoked by alias); 12 Apr 2017 14:26:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 11254 invoked by uid 89); 12 Apr 2017 14:25:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 12 Apr 2017 14:25:57 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id F12057AEA4; Wed, 12 Apr 2017 14:25:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com F12057AEA4 Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com F12057AEA4 Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.phx2.redhat.com [10.5.9.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 56C5860BE7; Wed, 12 Apr 2017 14:25:57 +0000 (UTC) Subject: Re: [PATCH] gdb: Move DJGPP/go32 bits to their own tdep file To: Eli Zaretskii References: <1492003875-25394-1-git-send-email-palves@redhat.com> <83bms1ka9s.fsf@gnu.org> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: Date: Wed, 12 Apr 2017 14:26:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-04/txt/msg00334.txt.bz2 On 04/12/2017 03:07 PM, Pedro Alves wrote: > On 04/12/2017 02:47 PM, Eli Zaretskii wrote: >>> From: Pedro Alves >>> Cc: Eli Zaretskii >>> Date: Wed, 12 Apr 2017 14:31:15 +0100 >>> >>> I posit that this makes them easier to find. >>> >>> The other day while working on the wchar_t patch, I had a bit of >>> trouble finding the DJGPP/go32 tdep bits. My initial reaction was >>> looking for a go32-specific tdep file, but there's none. >> >> Thanks, but why single out go32? > > Because incremental progress. Specifically, the "trouble finding djgpp bits" I'm referring to happened after you pointed me that djgpp needed a tweak too: https://sourceware.org/ml/gdb-patches/2017-03/msg00538.html At first, I didn't see a tdep file and so I thought that I'd have to add one, and maybe come up with a djgpp arch sniffer. It took me a few minutes to realize that we already have go32-specific tdep bits in the generic i386 file. So that's my only motivation -- exactly to make it easier to spot the djgpp bits quicker. There's no other rationale behind this. If I'll have to go do more things to other ports to get this in, I'm afraid I'll just drop the patch, because _I_ will have learned about them and know next time where to look. Thanks, Pedro Alves