From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id XG4sNYe6u2oGkhcAWB0awg (envelope-from ) for ; Tue, 29 Sep 2026 09:17:59 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=ok/vYSWb; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=xqT8AVo3; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=dlgOTCRB; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=CN6P+Ybm; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id AB5601E06B; Tue, 29 Sep 2026 09:17:59 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 8D8731E01F for ; Tue, 29 Sep 2026 09:17:58 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B875D4BB3B98 for ; Tue, 29 Sep 2026 13:17:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B875D4BB3B98 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=ok/vYSWb; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=xqT8AVo3; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=dlgOTCRB; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=CN6P+Ybm Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id 3C43C4BB3BC4 for ; Tue, 29 Sep 2026 13:16:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3C43C4BB3BC4 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3C43C4BB3BC4 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790687797; cv=none; b=Hw5zvqE7QEVnYBFDyvMg2cXZ6ZlPDQGm8eHS5rO7O80O8kTBRzq0m4bcZt2AzSesv0THOfCbqTZHE75AMz+1yIGQR8UcLOk0fs5IE4sF1XUoFokiC9ReR145zoV+k58oaN/xaMbatMKRT3zAAyiK7eV+T4jRTZqe0fxza9qRy50= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790687797; c=relaxed/simple; bh=gHOdwafzEwGnn1Z8xuAV8l+7xEF7rtOZLTiA2iwXUes=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:From:To; b=xXMLNBvITG6dOnFlpU28H5bwZR1d5Tj3kPVFfoDACK7pKKpEOX5YD6V7tFqI/yGPiPC9+QjDIBR8G/6GKuh1B5YhX/XKcVEfUkVXfv58pG+CDOa5DqFjP8aM8HZP3ezguJSZW1XLq1HDB8N7r8C3QNo2NdE/7wkkd4isUi4Qa+0= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=ok/vYSWb; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=xqT8AVo3; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=dlgOTCRB; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=CN6P+Ybm DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3C43C4BB3BC4 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 01BA11F785 for ; Tue, 29 Sep 2026 13:16:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1790687792; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XqwLz+jIqV6rE19bJvicRkOUVbhPGlsBcwo038atkUs=; b=ok/vYSWbLkOh50iuM+hFMeVaaaUPWbbnNy8x1Ri/BuY8EzjTvkCKQ5VBg5QS3osCmz9bLJ Xp61X/BvTEO0PprSugo8EKY15GF9Pn7EPzsHuZim+HUEtVYNU6Tzz4Eah/deYYLBtwWIGj hCVBP/+pWjFN7D7zBSxB6D0fgwBB7M8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1790687792; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XqwLz+jIqV6rE19bJvicRkOUVbhPGlsBcwo038atkUs=; b=xqT8AVo3m/wS8KVQCITU0I8JtBIljxxDf535hcBLjP3QvlT0v1rcyr9Gsh1vgZm0iUduKJ kMvyYMo8N6b5n5Dw== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=dlgOTCRB; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=CN6P+Ybm DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1790687788; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XqwLz+jIqV6rE19bJvicRkOUVbhPGlsBcwo038atkUs=; b=dlgOTCRBXwodVJlJORXZIqFKN5P0hQEPi8n+UcszgDDOfyixKFtTIaCumqcryqFTVWE7jg klyWNzYnrPel0E9v3xdQ3i6MjsLOO9lZ60vd0+vh/lbkzx+TU+mf7iyLj9jlJEp2UY87/2 z3l7Hkbe+NYkM6L/VdwaFQd/bPIiTvE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1790687788; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XqwLz+jIqV6rE19bJvicRkOUVbhPGlsBcwo038atkUs=; b=CN6P+Ybmfh7H4Z2rLOKjbBXrHqAes1ud+CffYRaufOBDYo6Hq4k5ToPcW09iSxS441g+wO pdyPx/ZbuGVSVtCA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 8721D136E4 for ; Tue, 29 Sep 2026 13:16:27 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id er3iFSu6u2pSDwAAD6G6ig (envelope-from ) for ; Tue, 29 Sep 2026 13:16:27 +0000 Message-ID: Date: Tue, 29 Sep 2026 15:16:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC 5/5] [gdb/testsuite] Reformat gdb.ada From: Tom de Vries To: gdb-patches@sourceware.org References: <20260904093858.359604-1-tdevries@suse.de> <20260904093858.359604-5-tdevries@suse.de> Content-Language: en-US In-Reply-To: <20260904093858.359604-5-tdevries@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Queue-Id: 01BA11F785 X-Rspamd-Action: no action X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; RCVD_TLS_ALL(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,suse.de:mid,suse.de:dkim,sourceware.org:url]; MIME_TRACE(0.00)[0:+]; RCPT_COUNT_ONE(0.00)[1]; MID_RHS_MATCH_FROM(0.00)[]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:104:10:150:64:97:from,2a07:de40:b281:106:10:150:64:167:received]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_NONE(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; DKIM_TRACE(0.00)[suse.de:+] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 9/4/26 11:38 AM, Tom de Vries wrote: > The gdb/testsuite/gdb.ada directory was recently (Dec 2025) reindented by > commit 6779faa9cea ("Reindent gdb.ada tests"). > > So this is a good candidate to see the impact of the indent-exp approach. > > Run: > ... > $ pre-commit run \ > --hook-stage manual \ > indent-exp \ > --files $(find gdb/testsuite/gdb.ada -type f -name "*.exp*") > ... > > In gdb.ada/ptype_field.exp, a comment looking like this is fixed: > ... > # foo \ > # bar > ... > to: > ... > # foo \ > # bar > ... > > The change results in excessive indentation in gdb.ada/var_shadowing.exp. > Manually fix this using: > ... > -gdb_test "info locals" [multi_line \ > +gdb_test "info locals" \ > + [multi_line \ > ... > and reformat the same test to be more typical. I've pushed a patch similar to this ( https://sourceware.org/pipermail/gdb-patches/2026-September/230724.html ). I rebased, and left out the changes where I added a comment marker after a trailing backslash in a comment block. Thanks, - Tom > --- > gdb/testsuite/gdb.ada/non-ascii-latin-3.exp | 2 +- > gdb/testsuite/gdb.ada/ptype_field.exp | 8 ++++---- > gdb/testsuite/gdb.ada/var_shadowing.exp | 13 +++++++------ > 3 files changed, 12 insertions(+), 11 deletions(-) > > diff --git a/gdb/testsuite/gdb.ada/non-ascii-latin-3.exp b/gdb/testsuite/gdb.ada/non-ascii-latin-3.exp > index fd4cd5f064c..8dd422cfb7b 100644 > --- a/gdb/testsuite/gdb.ada/non-ascii-latin-3.exp > +++ b/gdb/testsuite/gdb.ada/non-ascii-latin-3.exp > @@ -67,4 +67,4 @@ gdb_test break_2 "Breakpoint $decimal .*" \ > "gdb_breakpoint: set breakpoint at func_ż" > > gdb_test print_3 "warning: charset conversion failure.*" \ > - "print var_𝕯" > + "print var_𝕯" > diff --git a/gdb/testsuite/gdb.ada/ptype_field.exp b/gdb/testsuite/gdb.ada/ptype_field.exp > index e808b8492bb..4e326a7ca98 100644 > --- a/gdb/testsuite/gdb.ada/ptype_field.exp > +++ b/gdb/testsuite/gdb.ada/ptype_field.exp > @@ -64,10 +64,10 @@ gdb_test "complete ptype pck.c" "ptype pck\\.circle" > > # We can't query the members of a package yet, and this yields a bit > # too much output, so comment out for now instead of kfailing. > -# gdb_test "complete ptype pck." \ > - # [multi_line \ > - # "ptype pck\\.circle" \ > - # "ptype pck\\.position"] > +# gdb_test "complete ptype pck." \# > +# [multi_line \# > +# "ptype pck\\.circle" \# > +# "ptype pck\\.position"] > > gdb_test "complete ptype circle.pos." \ > [multi_line \ > diff --git a/gdb/testsuite/gdb.ada/var_shadowing.exp b/gdb/testsuite/gdb.ada/var_shadowing.exp > index ffa96b049cf..468485b118f 100644 > --- a/gdb/testsuite/gdb.ada/var_shadowing.exp > +++ b/gdb/testsuite/gdb.ada/var_shadowing.exp > @@ -20,7 +20,7 @@ require allow_ada_tests > standard_ada_testfile var_shadowing > > if {[gdb_compile_ada "${srcfile}" "${binfile}" \ > - executable [list debug]] != "" } { > + executable [list debug]] != "" } { > return > } > > @@ -32,8 +32,9 @@ set i_level3 [gdb_get_line_number "I-Level3"] > set bp_location [gdb_get_line_number "BREAK"] > runto "var_shadowing.adb:$bp_location" > > -gdb_test "info locals" [multi_line \ > - "i = 111\t<$testfile.adb:$i_level3>" \ > - "i = 11\t<$testfile.adb:$i_level2, shadowed>" \ > - "i = 1\t<$testfile.adb:$i_level1, shadowed>" \ > -] "info locals at innermost level" > +gdb_test "info locals" \ > + [multi_line \ > + "i = 111\t<$testfile.adb:$i_level3>" \ > + "i = 11\t<$testfile.adb:$i_level2, shadowed>" \ > + "i = 1\t<$testfile.adb:$i_level1, shadowed>"] \ > + "info locals at innermost level"