Re: [PATCH v2] Remove stale pre-AIX-7.2 compatibility guards

[Ulrich Weigand <Ulrich.Weigand@de.ibm.com>]

Aditya Vidyadhar Kamath <akamath996@gmail.com> wrote:

>       if (data->arch64)
> 	{
>-	  if (!ptrace64aix (PTT_READ_GPRS, tid,
>+	  if (!ptraceaix (PTT_READ_GPRS, tid,
> 			    (unsigned long) gprs64, 0, NULL))
> 	    memset (gprs64, 0, sizeof (gprs64));
> 	  memcpy (context->gpr, gprs64, sizeof(gprs64));
> 	}
>       else
> 	{
>-	  if (!ptrace32 (PTT_READ_GPRS, tid, (uintptr_t) gprs32, 0,
>NULL))
>+	  if (!ptraceaix (PTT_READ_GPRS, tid, (uintptr_t) gprs32, 0,
>NULL))
> 	    memset (gprs32, 0, sizeof (gprs32));
> 	  memcpy (context->gpr, gprs32, sizeof(gprs32));

I understand this may be a pre-existing problem, but that looks
weird now.  The "gprs64" and "gprs32" structures have different
layout and size, but you use the exact same call to fill them,
and then copy them to the same destination.

It looks to me there may be some confusion between 64/32-bit
inferiors and 64/32 GDB builds here ...

Bye,
Ulrich