Re: [PATCH] [gdb/testsuite] Fix gdb.base/local-env.exp on remote host

Tom de Vries
2026-01-03T15:11:56Z

On 12/11/25 4:42 PM, Tom de Vries wrote:
> With host/target board local-remote-host-native.exp and other remote host
> configurations, and test-case gdb.base/local-env.exp I get:
> ...
> (gdb) show environment^M
> ...
> (gdb) FAIL: $exp: show environment displayed variable
> ...
>
> The test attempt to detect variable GDB_TEST_ENV_VAR in the environment, which
> has been set with setenv.
>
> This doesn't work with remote host, so declare the test unsupported. Likewise
> in gdb.base/environ.exp.
>

I've pushed this.

Thanks,
- Tom

> Tested on x86_64-linux with make-check-all.sh.
> ---
> gdb/testsuite/gdb.base/environ.exp | 7 ++++++-
> gdb/testsuite/gdb.base/local-env.exp | 7 ++++++-
> 2 files changed, 12 insertions(+), 2 deletions(-)
>
> diff --git a/gdb/testsuite/gdb.base/environ.exp b/gdb/testsuite/gdb.base/environ.exp
> index 091010acfda..d95a6f7d03c 100644
> --- a/gdb/testsuite/gdb.base/environ.exp
> +++ b/gdb/testsuite/gdb.base/environ.exp
> @@ -46,7 +46,12 @@ gdb_test_multiple "show environment" "show environment works" -lbl {
> }
> }
>
> -gdb_assert {$saw_env == 1} "show environment displayed variable"
> +set test "show environment displayed variable"
> +if {[is_remote host]} {
> + unsupported $test
> +} else {
> + gdb_assert {$saw_env == 1} $test
> +}
>
> # Verify that we can unset a specific environment variable.
> gdb_test_no_output "unset environment EDITOR" "unset environment variable"
> diff --git a/gdb/testsuite/gdb.base/local-env.exp b/gdb/testsuite/gdb.base/local-env.exp
> index c62ea746635..394504cd79b 100644
> --- a/gdb/testsuite/gdb.base/local-env.exp
> +++ b/gdb/testsuite/gdb.base/local-env.exp
> @@ -48,7 +48,12 @@ gdb_test_multiple "show environment" "show environment works" -lbl {
> }
> }
>
> -gdb_assert {$saw_env == 1} "show environment displayed variable"
> +set test "show environment displayed variable"
> +if {[is_remote host]} {
> + unsupported $test
> +} else {
> + gdb_assert {$saw_env == 1} $test
> +}
>
> # Verify that we can unset a specific environment variable.
> gdb_test_no_output "unset local-environment EDITOR" \
>
> base-commit: 4f9b9eaa24383d920f37fbeb0592113252e37bbc