From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 9pHeKMsdRWkh3gkAWB0awg (envelope-from ) for ; Fri, 19 Dec 2025 04:41:31 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=ulPyKlRX; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=mM30PxCx; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=zc+ndTg4; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=O4VPOhjZ; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 9953A1E08D; Fri, 19 Dec 2025 04:41:31 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 7A72E1E08D for ; Fri, 19 Dec 2025 04:41:30 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id E79754BA2E23 for ; Fri, 19 Dec 2025 09:41:29 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E79754BA2E23 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=ulPyKlRX; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=mM30PxCx; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=zc+ndTg4; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=O4VPOhjZ Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id 72A924BA2E05 for ; Fri, 19 Dec 2025 09:41:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 72A924BA2E05 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 72A924BA2E05 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1766137260; cv=none; b=jL3+9oNFZWyW+Sp4G6IQiyOSmI91FHmtUxjIK0rP7UpcO/S71Ue656elAVOprYvTCXtOJYK/1/Af10uR55XAuOZC3674DEJDdZ5U7wlkf2gnHexp7lA/UTIO2GunSLTz3iX1QOHwx8Qh0YNZk2F5yPSmf1yhzxIAI41NEuOZBrM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1766137260; c=relaxed/simple; bh=VQJT6lhKdcIuLdX8J0uC6Pm1nBD89g4Goanc8ckZU3U=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=LqkTxzHi98Eq4ULUgJTsd0jTZrXvgyqtjP0stAPXa3offV1FqDK5XZLTyoVryKDlUz4/hF51D8ReWVts3hlPbyyrQGNy/7PI97SOF/58RFMxBHMJFliwyP0GBXS3NLpjbqiCmvZWrzBWBznftRSBozUbmb6bZpetHzesNmrqJOo= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 72A924BA2E05 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 579BE5BD14; Fri, 19 Dec 2025 09:40:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1766137259; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0EXjSFp9bKznLO5Na+JRheVd19/arDGbY4YC3o7Kpkw=; b=ulPyKlRXRPWewoHGLNcC+TfhLktUdit89sx6r+TYdV/dt6DyPa1l2KF1083Urr8diy6mhQ tZ13XLwpIXKQAm/eQAV5SGjBmFOhK6NC835BDGrqaW9EtCnV5KggtKQVpFp9Jca6Agl/At MO4TJELFdtapcTzsIDOyv7ZwOsoBpoY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1766137259; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0EXjSFp9bKznLO5Na+JRheVd19/arDGbY4YC3o7Kpkw=; b=mM30PxCxCkjNW3UMaps2yVlG6VGKUNJ6CvPdxU/HpDBe8WEmxwKiLIEVXNDddL9jHeAMha NStRJ4STCZNaFODA== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1766137258; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0EXjSFp9bKznLO5Na+JRheVd19/arDGbY4YC3o7Kpkw=; b=zc+ndTg41pZdcJNewWrgIBHpK/dTA7NS9hpCNCJ8sqbxY2DyJ5AqZ6y0FowwJTjlVCczw2 ZoQc9BAVmJ37linHloZ0xEesahGTRONZ19QcWTu/aWTdP51yJcsbp2VKh5IPV/oYSAUJw4 SVJ4MRk2sPAl0WhgoRUHYD9ZZH5N/+U= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1766137258; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0EXjSFp9bKznLO5Na+JRheVd19/arDGbY4YC3o7Kpkw=; b=O4VPOhjZ2oTKyjl+Ws9Pni24+NJtbsG0ErdUnkO8bKIiDq0oJTZm0dJFJzJSpwC7XnNyCP yK4mox4gA28ESRBA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 3EE743EA63; Fri, 19 Dec 2025 09:40:58 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id KMnxDaodRWlMBQAAD6G6ig (envelope-from ); Fri, 19 Dec 2025 09:40:58 +0000 Message-ID: Date: Fri, 19 Dec 2025 10:40:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] [gdb/testsuite] Fix gdb.base/local-env.exp on remote host To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20251211154211.1086859-1-tdevries@suse.de> <877bujmxap.fsf@tromey.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <877bujmxap.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-4.29 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.19)[-0.940]; MIME_GOOD(-0.10)[text/plain]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; MIME_TRACE(0.00)[0:+]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_DN_SOME(0.00)[] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 12/18/25 7:58 PM, Tom Tromey wrote: >>>>>> "Tom" == Tom de Vries writes: > > Tom> This doesn't work with remote host, so declare the test unsupported. Likewise > Tom> in gdb.base/environ.exp. > > Tom> -gdb_assert {$saw_env == 1} "show environment displayed variable" > Tom> +set test "show environment displayed variable" > Tom> +if {[is_remote host]} { > Tom> + unsupported $test > Tom> +} else { > Tom> + gdb_assert {$saw_env == 1} $test > > I've been under the impression we usually use unsupported to indicate > that an entire .exp is being skipped, Those uses indeed do exist. > and for individual tests we simply > don't invoke them. > > However I guess I don't really know. Do we have other cases like this? Those uses also exist. I grepped for unsupported in gdb.base, and the first two hits are like this. In access-mem-running.exp, a proc test is run with non-stop and all-stop, and this code: ... # If debugging with target remote, check whether the all-stop variant # of the RSP is being used. If so, we can't run the background tests. if {!$non_stop && [target_info exists gdb_protocol] && ([target_info gdb_protocol] == "remote" || [target_info gdb_protocol] == "extended-remote")} { if {![is_target_non_stop]} { unsupported "can't issue commands while target is running" return 0 } } ... aborts the proc in one of those cases. Then in annota1.exp we have: ... if {[target_info exists gdb,nosignals]} { unsupported "send SIGUSR1" unsupported "backtrace @ signal handler" } else { ... This one is from 2004. Thanks, - Tom