From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id A1200383F85C for ; Tue, 12 May 2020 22:44:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org A1200383F85C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [10.0.0.193] (unknown [192.222.164.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 0B50D1E79B; Tue, 12 May 2020 18:44:21 -0400 (EDT) Subject: Re: [PATCH] testsuite: use cygpath to convert from Unix to Windows paths To: Tom Tromey Cc: Simon Marchi , gdb-patches@sourceware.org References: <20200311183212.28601-1-simon.marchi@efficios.com> <835zfaaelk.fsf@gnu.org> <88902aeb-5643-073b-a2de-f9a051bae6d8@simark.ca> <87imj8dtns.fsf@tromey.com> <87a74kdq80.fsf@tromey.com> From: Simon Marchi Message-ID: Date: Tue, 12 May 2020 18:44:20 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <87a74kdq80.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Language: tl Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 May 2020 22:44:23 -0000 On 2020-03-13 3:11 p.m., Tom Tromey wrote: > Tom> Today I tried something a little weird -- I did a mingw build on Linux > Tom> and then tried to run the gdb.server test cases. Linux can run mingw > Tom> executables via wine... > > Tom> However this fails with: > > Tom> ERROR: tcl error sourcing /home/tromey/gdb/build-mingw/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.server/wrapper.exp. > Tom> ERROR: sh: line 0: pwd: -W: invalid option > Tom> pwd: usage: pwd [-LP] > > It failed this way on the Windows machine I have access to as well. > > I believe on that machine, I log in to a Cygwin environment, but > normally I do mingw-hosted builds. The Cygwin "pwd" doesn't understand -W. Hey, I missed that somehow, sorry about that. I think I could implement something where we try multiple methods in sequence: 1. cygpath 2. pwd -W 3. the original regsub that was there prior to this patch Would this help? Simon