From: "Andrew Pinski" <pinskia@gmail.com>
To: "Steve Ellcey" <sje@cup.hp.com>
Cc: jjohnstn@redhat.com, bonzini@gnu.org,
libtool@cwilson.fastmail.fm, newlib@sourceware.org,
aoliva@redhat.com, gcc-patches@gcc.gnu.org,
gdb-patches@sourceware.org, binutils@sourceware.org
Subject: Re: New libtool is in the GCC and Src trees.
Date: Fri, 25 May 2007 00:12:00 -0000 [thread overview]
Message-ID: <de8d50360705241712p6da39377sed4d9ee9e924d10b@mail.gmail.com> (raw)
In-Reply-To: <200705241735.KAA09881@hpsje.cup.hp.com>
[-- Attachment #1: Type: text/plain, Size: 514 bytes --]
On 5/24/07, Steve Ellcey <sje@cup.hp.com> wrote:
> The GCC and src trees have been updated with the new libtool. Let me
> know if you run into problems.
And this breaks libobjc building libobjc.a and/or libobjc.so because
we now build libobja.a which is wrong. This patch fixes the problem.
Committed after a bootstrap and tested on i686-linux-gnu with no
regressions and build and tested for spu-elf with no regressions.
Thanks,
Andrew Pinski
libobjc/ChangeLog:
* Makefile.in: Remove all uses of $(libext).
[-- Attachment #2: fixlibobjc.diff.txt --]
[-- Type: text/plain, Size: 2020 bytes --]
Index: Makefile.in
===================================================================
--- Makefile.in (revision 125044)
+++ Makefile.in (working copy)
@@ -42,7 +42,6 @@ toolexecdir = @toolexecdir@
toolexeclibdir = @toolexeclibdir@
includedirname = @includedirname@
-libext = @libext@
extra_ldflags_libobjc = @extra_ldflags_libobjc@
@@ -137,7 +136,7 @@ FLAGS_TO_PASS = \
"libsubdir=$(libsubdir)" \
"tooldir=$(tooldir)"
-all: libobjc$(libext).la $(OBJC_BOEHM_GC)
+all: libobjc.la $(OBJC_BOEHM_GC)
: $(MAKE) ; exec $(MULTIDO) $(FLAGS_TO_PASS) multi-do DO=all
# User-visible header files.
@@ -274,12 +273,12 @@ doc: info dvi pdf html
install-html:
install-pdf:
-libobjc$(libext).la: $(OBJS)
+libobjc.la: $(OBJS)
$(LIBTOOL_LINK) $(CC) -o $@ $(OBJS) \
-rpath $(toolexeclibdir) \
-version-info $(LIBOBJC_VERSION) $(extra_ldflags_libobjc)
-libobjc_gc$(libext).la: $(OBJS_GC)
+libobjc_gc.la: $(OBJS_GC)
$(LIBTOOL_LINK) $(CC) -o $@ $(OBJS_GC) \
-rpath $(toolexeclibdir) \
-version-info $(LIBOBJC_GC_VERSION) $(extra_ldflags_libobjc)
@@ -334,9 +333,9 @@ install: install-libs install-headers
install-libs: installdirs
$(SHELL) $(multi_basedir)/mkinstalldirs $(DESTDIR)$(toolexeclibdir)
- $(LIBTOOL_INSTALL) $(INSTALL) libobjc$(libext).la $(DESTDIR)$(toolexeclibdir);
+ $(LIBTOOL_INSTALL) $(INSTALL) libobjc.la $(DESTDIR)$(toolexeclibdir);
if [ "$(OBJC_BOEHM_GC)" ]; then \
- $(LIBTOOL_INSTALL) $(INSTALL) libobjc_gc$(libext).la \
+ $(LIBTOOL_INSTALL) $(INSTALL) libobjc_gc.la \
$(DESTDIR)$(toolexeclibdir);\
fi
$(MULTIDO) $(FLAGS_TO_PASS) multi-do DO="$@"
@@ -353,7 +352,7 @@ install-headers:
check uninstall install-strip dist installcheck installdirs:
mostlyclean:
- -$(LIBTOOL_CLEAN) rm -f libobjc$(libext).la libobjc_gc$(libext).la *.lo
+ -$(LIBTOOL_CLEAN) rm -f libobjc.la libobjc_gc.la *.lo
-rm -f runtime-info.h tmp-runtime.s *.o *.lo libobjc* xforward \
fflags *.aux *.cp *.dvi *.pdf *.fn *.info *.ky *.log *.pg \
*.toc *.tp *.vr *.html libobj.exp
next prev parent reply other threads:[~2007-05-25 0:12 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-24 17:35 Steve Ellcey
2007-05-24 18:07 ` Steve Ellcey
2007-05-24 18:46 ` Steve Ellcey
2007-05-24 20:02 ` Andreas Tobler
2007-05-24 20:33 ` Steve Ellcey
2007-05-24 21:09 ` Andreas Tobler
2007-05-24 21:14 ` libtool
2007-05-24 22:13 ` Mike Stump
2007-05-25 17:38 ` Andreas Tobler
2007-05-25 17:43 ` Paolo Bonzini
2007-05-25 17:50 ` Eric Christopher
2007-05-25 19:33 ` Andreas Tobler
2007-05-25 19:39 ` Eric Christopher
2007-05-24 20:37 ` Mike Stump
2007-05-25 0:12 ` Andrew Pinski [this message]
2007-05-28 12:49 ` Andreas Schwab
2007-05-28 19:07 ` Charles Wilson
2007-05-29 1:25 ` Peter O'Gorman
2007-05-28 13:33 ` Andreas Schwab
[not found] <m3irah6d45.fsf@fleche.redhat.com>
2007-05-25 18:21 ` Steve Ellcey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de8d50360705241712p6da39377sed4d9ee9e924d10b@mail.gmail.com \
--to=pinskia@gmail.com \
--cc=aoliva@redhat.com \
--cc=binutils@sourceware.org \
--cc=bonzini@gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=jjohnstn@redhat.com \
--cc=libtool@cwilson.fastmail.fm \
--cc=newlib@sourceware.org \
--cc=sje@cup.hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox