From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 101918 invoked by alias); 14 Jul 2018 02:47:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 101903 invoked by uid 89); 14 Jul 2018 02:47:16 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=unusual X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 14 Jul 2018 02:47:15 +0000 Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id EBB751E093; Fri, 13 Jul 2018 22:47:11 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=simark.ca; s=mail; t=1531536433; bh=B+zMS8gLz4r/FZqzYyDc4vPMfFhNzZLCHwMuSuiTTd0=; h=Subject:To:References:From:Date:In-Reply-To:From; b=E6k92igNbOfEMHGroyxVFKHo1U8p5MbTrg4N+858JBpWJDDAcSsOcYXGA3mZRkbIN ofHs5l3TkWNKIYQfVjb5bQwkWlMhtrp+6GRTeY2hvkoqlHlk0RpuPOljUQVWqlfo6Y KqPPp/la6abMLdo4fL5k+K71L7oFPkomxk32Dy5k= Subject: Re: [RFA 11/13] Remove unused variables from gdbserver To: Tom Tromey , gdb-patches@sourceware.org References: <20180712205208.32646-1-tom@tromey.com> <20180712205208.32646-12-tom@tromey.com> From: Simon Marchi Message-ID: Date: Sat, 14 Jul 2018 02:47:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180712205208.32646-12-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-07/txt/msg00446.txt.bz2 On 2018-07-12 04:52 PM, Tom Tromey wrote: > This removes a few unused variables from gdbserver. > > The x86-tdesc.h change is a bit unusual for this series. This file > was not defining the multiple-include guard symbol, so I've added that > here. Also, it is hard to determine when i386_expedite_regs will be > needed, so this patch simply marks it ATTRIBUTE_UNUSED. That sounds reasonable to me, LGTM. Simon