From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 83AD13857C41 for ; Mon, 24 Aug 2020 21:31:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 83AD13857C41 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 07OLUsDo020728 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 24 Aug 2020 17:30:58 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 07OLUsDo020728 Received: from [10.0.0.11] (173-246-6-90.qc.cable.ebox.net [173.246.6.90]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id E8C001E009; Mon, 24 Aug 2020 17:30:53 -0400 (EDT) Subject: Re: [PATCH] gdb: add gdb_bfd_all_sections for range-based iteration To: Tom Tromey Cc: Simon Marchi via Gdb-patches References: <20200824194333.196744-1-simon.marchi@polymtl.ca> <87a6yjbxbf.fsf@tromey.com> <875z97bw3p.fsf@tromey.com> From: Simon Marchi Message-ID: Date: Mon, 24 Aug 2020 17:30:53 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <875z97bw3p.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Mon, 24 Aug 2020 21:30:54 +0000 X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-DCC: MGTINTERNET: antispam2020.polymtl.ca 1170; Body=1 Fuz1=1 Fuz2=1 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Aug 2020 21:31:04 -0000 On 2020-08-24 4:57 p.m., Tom Tromey wrote: >>> I also did this kind of thing -- I have some patches to remove many uses >>> of bfd_map_over_sections, though not all of them, since some seem hard >>> to test. > > Simon> What approach did you take? > > Almost exactly identical to yours -- I named the adapter > "gdb_bfd_sections". I can resurrect some of my patches after yours > lands. > > Tom > I modeled the "gdb_bfd_all_sections" on "all_threads" and "all_inferiors". But honestly the "all" sounds superfluous now that I re-read it. I'll push the patch with "all" removed from the name. Thanks! Simon