From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 51333 invoked by alias); 27 Feb 2019 18:13:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 51314 invoked by uid 89); 27 Feb 2019 18:13:02 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 27 Feb 2019 18:13:01 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id x1RICsFk002542 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 27 Feb 2019 13:12:59 -0500 Received: by simark.ca (Postfix, from userid 112) id C107E1E660; Wed, 27 Feb 2019 13:12:54 -0500 (EST) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 856B01E477; Wed, 27 Feb 2019 13:12:53 -0500 (EST) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 27 Feb 2019 18:13:00 -0000 From: Simon Marchi To: Adrian Prantl Cc: Eric Christopher , Tom Tromey , Jordan Rupprecht , gdb-patches , David Blaikie , Douglas Evans Subject: Re: [PATCH] [dwarf2read] Fix crash when loading dwp files: calculate num_sections based on actual section indices, not just the number of sections. In-Reply-To: <43BCD0FD-28C3-49E5-B7CB-4E18ACFBA646@apple.com> References: <439bf4f6859a539472a2e51a028b9503@polymtl.ca> <20190225201715.144927-1-rupprecht@google.com> <1b6df15638153631ea87fa1bc7c24dd2@polymtl.ca> <87wolmlh8g.fsf@tromey.com> <878sy187tp.fsf@tromey.com> <3c7c4b2b2211dee0d0cb273a2934dde9@polymtl.ca> <43BCD0FD-28C3-49E5-B7CB-4E18ACFBA646@apple.com> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.6 X-IsSubscribed: yes X-SW-Source: 2019-02/txt/msg00490.txt.bz2 On 2019-02-27 13:05, Adrian Prantl wrote: > Split DWARF solves a problem that doesn't exist on Darwin (macOS/iOS, > ...). The motivation behind split DWARF is to reduce the number of > relocations in debug info that have to be processed by the linker. But > on Darwin, debug info is not processed by the linker at all, instead a > tool called dsymutil (cf. llvm/tools/dsymutil) serves a conceptually > similar task to dwp and archives the debug info from the .o files into > a .dSYM bundle, separate from the executable. > > -- adrian Ok, thanks to both of you for confirming. I think we are fine using the elf-specific function. Simon