From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 44304 invoked by alias); 18 Apr 2017 18:42:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 43197 invoked by uid 89); 18 Apr 2017 18:42:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 18 Apr 2017 18:42:24 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7D44861B85; Tue, 18 Apr 2017 18:42:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 7D44861B85 Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 7D44861B85 Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.phx2.redhat.com [10.5.9.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7F3D183280; Tue, 18 Apr 2017 18:42:19 +0000 (UTC) Subject: Re: [RFA 1/5] Use ui_out_emit_tuple To: Tom Tromey , gdb-patches@sourceware.org References: <20170414022337.28368-1-tom@tromey.com> <20170414022337.28368-2-tom@tromey.com> From: Pedro Alves Message-ID: Date: Tue, 18 Apr 2017 18:42:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20170414022337.28368-2-tom@tromey.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-04/txt/msg00520.txt.bz2 On 04/14/2017 03:23 AM, Tom Tromey wrote: > This patch changes various places to use ui_out_emit_tuple, > eliminating a number of cleanups. This patch only tackles "easy" > cases, which are ones where the cleanups in question were > block-structured and did not involve any changes other than the > obvious replacement. > > 2017-04-13 Tom Tromey > > * record-btrace.c (record_btrace_insn_history) > (record_btrace_insn_history_range, record_btrace_call_history) > (record_btrace_call_history_range): Use ui_out_emit_tuple. > * thread.c (do_captured_list_thread_ids, print_thread_info_1): Use > ui_out_emit_tuple. > * stack.c (print_frame_info): Use ui_out_emit_tuple. > * solib.c (info_sharedlibrary_command): Use ui_out_emit_tuple. > * skip.c (skip_info): Use ui_out_emit_tuple. > * remote.c (show_remote_cmd): Use ui_out_emit_tuple. > * progspace.c (print_program_space): Use ui_out_emit_tuple. > * probe.c (info_probes_for_ops): Use ui_out_emit_tuple. > * osdata.c (info_osdata): Use ui_out_emit_tuple. > * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Use > ui_out_emit_tuple. > * mi/mi-main.c (print_one_inferior, list_available_thread_groups) > (output_register, mi_cmd_data_read_memory) > (mi_cmd_data_read_memory_bytes, mi_load_progress) > (mi_cmd_trace_frame_collected): Use ui_out_emit_tuple. > * mi/mi-cmd-var.c (mi_cmd_var_list_children, varobj_update_one): > Use ui_out_emit_tuple. > * mi/mi-cmd-stack.c (mi_cmd_stack_list_args): Use > ui_out_emit_tuple. > * mi/mi-cmd-info.c (mi_cmd_info_ada_exceptions) > (mi_cmd_info_gdb_mi_command): Use ui_out_emit_tuple. > * linux-thread-db.c (info_auto_load_libthread_db): Use > ui_out_emit_tuple. > * inferior.c (print_inferior): Use ui_out_emit_tuple. > * gdb_bfd.c (print_one_bfd): Use ui_out_emit_tuple. > * disasm.c (do_mixed_source_and_assembly_deprecated) > (do_mixed_source_and_assembly): Use ui_out_emit_tuple. > * cp-abi.c (list_cp_abis): Use ui_out_emit_tuple. > * cli/cli-setshow.c (cmd_show_list): Use ui_out_emit_tuple. > * breakpoint.c (print_one_breakpoint_location) > (print_one_breakpoint): Use ui_out_emit_tuple. > * auto-load.c (print_script, info_auto_load_cmd): Use > ui_out_emit_tuple. > * ada-tasks.c (print_ada_task_info): Use ui_out_emit_tuple. LGTM. Thanks, Pedro Alves