From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 9FfrNlWy5GiTliIAWB0awg (envelope-from ) for ; Tue, 07 Oct 2025 02:25:25 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=BGbZyCP9; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=2oKOoVbR; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=BGbZyCP9; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=2oKOoVbR; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id D29991E0B6; Tue, 07 Oct 2025 02:25:25 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 112AD1E04C for ; Tue, 07 Oct 2025 02:25:25 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 90CD73858CDA for ; Tue, 7 Oct 2025 06:25:24 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 90CD73858CDA Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=BGbZyCP9; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=2oKOoVbR; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=BGbZyCP9; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=2oKOoVbR Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id 709243858D1E for ; Tue, 7 Oct 2025 06:24:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 709243858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 709243858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1759818294; cv=none; b=dPIVtJFp75DbJXYF1imkIZGtvnJzU8mzh9r+CU1IgbHZf3VvV+zZeuoMLcuF/TiLa85Syx/r7BwKfL11/KNXv4+ZSiY43s3fC9OBt+ikp8gG63HIM2ypwYVtZZFDxw0oW64jM7HUbs3VRGYD5Zio7890LzFW22GSYkQcrizo3Co= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1759818294; c=relaxed/simple; bh=fnYWqfCHW808JCM8+GITWb8s22ygFwwigAC2S+f/MGs=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=SnivxzVB5+jrUnniHgB5fQpGl7fwUQZmKSWdkh5qis3GmyZyBIaBNRqVSgozWNr/DdsW/QM3nzzsfGMPr3DCb+ur3/psohiPHr4eyyq7bjQeAM0q/GwGqf8m9bQSqqJZWVDYpFp7fWEAKwYbdOZp8A3p94GYqCmM1WagFPioukY= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 709243858D1E Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 510A21F78B; Tue, 7 Oct 2025 06:24:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1759818293; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kOf2YqAaertdQvFyX3Pkb02pCffzt330HhW+xIekAkU=; b=BGbZyCP9I2Zqu/ty1B/747yI1mmh2kTh70pRKRnF+SjGqi9ekEjiFbm43MRzpMzeeQY9gi CudZk1o9BP1CM8+qwx6FnzSx9nITDy3eGErJcMG7krplfDlyV22wulJSXfCxCd+xs1HVZD XnNFa2LiacijpL6K/tiJ4TcLP9Syn/o= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1759818293; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kOf2YqAaertdQvFyX3Pkb02pCffzt330HhW+xIekAkU=; b=2oKOoVbRJn9S8nGa2fUqJplozRFKRnL8fa5yfSsyX7a/wBW4Xg3N5GEOL/B5AALppUKiXQ /OWUWgM1hS2/ZDDg== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1759818293; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kOf2YqAaertdQvFyX3Pkb02pCffzt330HhW+xIekAkU=; b=BGbZyCP9I2Zqu/ty1B/747yI1mmh2kTh70pRKRnF+SjGqi9ekEjiFbm43MRzpMzeeQY9gi CudZk1o9BP1CM8+qwx6FnzSx9nITDy3eGErJcMG7krplfDlyV22wulJSXfCxCd+xs1HVZD XnNFa2LiacijpL6K/tiJ4TcLP9Syn/o= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1759818293; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kOf2YqAaertdQvFyX3Pkb02pCffzt330HhW+xIekAkU=; b=2oKOoVbRJn9S8nGa2fUqJplozRFKRnL8fa5yfSsyX7a/wBW4Xg3N5GEOL/B5AALppUKiXQ /OWUWgM1hS2/ZDDg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 2294713AAC; Tue, 7 Oct 2025 06:24:53 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id znmkBjWy5GgqFQAAD6G6ig (envelope-from ); Tue, 07 Oct 2025 06:24:53 +0000 Message-ID: Date: Tue, 7 Oct 2025 08:24:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCHv2 3/3] gdb/python: add Corefile.mapped_files method To: Tom Tromey , Andrew Burgess Cc: gdb-patches@sourceware.org References: <9ab589510f784da2752b72d0b1385afa33aca406.1758634958.git.aburgess@redhat.com> <87cy737q50.fsf@tromey.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <87cy737q50.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-0.998]; MIME_GOOD(-0.10)[text/plain]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; TO_DN_SOME(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid,imap1.dmz-prg2.suse.org:helo] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 10/3/25 21:15, Tom Tromey wrote: > Andrew> Add a new Corefile.mapped_files method which returns a list of > Andrew> gdb.CorefileMappedFile objects. > > Andrew> Each gdb.CorefileMappedFile object represents a file that was mapped > Andrew> into the process when the core file was created. > > Andrew> + ** New Inferior.corefile attribute. This read only attribute > Andrew> + contains the gdb.Corefile object if a core file is loaded into > Andrew> + the inferior, otherwise, this contains None. > > This hunk is duplicated, it also appears in patch 1. > > Other than that this looks good to me. > Approved-By: Tom Tromey Hi, Starting with this commit, I see: ... (gdb) check-build-ids^M Python Exception : build-id mismatch for /lib64/libc.so.6^M Error occurred in Python: build-id mismatch for /lib64/libc.so.6^M (gdb) FAIL: gdb.python/py-corefile.exp: test mapped files data: check-build-ids ... Thanks, - Tom