Re: [PATCH 1/1] [gdb/contrib] Add make-check-all.sh

Tom de Vries via Gdb-patches
2023-04-21T15:41:54Z

On 4/20/23 16:30, Simon Marchi wrote:
> On 4/20/23 07:43, Tom de Vries wrote:
>> You say you don't understand the comment, but to me it seems you do so I'm not sure I understand what your concern is. Should the comment be improved, or do you want a change in functionality?
>
> I just wasn't sure which username I was expected to pass to those
> options, I wanted to confirm with you that the intent is to have
> dedicated systems users for that. So the comment could say that:
>
> It is recommended to create users on the local system that will act as
> "remote host" and "remote target", for the boards that use them.
> Pass their usernames to --host-user and --target-user. This helps
> because:
>
> - remote host/target boards will use $HOME and leave (potentially
> lots of) files behind
> - it enables more strict checking of build/host/target file
> manipulations.
> - it prevents a command running on one "machine" to kill or send a
> signal to a process on another machine
>

Ack, I've copied that and added a Co-Authored-By tag.

>> I've tried adding a bit more comments, updated version attached.
>
> Thanks, that LGTM.

Committed now.

Thanks,
- Tom