Re: [PATCH 1/2] gdb.ada/minsyms.exp: Don't hardcode the variable's address

Sergio Durigan Junior
2017-11-21T16:24:58Z

On Tuesday, November 21 2017, Pedro Alves wrote:

> This new testcase has a test that fails like this here:
>
> $1 = ( *) 0x60208c <some_minsym>
> (gdb) FAIL: gdb.ada/minsyms.exp: print &some_minsym
>
> The problem is that the testcase hardcodes an expected address for the
> "some_minsym" variable, which obviously isn't stable.
>
> Fix that by expecting $hex instead.

No Ada expert here, but I'd say this is borderline obvious and should go
in :-).

Thanks,

> gdb/testsuite/ChangeLog:
> 2017-11-21 Pedro Alves <palves@redhat.com>
>
> * gdb.ada/minsyms.exp: Accept any address for 'some_minsym'.
> ---
> gdb/testsuite/gdb.ada/minsyms.exp | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gdb/testsuite/gdb.ada/minsyms.exp b/gdb/testsuite/gdb.ada/minsyms.exp
> index 2c91125..9878f9f 100644
> --- a/gdb/testsuite/gdb.ada/minsyms.exp
> +++ b/gdb/testsuite/gdb.ada/minsyms.exp
> @@ -35,7 +35,7 @@ gdb_test "print integer(some_minsym)" \
> " = 1234"
>
> gdb_test "print &some_minsym" \
> - " = \\(access \\) 0x62c2f8 <some_minsym>"
> + " = \\(access \\) $hex <some_minsym>"
>
> gdb_test "print /x integer(&some_minsym)" \
> " = $hex"
> --
> 2.5.5

--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible