From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id WBHWKWJRU2URIAYAWB0awg (envelope-from ) for ; Tue, 14 Nov 2023 05:52:18 -0500 Received: by simark.ca (Postfix, from userid 112) id A7DF31E0D2; Tue, 14 Nov 2023 05:52:18 -0500 (EST) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 9C4291E091 for ; Tue, 14 Nov 2023 05:52:16 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3E9353838A31 for ; Tue, 14 Nov 2023 10:52:16 +0000 (GMT) Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) by sourceware.org (Postfix) with ESMTPS id 7584B38768B8 for ; Tue, 14 Nov 2023 10:51:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7584B38768B8 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7584B38768B8 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=209.85.128.48 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699959113; cv=none; b=pt1zGBv/8wlP/VUClAd38pAb29KgXSc33JzsGuV82QKTiu6+lRyTQZurUzX/RSCkyXFBzfCP8zlQZDFgpvBF/7OYRM3z7SSmihOnOPolNm9tBXc/OxEWYNp3Ky7cqqFp2IiuF2u8qGyB7IYTOsLUbI+qtX4FmB2vxhYLJlsIAfg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699959113; c=relaxed/simple; bh=GU8SNx6t0/CvF70DcRD8+5iSqU4l00+UDO5vDjSlia0=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=sn80BAlzLkrEnfc9gHg5hhLf6kgu+xNlFc4IVUjSgct8VsaSHPs7aiDXI80dFf8TtljeGfT1eVk/HTRLxYWrQmZYo6K/99FURtvHokIZrMvBSB7pYeaiV3OnC47KXFTZOQxQfdIhu1XJeuEx/DRuk8Ia4qyXPI85IUQ63gbHMNM= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-4079ed65582so42989045e9.1 for ; Tue, 14 Nov 2023 02:51:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699959110; x=1700563910; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Eur388hUXwSj3wnfFld2M7WbXmy8ByNRAVfx5/pEQtM=; b=T9q4licpdRxZ/xyX+EphoOJtlnZGxhuXUqQyUBmLyikMcWH5gSD63VWcnPs6G+wbrb g2B9MPgDOj+TOkYtCIJAd5Rk57v3f0/jCDssPCTo8oXIF+CNhzxgDli+J50pkdtl3K3d 999kOTpIMQ+EmoQTCXKzKjapt9lrgrV3WsFGCR6bhPp2QUCqusw9bNlCzJ6qqmoP/zIZ 9b+y2XaCHAswkNQ1TDebQxfqJf+tG8tCjrM/RE5MnJGylBySqwr7/Wseo0SzEj6kJEQY tpY8SjNsB5Hy/O19JOu1ODCfjtAPN9Bh9ClrxHRqbEMJ07/84Ig6QUtJi96KRHVpLgjp QRXg== X-Gm-Message-State: AOJu0Yzj+2G+eg7LbImd6OQJJndoyidcJNhQojkznrm4NN2A6ZmFU4s5 hx+akAmeO8sp++k63Dm4jQZiYTdkXrQDAQ== X-Google-Smtp-Source: AGHT+IGEYsmy9UioNLU0xXekdpV0qEa5TAXUtRAGwPe2dZoF2I77MgSfHIpifJiWPrJXQLyHhjkgoA== X-Received: by 2002:a05:600c:1986:b0:407:8e85:89ad with SMTP id t6-20020a05600c198600b004078e8589admr7799538wmq.14.1699959109935; Tue, 14 Nov 2023 02:51:49 -0800 (PST) Received: from ?IPV6:2001:8a0:f91e:1a00:b524:7bcc:766c:ef6f? ([2001:8a0:f91e:1a00:b524:7bcc:766c:ef6f]) by smtp.gmail.com with ESMTPSA id r15-20020a05600c458f00b0040472ad9a3dsm10994677wmo.14.2023.11.14.02.51.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Nov 2023 02:51:49 -0800 (PST) Message-ID: Date: Tue, 14 Nov 2023 10:51:43 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [FYI/pushed v4 00/25] Step over thread clone and thread exit Content-Language: en-US To: Tom de Vries , gdb-patches@sourceware.org References: <20231113150427.477431-1-pedro@palves.net> <2a6fd4e6-d01f-45ec-b12a-b1e157a27195@suse.de> From: Pedro Alves In-Reply-To: <2a6fd4e6-d01f-45ec-b12a-b1e157a27195@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-9.5 required=5.0 tests=BAYES_00, BODY_8BITS, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Hi Tom, On 2023-11-13 19:28, Tom de Vries wrote: > I'm seeing new FAILs: > ... > FAIL: gdb.threads/stepi-over-clone.exp: continue > FAIL: gdb.threads/stepi-over-clone.exp: third_thread=false: non-stop=on: displaced=off: i=0: stepi > FAIL: gdb.threads/stepi-over-clone.exp: third_thread=false: non-stop=on: displaced=off: i=0: $thread_count == 2 ... > ... > > First in more detail: > ... > (gdb) PASS: gdb.threads/stepi-over-clone.exp: catch process syscalls > continue^M > Continuing.^M > ^M > Catchpoint 2 (call to syscall clone), clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:78^M > warning: 78     ../sysdeps/unix/sysv/linux/x86_64/clone.S: No such file or directory^M > (gdb) FAIL: gdb.threads/stepi-over-clone.exp: continue > ... > Thanks. I think the patch below would fix this one. The others are hopefully something similar, but I wasn't able to spot anything wrong by inspection. I'd have to see the relevant part of the gdb.log to hazard a better guess. --- 8< --- From: Pedro Alves Subject: [PATCH] Fix gdb.threads/stepi-over-clone.exp regexp Tom de Vries reported this FAIL: (gdb) PASS: gdb.threads/stepi-over-clone.exp: catch process syscalls continue^M Continuing.^M ^M Catchpoint 2 (call to syscall clone), clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:78^M warning: 78 ../sysdeps/unix/sysv/linux/x86_64/clone.S: No such file or directory^M (gdb) FAIL: gdb.threads/stepi-over-clone.exp: continue All but one regexps in the .exp file use "clone\[23\]?" with "?" to also accept "clone", except the failing case. This commit fixes that case to also use "?". Change-Id: I74ca9e7d4cfe6af294fd50e8c509fcbad289b78c --- gdb/testsuite/gdb.threads/stepi-over-clone.exp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/testsuite/gdb.threads/stepi-over-clone.exp b/gdb/testsuite/gdb.threads/stepi-over-clone.exp index 4c496429632..18cfec19ffa 100644 --- a/gdb/testsuite/gdb.threads/stepi-over-clone.exp +++ b/gdb/testsuite/gdb.threads/stepi-over-clone.exp @@ -45,7 +45,7 @@ gdb_test_multiple "catch syscall group:process" "catch process syscalls" { } gdb_test "continue" \ - "Catchpoint $decimal \\(call to syscall clone\[23\]\\), .*" + "Catchpoint $decimal \\(call to syscall clone\[23\]?\\), .*" # Return true if INSN is a syscall instruction. base-commit: 319b460545dc79280e2904dcc280057cf71fb753 -- 2.34.1