From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17817 invoked by alias); 10 Oct 2016 22:46:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 17766 invoked by uid 89); 10 Oct 2016 22:46:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=sk:archive X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 10 Oct 2016 22:46:31 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 428FCC092195; Mon, 10 Oct 2016 22:46:30 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u9AMkTQf012637; Mon, 10 Oct 2016 18:46:29 -0400 Subject: Re: [RFA 15/22] Use std::string in macho_symfile_read_all_oso To: Tom Tromey References: <1474949330-4307-1-git-send-email-tom@tromey.com> <1474949330-4307-16-git-send-email-tom@tromey.com> <878ttvq14z.fsf@tromey.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: Date: Mon, 10 Oct 2016 22:46:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <878ttvq14z.fsf@tromey.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-10/txt/msg00236.txt.bz2 On 10/10/2016 11:39 PM, Tom Tromey wrote: >>>>>> "Pedro" == Pedro Alves writes: > >>> + if (strncmp (oso2->name, archive_name.c_str (), pfx_len) != 0) > > Pedro> Since archive_name is now a std::string, we can use ==/!= for string > Pedro> comparison: > Pedro> if (archive_name != oso2->name) > > It isn't entirely clear to me that this is valid, given that the current > comparison is using strncmp. Wow, I completely missed that, somehow. Sorry about that. I guess you could use std::string::compare, but then it doesn't really make a difference. Patch LGTM as is then. Thanks, Pedro Alves