From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 4obeCJuyHGA2EgAAWB0awg (envelope-from ) for ; Thu, 04 Feb 2021 21:51:07 -0500 Received: by simark.ca (Postfix, from userid 112) id 1273B1EFCB; Thu, 4 Feb 2021 21:51:07 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 398CE1E945 for ; Thu, 4 Feb 2021 21:51:06 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E25D9385E001; Fri, 5 Feb 2021 02:51:05 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E25D9385E001 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1612493465; bh=CQ8fMoSeOlO1wX1fXmV7C+en38/fpdnTlvta7UlCE8Y=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=bIRFBLeGcmhlfo/QXaCGgCZb2xgRWZznTIC3sfToeN/Pm16/woVqx7FMnGzwXEOQ7 2m9NHYiBXjdT7BpwvIJsv4waW7LAtqjUh8BaW/qMAalirKnMvXIY09iJkwyKsUzIgQ 7D90NUKRhJr5n0/Qn1cuVRsbGHkMLr6xGEwOAAIM= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 80726385E001 for ; Fri, 5 Feb 2021 02:51:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 80726385E001 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 1152ovG4004484 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 4 Feb 2021 21:51:02 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 1152ovG4004484 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 6731D1E945; Thu, 4 Feb 2021 21:50:57 -0500 (EST) Subject: Re: [PATCH v5 04/25] Unit testing for GDB-side remote memory tagging handling To: Luis Machado , gdb-patches@sourceware.org References: <20210127202112.2485702-1-luis.machado@linaro.org> <20210127202112.2485702-5-luis.machado@linaro.org> Message-ID: Date: Thu, 4 Feb 2021 21:50:57 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: <20210127202112.2485702-5-luis.machado@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Fri, 5 Feb 2021 02:50:57 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 2021-01-27 3:20 p.m., Luis Machado via Gdb-patches wrote: > Updated in v4: > > - Renamed functions based on reviews. > - Adjusted code to cope with bool return value. > - Restoring of global setting after unit testing. > > Updated in v2: > > - Adjusted unit tests to cope with new type field in the remote packets. > > -- > > Include some unit testing for the functions handling the new qMemTags and > QMemTags packets. > > gdb/ChangeLog: > > YYYY-MM-DD Luis Machado > > * remote: Include gdbsupport/selftest.h. > (test_memory_tagging_functions): New function. > (_initialize_remote): Register test_memory_tagging_functions. > --- > gdb/remote.c | 93 ++++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 93 insertions(+) > > diff --git a/gdb/remote.c b/gdb/remote.c > index bb3473b04c..22cae2a94f 100644 > --- a/gdb/remote.c > +++ b/gdb/remote.c > @@ -79,6 +79,7 @@ > #include > #include > #include "async-event.h" > +#include "gdbsupport/selftest.h" > > /* The remote target. */ > > @@ -14603,6 +14604,93 @@ remote_target::store_memtags (CORE_ADDR address, size_t len, > return packet_check_result (rs->buf.data ()) == PACKET_OK; > } > > +#if GDB_SELF_TEST > + > +namespace selftests { > + > +static void > +test_memory_tagging_functions () > +{ > + remote_target remote; > + > + struct packet_config *config > + = &remote_protocol_packets[PACKET_memory_tagging_feature]; > + > + scoped_restore restore_memtag_support_ > + = make_scoped_restore (&config->support, > + config->support); I think you could use the single-argument form here, if you want to create the scoped_restore object but not modify the value right away. Otherwise, LGTM. Simon