From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 78599 invoked by alias); 1 Jun 2018 20:48:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 78589 invoked by uid 89); 1 Jun 2018 20:48:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:777, touching X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 01 Jun 2018 20:48:52 +0000 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id AC8E130C73E7; Fri, 1 Jun 2018 20:48:51 +0000 (UTC) Received: from theo.uglyboxes.com (ovpn04.gateway.prod.ext.phx2.redhat.com [10.5.9.4]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 757911001F45; Fri, 1 Jun 2018 20:48:51 +0000 (UTC) Subject: Re: [RFA 4/6] Introduce accessors for psymtab high and low fields To: Tom Tromey , gdb-patches@sourceware.org References: <20180503223621.22544-1-tom@tromey.com> <20180503223621.22544-5-tom@tromey.com> From: Keith Seitz Message-ID: Date: Fri, 01 Jun 2018 20:48:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <20180503223621.22544-5-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2018-06/txt/msg00034.txt.bz2 On 05/03/2018 03:36 PM, Tom Tromey wrote: > I did this conversion by renaming the fields. I didn't rename the > fields back afterward, thinking that on the off chance that someone > has a patch touching this area, then a merge would helpfully break > their compile. /me likey ;-) Just a little request: > * dbxread.c (read_dbx_symtab, end_psymtab, read_ofile_symtab): > Update. > * mdebugread.c (parse_lines, parse_partial_symbols) > (psymtab_to_symtab_1): Update. These files still mention ->textlow and/or ->texthigh. Could you please adjust the comments accordingly? Otherwise, LGTM (but IANAM). [And for the record, this patch (and the next) will also show "regressions" because of patch #3.] Keith