Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tom@tromey.com>, Simon Marchi <simon.marchi@efficios.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: dwarf2/read.c: remove unused objfile parameters/variables
Date: Wed, 19 Feb 2020 21:05:00 -0000	[thread overview]
Message-ID: <dd83fe64-af73-5b2f-927a-7d2b893876e8@simark.ca> (raw)
In-Reply-To: <87mu9es35b.fsf@tromey.com>

On 2020-02-19 4:01 p.m., Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simon.marchi@efficios.com> writes:
> 
> Simon> This is a simple cleanup.  These functions used to use the objfile's
> Simon> obstack for allocation in the hash tables, but they don't anymore.
> Simon> Remove the unnecessary objfile parameters, which in turn allows removing
> Simon> some local variables.
> 
> Simon> gdb/ChangeLog:
> 
> Simon> 	* dwarf2/read.c (allocate_signatured_type_table,
> Simon> 	allocate_dwo_unit_table, allocate_type_unit_groups_table,
> Simon> 	allocate_dwo_file_hash_table, allocate_dwp_loaded_cutus_table):
> Simon> 	Remove objfile parameter, update all callers.
> 
> Looks good.  Thanks for doing this.
> 
> Tom
> 

Thanks, pushed.

Simon


      reply	other threads:[~2020-02-19 21:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-19 20:58 Simon Marchi
2020-02-19 21:01 ` Tom Tromey
2020-02-19 21:05   ` Simon Marchi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dd83fe64-af73-5b2f-927a-7d2b893876e8@simark.ca \
    --to=simark@simark.ca \
    --cc=gdb-patches@sourceware.org \
    --cc=simon.marchi@efficios.com \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox