From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 6qqyAvwVamonUDMAWB0awg (envelope-from ) for ; Wed, 29 Jul 2026 11:02:20 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=embecosm.com header.i=@embecosm.com header.a=rsa-sha256 header.s=google header.b=Nejia24r; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id EAAF21E09E; Wed, 29 Jul 2026 11:02:19 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E6D541E099 for ; Wed, 29 Jul 2026 11:02:18 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 127934BB58C6 for ; Wed, 29 Jul 2026 15:02:17 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 127934BB58C6 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=embecosm.com header.i=@embecosm.com header.a=rsa-sha256 header.s=google header.b=Nejia24r Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by sourceware.org (Postfix) with ESMTPS id 2959D4BB58B0 for ; Wed, 29 Jul 2026 15:01:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2959D4BB58B0 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embecosm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2959D4BB58B0 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::32f ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1785337312; cv=none; b=PphBS3+RVl6LkmnVo7WFGvZQKCXyoxJ59PcV49A0jsyyR8QZ66kpTjfelEnxEUbYLv/v0rYsp7b2GqOWVyKY2miF6+WtoGIiqY93iTdKCwXB8YeRPEU7M0tnEWklZh0Lyf82mf9wYm5RLViscfBeV4uaMRLazcUdL5C4laotCss= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1785337312; c=relaxed/simple; bh=+MGL9zOqrWdzrP1ppu2uNUCj3gFdBTMdD2DzofVBAUA=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=KMvvO7Q5HzWrwgU1jZDEzb72Y8BAkOPUPsE73QGIEWdguVF9f7QRjgY97Ae6iXOBA9xogpC9DqDJ9GsHIT/OsnD6Jdi8CT/pIlpXQ0JsCyUkL+pCx7u62qOxCpiJ1jDGNo92WdZL7NlPcXoW+pfahkff+HxJpltJISSWYDUqIos= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=embecosm.com header.i=@embecosm.com header.a=rsa-sha256 header.s=google header.b=Nejia24r DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2959D4BB58B0 Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-493f6de72faso7987825e9.0 for ; Wed, 29 Jul 2026 08:01:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; t=1785337311; x=1785942111; darn=sourceware.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=JrpqJbMCT8ch9VkOFXSCGSqtW1JCmv2pm3zpG9AQZGg=; b=Nejia24raWd9vRTywbAGUecKVoE2Yz6r9zbMdRF9KWpWj/IHiWFvgKJ9OMhTvcP+Mc 6fMurXTm+dQ5pz+19iRdgW5bxQHoYSt8WijN3n9+eqr32QrCzMx8zftB5QyDuVHwSdgD F0NCRmcalR/HJFrqWbC1s0NvCtK9eRQ+0IjflxDrAFVYjITftwo4PwrI9M+JAeW4Gesm D8leexVf60RJ+0DaeObQk+WpwM13qKd7AHUuoG6lgirSrSODwX3RxuKLEjvDt3+E7GYz WfJHt5JDTu1lMyzhNtcf8N84HPLa0KNEjNQom57SIRARq4I9OduqjQ1rloJC5+vvL/iK Fr6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785337311; x=1785942111; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=JrpqJbMCT8ch9VkOFXSCGSqtW1JCmv2pm3zpG9AQZGg=; b=hH11IcYmE/tGhliol060ESjmjNMZJJUcY2wDdTjH1dKl03oyN69PiOqoJVljoCOMOV BKNP1CLAJ4Lt2aSrsI2G5J7fxDXXkRYqr7pj1cAhWyhehGepIoTwme/5hUD2S9qQod7G JN78MnCt+4AgSrH9M7Ck3fuSimFE1dZh227yaOJOBZAyRCoJKCDjyDU+k3XM/SC6uQ2X 6/W/lAqYDOvQ+bLewobcpygqmGnyR8TjHdpUwhzHl22RSb/jUseBcV04d+8d67y8daO8 BTSXqOfxwv06sleHRIciW3BUgJ3URGMbAUG16XI+8wAJpxQpt5/QFXAAe5wU3k3s8h2O FM9Q== X-Gm-Message-State: AOJu0Yw+ll/e63a6cIm5KgTjB5Xa5UrtilooA/QM5Rh8Gami0kBuC1SI Lfm0saoxgzW/Fsb2kBZFKg8tBypy6kiEBUA7rDytbsWAAKKJRs+mztv+xR+zEEB45BTa4+L1voi 2Stev X-Gm-Gg: AR+sD13vGI99vdxYe+ZjUiY67xxHQ0Uw6/UcwKQpKmAXaPGSdXV4PZ1vB26GT7apAE9 8QcW41AObf1yX76P3xVL+cVT8ZZwXrArXLmkInvoe9Jv1UWFcbjIXbl7ErUh9ds9JMYBScWQzy4 472k696cYp47gn/kx/AU6GQmDg2Oo0KRKU0qnjtZ3bXjOHfues6x1clPYY+aYzQwaE7K9bvjnr4 X3aW9IWN4fJzItpudhgp/HSQhbj6uN2tD2jF9kS0bMHTPgmdWoNzIKbQpOYymSLckc+nHalb5iH ahXFQaAeMHkO4oTLQVJtM25HPRSNDzwpvMMkgLVhZE9jB4YrjbS3QJxtJc9DMHXzaJpf4fnovHb zanzPyYbKoBMKZDPJrgM54dznO6+PgyUwHgCaOWPAoviRjZpwbq7gJMYkiI07TEH/8Zz+FVslbP AU9QdUX29wWRGJ2DbpT9QOa3TUlkIWbQ2OoSDOXzM5CBoQfEY/LASE1acxfAVtE4/W+zcThGsAL 0tK X-Received: by 2002:a05:600c:c4ab:b0:493:ecf5:89fd with SMTP id 5b1f17b1804b1-497fd3191fbmr28595665e9.17.1785337310840; Wed, 29 Jul 2026 08:01:50 -0700 (PDT) Received: from [192.168.0.192] ([212.69.42.53]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49764d72d9asm66135645e9.3.2026.07.29.08.01.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Jul 2026 08:01:49 -0700 (PDT) Message-ID: Date: Wed, 29 Jul 2026 16:01:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 0/1] gdb: Add python support for demangling register unwind values To: gdb-patches@sourceware.org Cc: aburgess@redhat.com References: <20260520131607.32885-1-craig.blackmore@embecosm.com> <20260608120437.566738-1-craig.blackmore@embecosm.com> Content-Language: en-US From: Craig Blackmore Autocrypt: addr=craig.blackmore@embecosm.com; keydata= xsBNBFdIF8oBCACwrsvc6YVfzJRT+ZoBfL9jEb8ITwNahDxCGSG6sIWrJ9UFeTwE8fnNhMpz RyFRm0OXruS5k/8YHJHrxKxFY9cgZ3CWNftXEjRqURUWGtN/ESiw0J7nVfhSGQTo3LBzpXZ1 0JHk4ZHKDJKYa+fhybCHOs19BfP3HydHoTlc5QTKMfom0X/xo7WDdwUYeZsjD9u8IzHk7gNw 05Abk1vqni+J7Fghjp4RI8W3IsjpKOfV3f02OyO/MTSraXNyejO4JRl0A8b3q1Lq+G6Z7o5n LVief5JpkRyzWQSawTIBKmRZa9EzAKZXd6IJdY/sZt7pTir5EP7MHq4a+AtKfKuDkrDDABEB AAHNLkNyYWlnIEJsYWNrbW9yZSA8Y3JhaWcuYmxhY2ttb3JlQGVtYmVjb3NtLmNvbT7CwHgE EwECACIFAldIF8oCGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGEeRQLLl5WtydMH /1nYd9jmOBaF8w5gGgjF5eOO5b/cdUegmO///VYj/5R7iF/zbB6KgF0Obo5h2gG9AIfsZG+T ybuTx7oU1DZYEIndw+YP9c9Yi5de5UzEHwbJiV57W0n+MP0Widgw7p6XJmUQ1XbHxdcWp7nY EJa8ASKLuuIhO8JFUXbQ8BcUiWbsA/JxgCzeid8iixGrzPWj6iFzoK2mX4GqP+24pXSDUamM TXmSQd2taYEsyUdJNiEkUC51ncRcMuThjdtfn6Ok+7lHjh3Zz8q0keJz5pnIp4EXdkAgKSjq U42PMrd3v1HoIFINTtr5F23OdkxoQzysu4GMO4pkw5pwz95Uckr08ojOwE0EV0gXygEIAKv/ luYHmCG/qefgzdbnegwMdG5753NJ+zGxFltFX6aaOPZ8go9Omf6zwjybUKv6Qx6AlDanwCl3 ewVQs+h9iW8uaQBRgeDmwAGMG/doBiFqs7X0jBf23exMiJezXlKb2ZlKzMAbzJ87408AzRaV sZdwEpXHVi2mRPoXtMrqL5iQEyG5hdx2ySj5164DIgVOs/ypFiaiFaDPkIcAQTzJrxsbt6pf iI9kT93DO9nRKVV0pPWztV8P5gKM8HY2rS0wQcfrqAU6T89Aa0VFw92J+w5d2spF8MUNPsvR NLm9ooCF3YME9STYHXrNH1U9fJUWpIC+b49UoWSWRD9nwl2h2i8AEQEAAcLAXwQYAQIACQUC V0gXygIbDAAKCRBhHkUCy5eVreLbB/sHPs1xu78uNV8O4UPTX7D5zBBS3nsrbDr+8stmXRap xbvo6kqKzIMAXuO3bYB/NyJ/tFzuFr9Tjd/2g56D2186bp01/kgxJ9CEl/m2T3lG3DlxIoLg pCExzTLTb8zH/7/6mdeJ17cdnrK+2QAKYctReVPAC67cq5KmUyU3bv5e1JzhV4ezz/i/O+Jv el112ZEsa54ya9KZOUHbgAR6hLnRWIa+8yQTtXqYRc3LxLRfS80Wn0Err1YvqFYzJsQMC8ND xAeEuqQ1gfk1b0jmv7tYljNqsHqzGVbuWz6hyzyLv5GjcdSDKpbw/797gRKQSY8Gty5ynfUH O4kKyuZPrE8P In-Reply-To: <20260608120437.566738-1-craig.blackmore@embecosm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org I have just been looking at the proposed release schedule and I wondered, if no further changes are needed, whether it would be possible to include this patch before branching for GDB 18? Thanks, Craig On 08/06/2026 13:04, Craig Blackmore wrote: > This version addresses review comments from Andrew Burgess and Eli > Zaretskii from: > > https://sourceware.org/pipermail/gdb-patches/2026-May/227549.html > https://sourceware.org/pipermail/gdb-patches/2026-May/227536.html > > Changes since v4: > > * Change `demangle` method to `read`. > > * Refer to transforming instead of demangling in the code and > documentation. > > * Fix long line in python.texi. > > * Rebase. > > Changes since v3: > > * Change lval_type to lvalue type in NEWS and python documentation. > > * Remove line about future support for multiple transformers or > different loci from python documentation. > > Changes since v2: > > * Removed RFC from subject. > > * Changed `gdb.unwinder.UnwindRegisterValueDemangler` to > `gdb.unwinder.UnwindRegisterValueTransformer` so that other transform > methods could be supported in future rather than being restricted to > demangling only. Demangling is now done by calling the `demangle` > method instead of `__call__`. > > * Made transformer registration similar to unwinder registration to > allow future support for registering multiple transformers and > registering to other loci. > > * Call `invalidate_cached_frames` after registering a transformer. > > * Made `gdb.unwinder.UnwindRegisterValueTransformer.name` read-only > and added type check. > > * Pass `gdb.Frame` to demanglers instead of `frame_type`. > > * Added global `python_transformer_enabled` to `py-unwind.c` which > python sets when any transformer is registered. This allows us to > skip entering the python environment when demangling and no > transformers are registered. > > * Replaced `gdb.Value.is_lval_register` and `gdb.Value.is_lval_memory` > read-only boolean attributes with `gdb.Value.lval_type` read-only > type attribute. > > * Removed redundant `return` after call to `error`. > > * Replaced `NULL` with `nullptr`. > > * Added tests for invalid registration and invalid return value from > demangler. > > * Updated tests and documentation to match the above changes. > > * Rebased. > > Craig Blackmore (1): > gdb: Add python support for transforming register unwind values > > gdb/NEWS | 17 ++ > gdb/doc/python.texi | 96 ++++++++++ > gdb/extension-priv.h | 8 + > gdb/extension.c | 35 ++++ > gdb/extension.h | 6 + > gdb/frame.c | 10 ++ > gdb/guile/guile.c | 2 + > gdb/python/lib/gdb/__init__.py | 21 +++ > gdb/python/lib/gdb/unwinder.py | 93 +++++++++- > gdb/python/py-registers.c | 2 +- > gdb/python/py-unwind.c | 169 ++++++++++++++++++ > gdb/python/py-value.c | 21 +++ > gdb/python/python-internal.h | 3 + > gdb/python/python.c | 4 +- > .../gdb.python/py-unwind-transformer-error.py | 33 ++++ > .../gdb.python/py-unwind-transformer.c | 80 +++++++++ > .../gdb.python/py-unwind-transformer.exp | 115 ++++++++++++ > .../gdb.python/py-unwind-transformer.py | 48 +++++ > gdb/testsuite/gdb.python/py-value.exp | 8 + > 19 files changed, 768 insertions(+), 3 deletions(-) > create mode 100644 gdb/testsuite/gdb.python/py-unwind-transformer-error.py > create mode 100644 gdb/testsuite/gdb.python/py-unwind-transformer.c > create mode 100644 gdb/testsuite/gdb.python/py-unwind-transformer.exp > create mode 100644 gdb/testsuite/gdb.python/py-unwind-transformer.py >