From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id Bj8LN8EqXmC/SgAAWB0awg (envelope-from ) for ; Fri, 26 Mar 2021 14:41:05 -0400 Received: by simark.ca (Postfix, from userid 112) id D2FB01EF7C; Fri, 26 Mar 2021 14:41:05 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 804331E789 for ; Fri, 26 Mar 2021 14:41:04 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BC4BA3858C27; Fri, 26 Mar 2021 18:41:03 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BC4BA3858C27 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1616784063; bh=+ZdfWp+YBdG7QUWBHLILfI8ielfVMXCOy4ks0gho2NA=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=eYfwMCt+atIi02m9NaHd3LOBJ4Uu6t2HzspRA10bOap/FRHADx8+02Kbsh3yerlLW xoORUbn9h4WBn65uCFdOu661aH5mplYrI4q8AvQiGIWApaCw74adZXpcHtWC4+Q9L9 gIpoWtfVSjTd+lLTJBmc70Uei2F7/th+qec6iyqM= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id D433F3858C27 for ; Fri, 26 Mar 2021 18:41:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D433F3858C27 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 12QIdrrE008937 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 26 Mar 2021 14:39:58 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 12QIdrrE008937 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 19B581E789; Fri, 26 Mar 2021 14:39:53 -0400 (EDT) Subject: Re: [PATCH] gdb-add-index.sh: Remove use of non posix 'local' To: Lancelot SIX , gdb-patches@sourceware.org References: <20210326171454.2795-1-lsix@lancelotsix.com> Message-ID: Date: Fri, 26 Mar 2021 14:39:52 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210326171454.2795-1-lsix@lancelotsix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Fri, 26 Mar 2021 18:39:53 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 2021-03-26 1:14 p.m., Lancelot SIX via Gdb-patches wrote: > While working on gdb-add-index.sh, it appeared that it uses the non > POSIX 'local' keyword. Instead of using local to allow variable > shadowing, I rename the local one to avoid name conflicts altogether. Thanks, this is OK. You can also mention in the commit message that it gets rid of this shellcheck warning: In gdb-add-index.sh line 63: local file="$1" ^--------^ SC2039: In POSIX sh, 'local' is undefined. Simon