From: Pedro Alves <palves@redhat.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/4] Make "checkpoint" not rely on inferior_ptid
Date: Tue, 05 Mar 2019 19:46:00 -0000 [thread overview]
Message-ID: <dd1e634b-c652-353e-e3d1-ef147d5139ab@redhat.com> (raw)
In-Reply-To: <87lg1truav.fsf@tromey.com>
On 03/05/2019 07:32 PM, Tom Tromey wrote:
>>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
>
> Pedro> In the
> Pedro> multi-target branch, I'm forcing inferior_ptid to null_ptid early in
> Pedro> infrun event handling to make sure we inadvertently rely on the
> Pedro> current thread/target when we shouldn't, and that caught some bad
> Pedro> or unnecessary assumptions throughout.
>
> This read a bit strangely to me. Maybe instead write "to make sure we
> don't inadvertently rely on the current thread/target,..."?
>
Oh, yes, I missed typing the "don't". Thanks for spotting that.
> The patch itself seemed fine to me. Big +1 to reducing the impact of
> globals.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2019-03-05 19:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-05 18:43 [PATCH 0/4] " Pedro Alves
2019-03-05 18:43 ` [PATCH 3/4] linux-fork.c: rewrite inf_has_multiple_threads Pedro Alves
2019-03-05 18:43 ` [PATCH 2/4] C++ify fork_info, use std::list Pedro Alves
2019-03-05 18:43 ` [PATCH 1/4] Make "checkpoint" not rely on inferior_ptid Pedro Alves
2019-03-05 19:32 ` Tom Tromey
2019-03-05 19:46 ` Pedro Alves [this message]
2019-03-05 18:43 ` [PATCH 4/4] Eliminate fork_info::clobber_regs Pedro Alves
2019-03-05 19:46 ` [PATCH 0/4] Make "checkpoint" not rely on inferior_ptid Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd1e634b-c652-353e-e3d1-ef147d5139ab@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox