From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id e+PdNsffRWIvDwAAWB0awg (envelope-from ) for ; Thu, 31 Mar 2022 13:07:19 -0400 Received: by simark.ca (Postfix, from userid 112) id CB2511F163; Thu, 31 Mar 2022 13:07:19 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 5EA4E1E150 for ; Thu, 31 Mar 2022 13:07:19 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id F1D8F3839816 for ; Thu, 31 Mar 2022 17:07:18 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org F1D8F3839816 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1648746439; bh=URbGqh9XZj1I5djHUdPW8Drvy38c4/o1shw8DCFQWGA=; h=Date:Subject:To:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=aiDV3HHuwiictfw2HbP7zC3pIqFdXWFxXYy7qDCkffAd9xHGIN0wstfmZfsdEnIX9 SrKUDUT6s5qDEAeyL2ksF3OX/DzaXdzDBZA/y9Lpt1vSK4HMJqdifWYYWlpVxdVzLF b51eGqu+T4piHkvxsPACPAP7b+5BB0uOO+TmbU3c= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 8BCAC385741C for ; Thu, 31 Mar 2022 17:07:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8BCAC385741C Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 22VH6rsN012500 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 31 Mar 2022 13:06:58 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 22VH6rsN012500 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 3A7981E150; Thu, 31 Mar 2022 13:06:53 -0400 (EDT) Message-ID: Date: Thu, 31 Mar 2022 13:06:52 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH 2/8] gdb/linux-nat: remove check based on current_inferior in linux_handle_extended_wait Content-Language: en-US To: Pedro Alves , gdb-patches@sourceware.org References: <20220117162742.524350-1-simon.marchi@polymtl.ca> <20220117162742.524350-3-simon.marchi@polymtl.ca> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 31 Mar 2022 17:06:53 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 2022-03-31 12:12, Pedro Alves wrote: > On 2022-01-17 16:27, Simon Marchi via Gdb-patches wrote: > >> diff --git a/gdb/linux-nat.c b/gdb/linux-nat.c >> index b926fb5eba9e..7de4da03a34f 100644 >> --- a/gdb/linux-nat.c >> +++ b/gdb/linux-nat.c >> @@ -2096,20 +2096,11 @@ linux_handle_extended_wait (struct lwp_info *lp, int status) >> >> if (event == PTRACE_EVENT_VFORK_DONE) >> { >> - if (current_inferior ()->waiting_for_vfork_done) >> - { >> - linux_nat_debug_printf >> - ("Got expected PTRACE_EVENT_VFORK_DONE from LWP %ld: stopping", >> - lp->ptid.lwp ()); >> - >> - ourstatus->set_vfork_done (); >> - return 0; >> - } >> - >> linux_nat_debug_printf >> - ("Got PTRACE_EVENT_VFORK_DONE from LWP %ld: ignoring", lp->ptid.lwp ()); >> - >> - return 1; >> + ("Got expected PTRACE_EVENT_VFORK_DONE from LWP %ld", >> + lp->ptid.lwp ()); > > Please drop the "expected" from the log, as we're not checking > waiting_for_vfork_done anymore. Done. > >> + /* Child */ >> + _exit(12); > > Space before parens. Done. > Otherwise OK. Thanks. Thanks, I'll push this patch on its own, since it's self-contained. Simon