From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id eWlCA8TLeGibygQAWB0awg (envelope-from ) for ; Thu, 17 Jul 2025 06:09:08 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=nUTfTwmM; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=Lyk8LQ/h; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=nUTfTwmM; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=Lyk8LQ/h; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id E685D1E11C; Thu, 17 Jul 2025 06:09:07 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-9.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL, RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 0BD071E0C2 for ; Thu, 17 Jul 2025 06:09:07 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6AF21385DC02 for ; Thu, 17 Jul 2025 10:09:06 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6AF21385DC02 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=nUTfTwmM; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=Lyk8LQ/h; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=nUTfTwmM; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=Lyk8LQ/h Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id 669DC385C6DA for ; Thu, 17 Jul 2025 10:07:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 669DC385C6DA Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 669DC385C6DA Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1752746874; cv=none; b=rd7ig4x/Jhz0h0TSHtYXhQIsvNs9Toztmry6HybvR45N5sONETy5YXZ/f4fftXTSYk7Wrr3Za6vNwp28JdD+fkYErRIs0v2+mWHS7zF5Z60WsH1HYF3MMbFMdjuakcy5ymZ1PjSAndBMhLXA/3/8ZW/2QgWhqrd06Yd6ufyfg6c= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1752746874; c=relaxed/simple; bh=/m27F1kZmVSNMDYhPR+vCIBdMCPFZ2mCeOayuO9I5ww=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=A/lEhVrbcFHqhWO0xOId5QseZljpPJkisRWdOYuscG8UC343b+UWMDVqGPPRhrWRAygsFQIDl949gPqJDcjJ5sWJMYcYiFzsCfxR3B5/Wo57+Hr36OnOBCH4moiwtDINh/k8md8scCzKj+HSazP7q+dFeZvpX0WrxFZAg+Wu++A= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 669DC385C6DA Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 5D2DA1F7E0; Thu, 17 Jul 2025 10:07:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1752746873; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=e9ot3Cc7wJRpUJ9gN+mYneCq0O96PFXEvzx1ZFOT6jo=; b=nUTfTwmMNGNk3ixF4ld+CnxMzKO4yZmnAX7iGlX5MMuafhsm3eu3ncoo7AAcY7GYIo21ux BZlKde76osbuPnci0SFP3DFbIO6FqeBQDE+/49vQ98GS6fZVTykg46ZS2jYjdkWQiNZlnW yw3QmtUDr/eLnDfsWw4DgDQlNnQJuz4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1752746873; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=e9ot3Cc7wJRpUJ9gN+mYneCq0O96PFXEvzx1ZFOT6jo=; b=Lyk8LQ/hdrd3R5bBlHTIdT62Kcdu6rmpDRtXrPlA/SA9sqh9FXhbeWcnroOLeK82GRGDA5 VWZQ4qGPnvMMRECw== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1752746873; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=e9ot3Cc7wJRpUJ9gN+mYneCq0O96PFXEvzx1ZFOT6jo=; b=nUTfTwmMNGNk3ixF4ld+CnxMzKO4yZmnAX7iGlX5MMuafhsm3eu3ncoo7AAcY7GYIo21ux BZlKde76osbuPnci0SFP3DFbIO6FqeBQDE+/49vQ98GS6fZVTykg46ZS2jYjdkWQiNZlnW yw3QmtUDr/eLnDfsWw4DgDQlNnQJuz4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1752746873; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=e9ot3Cc7wJRpUJ9gN+mYneCq0O96PFXEvzx1ZFOT6jo=; b=Lyk8LQ/hdrd3R5bBlHTIdT62Kcdu6rmpDRtXrPlA/SA9sqh9FXhbeWcnroOLeK82GRGDA5 VWZQ4qGPnvMMRECw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 4949F13A6C; Thu, 17 Jul 2025 10:07:53 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id IcirEHnLeGhLYwAAD6G6ig (envelope-from ); Thu, 17 Jul 2025 10:07:53 +0000 Message-ID: Date: Thu, 17 Jul 2025 12:07:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] [gdb/cli] Improve the pagination prompt To: Eli Zaretskii Cc: gdb-patches@sourceware.org References: <20250715193747.30735-1-tdevries@suse.de> <86zfd4ida8.fsf@gnu.org> Content-Language: en-US From: Tom de Vries In-Reply-To: <86zfd4ida8.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-0.998]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[gnu.org:email, suse.de:mid, suse.de:email, imap1.dmz-prg2.suse.org:helo] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 7/16/25 13:30, Eli Zaretskii wrote: >> From: Tom de Vries >> Date: Tue, 15 Jul 2025 21:37:47 +0200 >> >> Currently the pagination prompt is: >> ... >> --Type for more, q to quit, c to continue without paging-- >> ... >> >> PR cli/33149 points out an inconsistency. >> >> While typing works as advertised, pressing q or c doesn't have any >> other effect than echoing the character to screen. An additional is >> needed. >> >> This is a regression since commit eb6af80922a ("Add "continue" response to >> pager"), which changed: >> ... >> ---Type to continue, or q to quit--- >> ... >> into: >> ... >> --Type for more, q to quit, c to continue without paging-- >> ... >> >> Fix this by using the slightly longer (69 instead of 64 chars): >> ... >> --Type (more), q (quit), or c (continue, no paging)-- >> ... > > Thanks, but why is described as "more" whereas c as > "continue, no paging" instead of "more, no paging"? > Hi Eli, thanks for the review. So you're proposing the following: ... --Type (more), q (quit), or c (more, no paging)-- ... I think q is described as "quit" and c as "continue, no paging" because of the first letter matching, and that matching is not there for "c (more, no paging)". I also considered: ... --Type (continue), q (quit), or c (continue, no paging)-- ... but it's longer and no so clear either. Personally I like: ... --Type (more), q (quit), or c (cat)-- ... which is short but requires knowledge of what's the difference of using more vs cat. Anyway, I've submitted a v2 but left this unchanged ( https://sourceware.org/pipermail/gdb-patches/2025-July/219287.html ). >> >> Also update the documentation to clarify the same issue. >> >> In the testsuite, update the pagination_prompt variable and use it in more >> test-cases. >> >> In some test-cases, matching the pagination prompt was split up to address a >> matching race but that's no longer necessary, thanks to commit c3f814a1433 >> ("Fix paginate-*.exp races"). >> >> Tested on aarch64-linux. >> >> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=33149 >> --- a/gdb/doc/gdb.texinfo >> +++ b/gdb/doc/gdb.texinfo >> @@ -27921,9 +27921,9 @@ Certain commands to @value{GDBN} may produce large amounts of >> information output to the screen. To help you read all of it, >> @value{GDBN} pauses and asks you for input at the end of each page of >> output. Type @key{RET} when you want to see one more page of output, >> -@kbd{q} to discard the remaining output, or @kbd{c} to continue >> -without paging for the rest of the current command. Also, the screen >> -width setting determines when to wrap lines of output. Depending on >> +@kbd{q} @key{RET} to discard the remaining output, or @kbd{c} @key{RET} to > > The markup here is incorrect, it should be @kbd{q @key{RET}}, i.e. the > entire user input should be inside @kbd. > > Please also correct "Type @key{RET}" to say "Type @kbd{@key{RET}}" > instead, for the same reason. > > The principles are: @key{FOO} just describes the key labeled "FOO"; > anything the user should type should be in @kbd. > Fixed in the v2. > Also, no NEWS entry for this? > Also added in the v2. Thanks, - Tom > Reviewed-By: Eli Zaretskii