From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 45908 invoked by alias); 6 Dec 2016 19:08:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 45379 invoked by uid 89); 6 Dec 2016 19:08:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy=Hx-languages-length:1467, H*f:sk:1481040, H*MI:sk:2c0de80, H*f:sk:2c0de80 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 06 Dec 2016 19:08:30 +0000 Received: from svr-orw-mbx-03.mgc.mentorg.com ([147.34.90.203]) by relay1.mentorg.com with esmtp id 1cEL6K-0005au-Qm from Luis_Gustavo@mentor.com ; Tue, 06 Dec 2016 11:08:28 -0800 Received: from [172.30.7.171] (147.34.91.1) by svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Tue, 6 Dec 2016 11:08:25 -0800 Reply-To: Luis Machado Subject: Re: [PATCH, obvious?] Fix incorrect reference to source files References: <1481040941-21237-1-git-send-email-lgustavo@codesourcery.com> <2c0de800bcae514b2a8c27c6f47271da@polymtl.ca> To: Simon Marchi CC: From: Luis Machado Message-ID: Date: Tue, 06 Dec 2016 19:08:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <2c0de800bcae514b2a8c27c6f47271da@polymtl.ca> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: svr-orw-mbx-02.mgc.mentorg.com (147.34.90.202) To svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) X-IsSubscribed: yes X-SW-Source: 2016-12/txt/msg00174.txt.bz2 On 12/06/2016 12:54 PM, Simon Marchi wrote: > On 2016-12-06 11:15, Luis Machado wrote: >> These auto-generated register source files have been renamed back in >> 2010. >> >> It took me a while to find these due to the mismatch. >> >> gdb/gdbserver/ChangeLog: >> >> 2016-12-06 Luis Machado >> >> * win32-i386-low.c: Fix incorrect reference to a couple source files. >> --- >> gdb/gdbserver/win32-i386-low.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/gdb/gdbserver/win32-i386-low.c >> b/gdb/gdbserver/win32-i386-low.c >> index 5daa863..edae9bb 100644 >> --- a/gdb/gdbserver/win32-i386-low.c >> +++ b/gdb/gdbserver/win32-i386-low.c >> @@ -29,11 +29,11 @@ >> #define FLAG_TRACE_BIT 0x100 >> >> #ifdef __x86_64__ >> -/* Defined in auto-generated file reg-amd64.c. */ >> +/* Defined in auto-generated file amd64.c. */ >> void init_registers_amd64 (void); >> extern const struct target_desc *tdesc_amd64; >> #else >> -/* Defined in auto-generated file reg-i386.c. */ >> +/* Defined in auto-generated file i386.c. */ >> void init_registers_i386 (void); >> extern const struct target_desc *tdesc_i386; >> #endif > > You could also put the full path to the file, either > features/i386/amd64.c or gdb/features/i386/amd64.c, since it's not > obvious where those files are located (although a "find" finds it quickly). > Good one. That sounds better.