From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 103AD385B835 for ; Mon, 30 Mar 2020 15:50:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 103AD385B835 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 9E5801E581; Mon, 30 Mar 2020 11:50:39 -0400 (EDT) Subject: Re: [PATCH 14/20] Change how accessibility is handled in dwarf2/read.c To: Tom Tromey , gdb-patches@sourceware.org References: <20200328192208.11324-1-tom@tromey.com> <20200328192208.11324-15-tom@tromey.com> From: Simon Marchi Message-ID: Date: Mon, 30 Mar 2020 11:50:39 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200328192208.11324-15-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US-large Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-25.0 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP, URIBL_CSS, URIBL_CSS_A autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Mar 2020 15:50:41 -0000 On 2020-03-28 3:22 p.m., Tom Tromey wrote: > dwarf2/read.c uses dwarf2_default_access_attribute to check for the > default access attribute. This patch simplifies the code by moving > more of the access processing into this function, changing its name to > reflect the difference. This also ensures that the attribute's form > is respected, by changing to code to use the constant_value method. > > gdb/ChangeLog > 2020-03-28 Tom Tromey > > * dwarf2/read.c (dwarf2_access_attribute): Rename from > dwarf2_default_access_attribute. Look up attribute. > (dwarf2_add_field, dwarf2_add_type_defn, dwarf2_add_member_fn): > Update. > --- > gdb/ChangeLog | 7 +++++++ > gdb/dwarf2/read.c | 38 +++++++++++++++++--------------------- > 2 files changed, 24 insertions(+), 21 deletions(-) > > diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c > index d3897ac2198..efa59fcab4d 100644 > --- a/gdb/dwarf2/read.c > +++ b/gdb/dwarf2/read.c > @@ -14001,12 +14001,24 @@ producer_is_codewarrior (struct dwarf2_cu *cu) > return cu->producer_is_codewarrior; > } > > -/* Return the default accessibility type if it is not overridden by > +/* Return the accessibility type if it is not overridden by > DW_AT_accessibility. */ Maybe I don't understand correctly, but I think the "if it is not overridden by DW_AT_accessibility" part of the comment is no longer true. It's more, return the value of DW_AT_accessibility, or if it's not present, the default accessibility value. Otherwise, LGTM. Simon