From: Pedro Alves <palves@redhat.com>
To: Pedro Franco de Carvalho <pedromfc@linux.ibm.com>,
gdb-patches@sourceware.org
Cc: uweigand@de.ibm.com, edjunior@gmail.com
Subject: Re: [PATCH v5 00/12] GDB support for more powerpc registers on linux
Date: Tue, 23 Oct 2018 15:37:00 -0000 [thread overview]
Message-ID: <dc88e21d-6605-6f29-3660-e619fd0ce9eb@redhat.com> (raw)
In-Reply-To: <20181022223242.7858-1-pedromfc@linux.ibm.com>
On 10/22/2018 11:32 PM, Pedro Franco de Carvalho wrote:
> This is V5 of: https://sourceware.org/ml/gdb-patches/2018-08/msg00381.html
>
AFAICT, this mainly refreshes the patch set, and applies some polish,
but doesn't address the previously discussed issues, right?
TBC, I don't want to block this at all, I think it's looking good.
Just want to understand if there's a plan, and if so, what is it.
I.e., what is the conclusion wrt to the differences in one of the note
sections generated by the kernel for a core file and the one generated
by GDB? Was that resolved? Will it be?
As for the EBB/PMU patch, about gdbserver writing all registers in one go
before resuming the inferior, and the error would not being detected at the
time the user tries to write them, did you try making gdbserver flush
the regcache after handling 'G' and 'P' packets? From the previous
discussion, it sounded like that would work?
> Changes from V4:
>
> * Explained further limitations of unavailable registers with respect
> to 'G' packets in the commit message of "[PowerPC] Add support for
> EBB and PMU registers".
>
> * Changed linux_collect_regset_section_cb to use std::vector<gdb_byte>
> instead of std::vector<char> in the first patch ("Zero-initialize
> linux note sections").
>
> * Defined ppc_linux_collect_core_cpgrregset in ppc-linux-tdep.c and
> changed ppc_linux_iterate_over_regset_sections to call it when
> generating core files, in order to fill in the checkpointed NIP and
> MSR slots in the core file with reasonable values (TFHAR and the
> regular MSR), in "[PowerPC] Add support for HTM registers".
>
> * Removed ppc_linux_regset_available_p, removed call to store_regset
> with regsets that can be unavailable when store_registers is called
> with -1, added comment explaining why.
>
> * Changed fetch_regset/store_regset in ppc-linux-nat.c to call the
> supply/collect function pointers from the regset instead of
> regcache_supply/collect_regset.
>
> * Reordered some of the regmap/regset definitions in ppc-linux-tdep.c
> for consistency with the existing definitions.
>
> * Added various comments for global variables, functions and to the
> new test cases.
>
> Edjunior Barbosa Machado (4):
> [PowerPC] Add support for PPR and DSCR
> [PowerPC] Add support for TAR
> [PowerPC] Add support for EBB and PMU registers
> [PowerPC] Add support for HTM registers
>
> Pedro Franco de Carvalho (8):
> Zero-initialize linux note sections
> [PowerPC] Don't zero-initialize vector register buffers
> Add decfloat registers to float reggroup
> [PowerPC] Remove rs6000_pseudo_register_reggroup_p
> [PowerPC] Fix two if statements in gdb/ppc-linux-nat.c
> [PowerPC] Fix indentation in arch/ppc-linux-common.c
> [PowerPC] Refactor have_ initializers in rs6000-tdep.c
> [PowerPC] Reject tdescs with VSX and no FPU or Altivec
>
> gdb/NEWS | 4 +
> gdb/arch/ppc-linux-common.c | 30 +-
> gdb/arch/ppc-linux-common.h | 20 +
> gdb/arch/ppc-linux-tdesc.h | 6 +
> gdb/doc/gdb.texinfo | 60 ++
> gdb/features/Makefile | 11 +
> gdb/features/rs6000/power-dscr.xml | 12 +
> gdb/features/rs6000/power-ebb.xml | 14 +
> gdb/features/rs6000/power-htm-altivec.xml | 58 ++
> gdb/features/rs6000/power-htm-core.xml | 48 ++
> gdb/features/rs6000/power-htm-dscr.xml | 12 +
> gdb/features/rs6000/power-htm-fpu.xml | 45 ++
> gdb/features/rs6000/power-htm-ppr.xml | 12 +
> gdb/features/rs6000/power-htm-spr.xml | 14 +
> gdb/features/rs6000/power-htm-tar.xml | 12 +
> gdb/features/rs6000/power-htm-vsx.xml | 43 ++
> gdb/features/rs6000/power-linux-pmu.xml | 17 +
> gdb/features/rs6000/power-ppr.xml | 12 +
> gdb/features/rs6000/power-tar.xml | 12 +
> gdb/features/rs6000/power64-htm-core.xml | 48 ++
> .../rs6000/powerpc-isa205-ppr-dscr-vsx32l.c | 200 +++++
> .../rs6000/powerpc-isa205-ppr-dscr-vsx32l.xml | 18 +
> .../rs6000/powerpc-isa205-ppr-dscr-vsx64l.c | 200 +++++
> .../rs6000/powerpc-isa205-ppr-dscr-vsx64l.xml | 18 +
> gdb/features/rs6000/powerpc-isa207-htm-vsx32l.c | 396 ++++++++++
> gdb/features/rs6000/powerpc-isa207-htm-vsx32l.xml | 29 +
> gdb/features/rs6000/powerpc-isa207-htm-vsx64l.c | 396 ++++++++++
> gdb/features/rs6000/powerpc-isa207-htm-vsx64l.xml | 29 +
> gdb/features/rs6000/powerpc-isa207-vsx32l.c | 215 ++++++
> gdb/features/rs6000/powerpc-isa207-vsx32l.xml | 21 +
> gdb/features/rs6000/powerpc-isa207-vsx64l.c | 215 ++++++
> gdb/features/rs6000/powerpc-isa207-vsx64l.xml | 21 +
> gdb/gdbserver/configure.srv | 28 +-
> gdb/gdbserver/linux-ppc-ipa.c | 18 +
> gdb/gdbserver/linux-ppc-low.c | 428 ++++++++++-
> gdb/gdbserver/linux-ppc-tdesc-init.h | 21 +
> gdb/linux-tdep.c | 14 +-
> gdb/nat/ppc-linux.h | 80 ++
> gdb/ppc-linux-nat.c | 440 ++++++++++-
> gdb/ppc-linux-tdep.c | 606 ++++++++++++++-
> gdb/ppc-linux-tdep.h | 21 +
> gdb/ppc-tdep.h | 93 +++
> .../rs6000/powerpc-isa205-ppr-dscr-vsx32l.dat | 146 ++++
> .../rs6000/powerpc-isa205-ppr-dscr-vsx64l.dat | 146 ++++
> .../rs6000/powerpc-isa207-htm-vsx32l.dat | 296 ++++++++
> .../rs6000/powerpc-isa207-htm-vsx64l.dat | 296 ++++++++
> gdb/regformats/rs6000/powerpc-isa207-vsx32l.dat | 155 ++++
> gdb/regformats/rs6000/powerpc-isa207-vsx64l.dat | 155 ++++
> gdb/reggroups.c | 4 +-
> gdb/rs6000-tdep.c | 813 ++++++++++++++++++---
> gdb/testsuite/gdb.arch/powerpc-htm-regs.c | 39 +
> gdb/testsuite/gdb.arch/powerpc-htm-regs.exp | 328 +++++++++
> gdb/testsuite/gdb.arch/powerpc-ppr-dscr.c | 34 +
> gdb/testsuite/gdb.arch/powerpc-ppr-dscr.exp | 120 +++
> gdb/testsuite/gdb.arch/powerpc-tar.c | 33 +
> gdb/testsuite/gdb.arch/powerpc-tar.exp | 122 ++++
> 56 files changed, 6528 insertions(+), 156 deletions(-)
> create mode 100644 gdb/features/rs6000/power-dscr.xml
> create mode 100644 gdb/features/rs6000/power-ebb.xml
> create mode 100644 gdb/features/rs6000/power-htm-altivec.xml
> create mode 100644 gdb/features/rs6000/power-htm-core.xml
> create mode 100644 gdb/features/rs6000/power-htm-dscr.xml
> create mode 100644 gdb/features/rs6000/power-htm-fpu.xml
> create mode 100644 gdb/features/rs6000/power-htm-ppr.xml
> create mode 100644 gdb/features/rs6000/power-htm-spr.xml
> create mode 100644 gdb/features/rs6000/power-htm-tar.xml
> create mode 100644 gdb/features/rs6000/power-htm-vsx.xml
> create mode 100644 gdb/features/rs6000/power-linux-pmu.xml
> create mode 100644 gdb/features/rs6000/power-ppr.xml
> create mode 100644 gdb/features/rs6000/power-tar.xml
> create mode 100644 gdb/features/rs6000/power64-htm-core.xml
> create mode 100644 gdb/features/rs6000/powerpc-isa205-ppr-dscr-vsx32l.c
> create mode 100644 gdb/features/rs6000/powerpc-isa205-ppr-dscr-vsx32l.xml
> create mode 100644 gdb/features/rs6000/powerpc-isa205-ppr-dscr-vsx64l.c
> create mode 100644 gdb/features/rs6000/powerpc-isa205-ppr-dscr-vsx64l.xml
> create mode 100644 gdb/features/rs6000/powerpc-isa207-htm-vsx32l.c
> create mode 100644 gdb/features/rs6000/powerpc-isa207-htm-vsx32l.xml
> create mode 100644 gdb/features/rs6000/powerpc-isa207-htm-vsx64l.c
> create mode 100644 gdb/features/rs6000/powerpc-isa207-htm-vsx64l.xml
> create mode 100644 gdb/features/rs6000/powerpc-isa207-vsx32l.c
> create mode 100644 gdb/features/rs6000/powerpc-isa207-vsx32l.xml
> create mode 100644 gdb/features/rs6000/powerpc-isa207-vsx64l.c
> create mode 100644 gdb/features/rs6000/powerpc-isa207-vsx64l.xml
> create mode 100644 gdb/regformats/rs6000/powerpc-isa205-ppr-dscr-vsx32l.dat
> create mode 100644 gdb/regformats/rs6000/powerpc-isa205-ppr-dscr-vsx64l.dat
> create mode 100644 gdb/regformats/rs6000/powerpc-isa207-htm-vsx32l.dat
> create mode 100644 gdb/regformats/rs6000/powerpc-isa207-htm-vsx64l.dat
> create mode 100644 gdb/regformats/rs6000/powerpc-isa207-vsx32l.dat
> create mode 100644 gdb/regformats/rs6000/powerpc-isa207-vsx64l.dat
> create mode 100644 gdb/testsuite/gdb.arch/powerpc-htm-regs.c
> create mode 100644 gdb/testsuite/gdb.arch/powerpc-htm-regs.exp
> create mode 100644 gdb/testsuite/gdb.arch/powerpc-ppr-dscr.c
> create mode 100644 gdb/testsuite/gdb.arch/powerpc-ppr-dscr.exp
> create mode 100644 gdb/testsuite/gdb.arch/powerpc-tar.c
> create mode 100644 gdb/testsuite/gdb.arch/powerpc-tar.exp
Thanks,
Pedro Alves
next prev parent reply other threads:[~2018-10-23 15:37 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-22 22:33 Pedro Franco de Carvalho
2018-10-22 22:33 ` [PATCH v5 01/12] Zero-initialize linux note sections Pedro Franco de Carvalho
2018-10-22 22:33 ` [PATCH v5 02/12] [PowerPC] Don't zero-initialize vector register buffers Pedro Franco de Carvalho
2018-10-22 22:33 ` [PATCH v5 06/12] [PowerPC] Fix indentation in arch/ppc-linux-common.c Pedro Franco de Carvalho
2018-10-22 22:33 ` [PATCH v5 03/12] Add decfloat registers to float reggroup Pedro Franco de Carvalho
2018-10-22 22:33 ` [PATCH v5 04/12] [PowerPC] Remove rs6000_pseudo_register_reggroup_p Pedro Franco de Carvalho
2018-10-22 22:33 ` [PATCH v5 07/12] [PowerPC] Refactor have_ initializers in rs6000-tdep.c Pedro Franco de Carvalho
2018-10-22 22:33 ` [PATCH v5 05/12] [PowerPC] Fix two if statements in gdb/ppc-linux-nat.c Pedro Franco de Carvalho
2018-10-22 22:54 ` [PATCH v5 10/12] [PowerPC] Add support for EBB and PMU registers Pedro Franco de Carvalho
2018-10-22 22:56 ` [PATCH v5 11/12] [PowerPC] Reject tdescs with VSX and no FPU or Altivec Pedro Franco de Carvalho
2018-10-23 16:05 ` Pedro Alves
2018-10-23 18:46 ` Pedro Franco de Carvalho
2018-10-25 15:45 ` Pedro Alves
2018-10-22 22:58 ` [PATCH v5 09/12] [PowerPC] Add support for TAR Pedro Franco de Carvalho
2018-10-23 2:34 ` Eli Zaretskii
2018-10-23 18:50 ` Pedro Franco de Carvalho
2018-10-22 23:05 ` [PATCH v5 12/12] [PowerPC] Add support for HTM registers Pedro Franco de Carvalho
2019-02-09 5:51 ` Simon Marchi
2019-02-11 19:10 ` Pedro Franco de Carvalho
2018-10-22 23:16 ` [PATCH v5 08/12] [PowerPC] Add support for PPR and DSCR Pedro Franco de Carvalho
2018-10-23 15:37 ` Pedro Alves [this message]
2018-10-23 18:42 ` [PATCH v5 00/12] GDB support for more powerpc registers on linux Pedro Franco de Carvalho
2018-10-24 17:59 ` Ulrich Weigand
2018-10-25 20:05 ` Pedro Franco de Carvalho
2018-10-26 11:01 ` Ulrich Weigand
2018-10-26 10:57 ` Pedro Alves
2018-10-26 11:00 ` Ulrich Weigand
2018-10-26 15:16 ` Pedro Franco de Carvalho
2018-10-29 14:20 ` Regression on old kernels (Re: [PATCH v5 00/12] GDB support for more powerpc registers on linux) Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc88e21d-6605-6f29-3660-e619fd0ce9eb@redhat.com \
--to=palves@redhat.com \
--cc=edjunior@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=pedromfc@linux.ibm.com \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox