From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id I5Y8H+KBBWdeXgYAWB0awg (envelope-from ) for ; Tue, 08 Oct 2024 15:02:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1728414178; bh=q4fsKKnNiph3X9V2UwErpjoeqDwh+RoaAEjDWdr9KpE=; h=Date:Subject:To:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=aVggGRH2DE+AHFwyBOZfe0znPk2Tjx3h4lTWRUAzzai9VvyGI6OsEiAo7s1XS6jSu 5zu9sZZZnkMRElk0tWjH+24xSs4b2TWWHS/qBNUyewNIWNp5rnxeHSin99INesWlxU PynTcCR2Ei2PnVt9kUiew/nZGNB5BsnqciIxodPw= Received: by simark.ca (Postfix, from userid 112) id 6A1F21E355; Tue, 8 Oct 2024 15:02:58 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL, RCVD_IN_VALIDITY_SAFE,URIBL_BLOCKED,URIBL_DBL_BLOCKED_OPENDNS autolearn=unavailable autolearn_force=no version=4.0.0 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=Y5sz3oqP; dkim=pass (1024-bit key) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=n7nNExGU; dkim-atps=neutral Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 0B4F61E05C for ; Tue, 8 Oct 2024 15:02:58 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8D7A538650DB for ; Tue, 8 Oct 2024 19:02:57 +0000 (GMT) Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id D0C8E385DDD4 for ; Tue, 8 Oct 2024 19:02:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D0C8E385DDD4 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D0C8E385DDD4 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1728414151; cv=none; b=TMScgy+K5J21KiCylwJAdS/GYwRcyCTAekXscaTuoNQc1th5QMqeJBNpmE019GijH74f3tmD5Ul5HIrbs8yCLkcMC5IA+OBv67iOP2klIirbSy8YZW/waISdhwJV+gBLRPz78vmqwuOUPrm8fILgAFY6gwQ6vpj7CzF7ZuH3I0U= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1728414151; c=relaxed/simple; bh=q4fsKKnNiph3X9V2UwErpjoeqDwh+RoaAEjDWdr9KpE=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:MIME-Version: Subject:To:From; b=t+ogwDqB2THPS6epNpDNgcZYiNCYBG1xTg9D2KDk0XkrRGlg95pNvG4M+qpJ5/pEyBWVTxFYyAEwTYZm0y7HL0d/KX5Sml2HPwerYpGujblpaWXRxTRTVYKB/podFfy2gDhxZ3LWjrDxv7PJ6QASw4AcTmwQJJMWbpmxvbPGtBc= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1728414148; bh=q4fsKKnNiph3X9V2UwErpjoeqDwh+RoaAEjDWdr9KpE=; h=Date:Subject:To:References:From:In-Reply-To:From; b=Y5sz3oqPkYjU2lApSGSfZ8rVsu2NKOE5ObTyWOohP+npKOG11FWrif139tWMbMjyA weu1RNJ5cL0jvN7HMo4dn6t43c+c4Eo/LfvGQ3ATUhOO3J/ez3DpJ+A0a4u5XziG7t +YIQh8tFG6o0iJhLktF6CG8OgfOonw7XdEXQHqtU= Received: by simark.ca (Postfix, from userid 112) id A54521E356; Tue, 8 Oct 2024 15:02:28 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1728414147; bh=q4fsKKnNiph3X9V2UwErpjoeqDwh+RoaAEjDWdr9KpE=; h=Date:Subject:To:References:From:In-Reply-To:From; b=n7nNExGUqgP31rUQOfTBdlJIcdXwXkbkA3SsknxGO/y/NElfAhMyPeeh6yVyW6F4J +4izOzRMXHG8or5drg9Okkw2oxfoPAu7hmcdUN92P1k6MZIETY2q8Gyx9esnq1qWK2 DJQVnyob0nEyjWSR/G67uwB31NU/gi77Ska4Yb50= Received: from [10.0.0.11] (modemcable238.237-201-24.mc.videotron.ca [24.201.237.238]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 4127E1E05C; Tue, 8 Oct 2024 15:02:27 -0400 (EDT) Message-ID: Date: Tue, 8 Oct 2024 15:02:26 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] gdbserver: make arch and osabi names gdb::unique_xmalloc_ptr To: Andrew Burgess , gdb-patches@sourceware.org References: Content-Language: en-US From: Simon Marchi In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2024-10-06 14:37, Andrew Burgess wrote: > Convert target_desc::arch and target_desc::osabi from 'const char*' to > gdb::unique_xmalloc_ptr. This also allows us to remove the user > defined ~target_desc destructor. > > I doubt it ever actually occurred, but in theory at least, there was a > memory leak in set_tdesc_architecture and set_tdesc_osabi where the > member variables were assigned without freeing any previous > value... but I suspect that usually these fields are only set once. > > There should be no user visible changes after this commit. Could they be std::string instead? Simon