From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 109952 invoked by alias); 8 Jan 2019 11:25:09 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 109401 invoked by uid 89); 8 Jan 2019 11:24:51 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=styles X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 08 Jan 2019 11:24:49 +0000 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9041F8B101; Tue, 8 Jan 2019 11:24:35 +0000 (UTC) Received: from [10.36.117.230] (ovpn-117-230.ams2.redhat.com [10.36.117.230]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 830AD19C65; Tue, 8 Jan 2019 11:24:34 +0000 (UTC) Subject: Re: Oh dear. I regret to inform you that commit 053af8c9034f92d6e36a1180655ba22a65c56437 might be unfortunate To: Simon Marchi , gdb-buildbot@sergiodj.net Cc: gdb-patches@sourceware.org References: <053af8c9034f92d6e36a1180655ba22a65c56437-master-breakage@gdb-build> <3f3e538c74685b15579bf913aa764067@polymtl.ca> From: Nick Clifton Openpgp: preference=signencrypt Message-ID: Date: Tue, 08 Jan 2019 11:25:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 MIME-Version: 1.0 In-Reply-To: <3f3e538c74685b15579bf913aa764067@polymtl.ca> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2019-01/txt/msg00146.txt.bz2 Hi Simon, >> As you can see, GDB needs to be adjusted to stop using Sorry - I totally forgot to check the effect that the change would have on GDB. Mea culpa. >> test it, get it reviewed).  Would you mind reverting this patch, just >> the time we adjust the GDB code? Not at all. In fact I see that you have now done so. > I ended up reverting this patch to unbreak the build.  I'll try to update the GDB code shortly to unblock it (or if somebody else is motived, I don't mind). > > When re-syncing the code with GCC, note that there are corresponding changes to include/demangle.h that should be imported too. Yes, I missed that too. :-( There is also an update to the binutils/testsuite/binutils-all/cxxfilt.exp file that needs to go in to fix the tests for targets that use an underscore prefix to their symbol names. Also, once demangle.h is synchronized the binutils/cxxfilt.c source file will fail to build because it checks for redacted demangling styles. I have patches locally to fix both of these problems, which I can supply to a committer or else check in myself. Cheers Nick