From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 69084 invoked by alias); 13 Jun 2016 14:25:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 69069 invoked by uid 89); 13 Jun 2016 14:25:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:537 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 13 Jun 2016 14:25:14 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7F7363710C1; Mon, 13 Jun 2016 14:25:13 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u5DEPCmg029620; Mon, 13 Jun 2016 10:25:12 -0400 Subject: Re: [PATCH 02/12] More assert checks on reinsert breakpoint To: Yao Qi , gdb-patches@sourceware.org References: <1464859846-15619-1-git-send-email-yao.qi@linaro.org> <1464859846-15619-3-git-send-email-yao.qi@linaro.org> From: Pedro Alves Message-ID: Date: Mon, 13 Jun 2016 14:25:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: <1464859846-15619-3-git-send-email-yao.qi@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-06/txt/msg00229.txt.bz2 On 06/02/2016 10:30 AM, Yao Qi wrote: > This patch adds more asserts, so the incorrect or sub-optimal > reinsert breakpoints manipulations (from the tests in the following > patches) can trigger them. > > gdb/gdbserver: > > 2016-05-25 Yao Qi > > * linux-low.c (linux_resume_one_lwp_throw): Assert > has_reinsert_breakpoints returns false. > * mem-break.c (delete_disabled_breakpoints): Assert > bp type isn't reinsert_breakpoint. OK. Thanks, Pedro Alves