Re: [PATCH 18/40] A smarter linespec completer

Keith Seitz
2017-07-17T19:02:21Z

On 07/17/2017 11:21 AM, Pedro Alves wrote:
>>
>>> + int completion_quote_char;
>>
>> Why int?
>
> Mainly because the related readline code uses int too.

Well, that's definitely a good reason! That's all I really wanted to know.

> I can make this a char, and for consistency try to make completer_tracker
> use char too, though I'd prefer to do that as a patch on top of this one
> that touches every path in a single go, than update the few related
> completer_tracker patches, mainly because gdb_rl_find_completion_word
> is already in master. Would you mind that?

It's up to you, really. IMO, I don't see any overwhelming reason to change this. In fact, a good case could be made for not changing it (now that I know what said reason is).

> Here are the comments that I came up with. WDYT?

Perfect! Thanks!

Keith