From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25193 invoked by alias); 23 May 2014 04:17:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 25172 invoked by uid 89); 23 May 2014 04:17:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.6 required=5.0 tests=AWL,BAYES_00,MIME_BASE64_BLANKS,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: na01-bn1-obe.outbound.protection.outlook.com Received: from mail-bn1lp0144.outbound.protection.outlook.com (HELO na01-bn1-obe.outbound.protection.outlook.com) (207.46.163.144) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 23 May 2014 04:17:01 +0000 Received: from BN1BFFO11FD041.protection.gbl (10.58.144.34) by BN1BFFO11HUB051.protection.gbl (10.58.144.198) with Microsoft SMTP Server (TLS) id 15.0.949.9; Fri, 23 May 2014 04:16:57 +0000 Received: from xsj-gw1 (149.199.60.83) by BN1BFFO11FD041.mail.protection.outlook.com (10.58.144.104) with Microsoft SMTP Server id 15.0.949.9 via Frontend Transport; Fri, 23 May 2014 04:16:57 +0000 Received: from unknown-38-66.xilinx.com ([149.199.38.66] helo=xsj-smtp1) by xsj-gw1 with esmtp (Exim 4.63) (envelope-from ) id 1Wnguf-0006Fy-6L; Thu, 22 May 2014 21:16:57 -0700 From: Ajit Kumar Agarwal To: Michael Eager , Joel Brobecker CC: Michael Eager , "gdb-patches@sourceware.org" , Vinod Kathail , "Vidhumouli Hunsigida" , Nagaraju Mekala Subject: RE: [Patch, microblaze]: Add slr and shr regs and little-endian breakpoint Date: Fri, 23 May 2014 04:17:00 -0000 References: <537BC5B9.10601@eagercon.com> <537C5A25.9000003@eagerm.com> <5821f144-e431-4bee-9cd7-33971b5512a3@BN1AFFO11FD019.protection.gbl> <20140521134544.GL22822@adacore.com> <6ece3192-e76c-42b1-8554-a69c67e29d52@BN1BFFO11FD024.protection.gbl> <537E53AD.2070901@eagerm.com> In-Reply-To: <537E53AD.2070901@eagerm.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-RCIS-Action: ALLOW Message-ID: X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:149.199.60.83;CTRY:US;IPV:NLI;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(6009001)(438001)(479174003)(377454003)(377424004)(189002)(199002)(13464003)(54534003)(51704005)(24454002)(164054003)(86362001)(76176999)(70736001)(81542001)(74502001)(19580405001)(83322001)(2656002)(83072002)(44976005)(47776003)(87936001)(54356999)(23676002)(77982001)(79102001)(50986999)(92726001)(92566001)(81342001)(99396002)(31966008)(33646001)(20776003)(4396001)(46102001)(76482001)(74316001)(50466002)(21056001)(53416003)(80022001)(64706001)(19580395003);DIR:OUT;SFP:;SCL:1;SRVR:BN1BFFO11HUB051;H:xsj-gw1;FPR:;MLV:sfv;PTR:unknown-60-83.xilinx.com;MX:1;A:1;LANG:en; X-OriginatorOrg: xilinx.onmicrosoft.com X-Forefront-PRVS: 0220D4B98D Received-SPF: Pass (: domain of xilinx.com designates 149.199.60.83 as permitted sender) receiver=; client-ip=149.199.60.83; helo=xsj-gw1; Authentication-Results: spf=pass (sender IP is 149.199.60.83) smtp.mailfrom=ajit.kumar.agarwal@xilinx.com; X-SW-Source: 2014-05/txt/msg00575.txt.bz2 DQoNCi0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQpGcm9tOiBNaWNoYWVs IEVhZ2VyIFttYWlsdG86ZWFnZXJAZWFnZXJtLmNvbV0gDQpTZW50OiBGcmlk YXksIE1heSAyMywgMjAxNCAxOjE1IEFNDQpUbzogQWppdCBLdW1hciBBZ2Fy d2FsOyBKb2VsIEJyb2JlY2tlcg0KQ2M6IE1pY2hhZWwgRWFnZXI7IGdkYi1w YXRjaGVzQHNvdXJjZXdhcmUub3JnOyBWaW5vZCBLYXRoYWlsOyBWaWRodW1v dWxpIEh1bnNpZ2lkYTsgTmFnYXJhanUgTWVrYWxhDQpTdWJqZWN0OiBSZTog W1BhdGNoLCBtaWNyb2JsYXplXTogQWRkIHNsciBhbmQgc2hyIHJlZ3MgYW5k IGxpdHRsZS1lbmRpYW4gYnJlYWtwb2ludA0KDQpPbiAwNS8yMi8xNCAxMDo1 OCwgQWppdCBLdW1hciBBZ2Fyd2FsIHdyb3RlOg0KPiBUaGFua3MgIEpvZWwg Zm9yIHRoZSByZXZpZXcgY29tbWVudHMuIFdpbGwgbWFrZSBzdXJlIHRvIGNv bnNpZGVyIHlvdXIgc3VnZ2VzdGlvbnMNCj4gICB3aGVuIFN1Ym1pdHRpbmcg dGhlIG5ldyBwYXRjaGVzLg0KDQpQbGVhc2UgZG9uJ3QgdG9wIHBvc3QuICBQ bGVhc2UgdHJpbSB5b3VyIHJlc3BvbnNlcyBzbyB0aGV5IGRvbid0IGNvbnRh aW4gbXVsdGlwbGUgY29waWVzIG9mIHRoZSBzYW1lIHRleHQuDQoNCj4gQmFz ZWQgb24gdGhlIGZlZWRiYWNrLCB0aGUgdXBkYXRlZCBwYXRjaCBpcyBnaXZl biBiZWxvdy4NCj4NCj4gT2theSBmb3IgdGhlIHVwc3RyZWFtPw0KDQpBbiBP SyB3b3VsZCBvbmx5IGJlIGFwcHJvcHJpYXRlIGlmIHlvdSBoYWQgd3JpdGUg YWNjZXNzIHRvIHRoZSByZXBvc2l0b3J5Lg0KDQo+ICAgICAgW1BhdGNoLCBt aWNyb2JsYXplXTogQWRkIHNsciBhbmQgc2hyIHJlZ3MNCj4NCj4gICAgICBU aGlzIHBhdGNoIGFkZCB0aGUgc3VwcG9ydCBvZiBzbHIgYW5kIHNociByZWdz IGFuZCBhbHNvIHNvbHZlcyANCj4gdGhlIHByb2JsZW0NCg0KYWxzbz8gIElz IHRoZXJlIGFub3RoZXIgdW5tZW50aW9uZWQgcHJvYmxlbT8NCg0KPiAgICAg IHJlbGF0ZWQgdG8gcHJvY2Vzc19nX3BhY2tldCB3aGVyZSB0aGUgYnVmX2xl biA+IDIgKiByc2EtPnNpemVvZl9nX3BhY2tldA0KPiAgICAgIGFuZCB0aHJv d2luZyB0aGUgRXJyb3IgdGhhdCAnZycgcGFja2V0IG1lc3NhZ2UgcmVwbHkg aXMgdG9vIGxvbmcuIFRoaXMgaXMNCj4gICAgICBiZWNhdXNlIHRoZSBidWZf bGVuIGNhbGN1bGF0ZWQgaW4gdGhlIGluaXRfcmVtb3RlX3N0YXRlIGZ1bmN0 aW9uIGZvcg0KPiAgICAgIG1pY3JvYmxhemUgdGFyZ2V0IGlzIGJhc2VkIE9u IHRoZSBzaXplb2ZfZ19wYWNrZXQgYW5kIHJlbW90ZV9wYWNrZXRfc2l6ZQ0K PiAgICAgIGFuZCB0aGUgbWVtb3J5X3BhY2tldF9jb25maWctPnNpemUuIFRo ZSBzaXplb2ZfZ19wYWNrZXQgaXMgMjM2IGJlY2F1c2UgdGhlDQo+ICAgICAg bnVtYmVyIG9mIHJlZyBudW0gaXMgNTkgYW5kIDIqIHNpemVvZl9nX3BhY2tl dCBjb21lcyB0byA0NzIgLldpdGggc2hyIGFuZA0KPiAgICAgIHNobCBlbnRy eSBhbmQgdGhlIGJ1Zl9sZW4gaXMgNDcyLiBUaGlzIGRvZXMgbm90IG1hdGNo IHRoZSBncmVhdGVyIHRoYW4NCj4gICAgICBjb25kaXRpb25hbCBzdGF0ZW1l bnQgIGFuZCB3b3JrcyBmaW5lLiBXaXRob3V0IHNociBhbmQgc2hsIGVudHJ5 LHRoZQ0KPiAgICAgIHNpemVvZl9nX3BhY2tldHMgY29tZXMgdG8gNTcqNCAq MiA9IDQ1Ni4gIFRoaXMgZG9lc24ndCBtYXRjaCB0aGUgY3JpdGVyaWENCj4g ICAgICBpbiB0aGUgcHJvY2Vzc19nX3BhY2tldCBmdW5jdGlvbiAgbGVhZGlu ZyB0byB0aHJvd2luZyBvZiBlcnJvciBtZXNzYWdlIGFzDQo+ICAgICAgIiAn ZycgcGFja2V0IG1lc3NhZ2UgcmVwbHkgaXMgdG9vIGxvbmciLg0KDQo+PlBs ZWFzZSBtYWtlIHRoZSBkZXNjcmlwdGlvbiBvZiB0aGUgcHJvYmxlbSByZWFz b25hYmx5IHN1Y2NpbmN0LiAgQSBkZXRhaWxlZCBhbmFseXNpcyBvZiBob3cg eW91IGlkZW50aWZpZWQgdGhlIHByb2JsZW0gaXMgbm90IG5lZWRlZCwgZXNw ZWNpYWxseSB3aGVuIHlvdSBtZW50aW9uIHRoZSBlcnJvciBtZXNzYWdlID4+ YW5kIHRoZSBjYXVzZSBvZiB0aGUgZXJyb3IgbXVsdGlwbGUgdGltZXMuDQoN CkkgaGF2ZSBhZGRyZXNzZWQgdGhlIEpvZWwgY29tbWVudHMgYW5kIGluY29y cG9yYXRlZCBoaXMgc3VnZ2VzdGlvbnMuDQoNCldoYXQgaXMgcnVubmluZyBv biB0aGUgdGFyZ2V0Pw0KDQo+PklmIHRoaXMgYSBwcm9ibGVtIHVzaW5nIHRo ZSBYTUQgZ2Ric2VydmVyIHN0dWIgd2hpY2ggaXMgcmV0dXJuaW5nIG1vcmUg cmVnaXN0ZXJzIHRoYW4gR0RCIGV4cGVjdHM/DQoNClRoaXMgaXMgbm90IFhN RCBnZGJzZXJ2ZXIgc3R1YiBidXQgcmVsYXRlZCB0byBudW1iZXIgb2YgcmVn aXN0ZXJzIHdlIGRlZmluZSBtaWNyb2JsYXplLXRkZXAuYy4NCg0KPj4gSWYg dGhhdCBpcyB0aGUgY2FzZSwgdGhlbiBzYXkgc28uICBPdGhlcndpc2UsIHdo YXQgaXMgdGhlIGNhdXNlIG9mIHRoZSBtaXNtYXRjaCA+PmJldHdlZW4gdGhl IGdkYiBHIHBhY2tldCBhbmQgdGhlIHRhcmdldD8NCg0KSSBoYXZlIGFscmVh ZHkgcmVwbGllZCB0aGUgY2F1c2Ugb2YgdGhlIGVycm9yIGFuZCBsZXQgbWUg a25vdyBpZiB5b3UgbmVlZCBhZGRpdGlvbmFsIGluZm8uDQoNClRoYW5rcyAm IFJlZ2FyZHMNCkFqaXQNCj4NCj4gICAgICBDaGFuZ2VMb2c6DQo+ICAgICAg MjAxNC0wNS0yMCBBaml0IEFnYXJ3YWwgPGFqaXRrdW1AeGlsaW54LmNvbT4N Cj4NCj4gICAgICAgICAgKiBnZGIvZ2Ric2VydmVyL01ha2VmaWxlLmluICht aWNyb2JsYXplLWxpbnV4LmMpOiBOZXcgcnVsZS4NCj4NCj4gICAgICAgICAg KiBnZGIvbWljcm9ibGF6ZS10ZGVwLmMgKG1pY3JvYmxhemVfcmVnaXN0ZXJf bmFtZXMpOiBBZGRlZA0KPiAgICAgICAgICB0aGUgcnNociBhbmQgcnNsciBy ZWdpc3RlciBuYW1lcy4NCj4NCj4gICAgICAgICAgKiBnZGIvbWljcm9ibGF6 ZS10ZGVwLmggKG1pY3JvYmxhemVfcmVnX251bSk6IEFkZGl0aW9uIG9mDQo+ ICAgICAgICAgIGZpZWxkIE1JQ1JPQkxBWkVfU0xSX1JFR05VTSBhbmQgTUlD Uk9CTEFaRV9TSFJfUkVHTlVNLg0KPiAgICAgICAgICAobWljcm9ibGF6ZV9m cmFtZV9jYWNoZSk6IENoYW5nZSBpbiB0aGUgaW5kZXggb2YNCj4gICAgICAg ICAgcmVnaXN0ZXJfb2Zmc2V0cy4NCj4NCj4gICAgICAgICAgKiBnZGIvcmVn Zm9ybWF0cy9yZWctbWljcm9ibGF6ZS5kYXQ6IE5ldyBSZWdpc3RlciBkYXRh IGZpbGUuDQo+DQo+ICAgICAgU2lnbmVkLW9mZi1ieTpBaml0IEFnYXJ3YWwg YWppdGt1bUB4aWxpbnguY29tDQo+DQo+IFRoYW5rcyAmIFJlZ2FyZHMNCj4g QWppdA0KPg0KPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9t OiBKb2VsIEJyb2JlY2tlciBbbWFpbHRvOmJyb2JlY2tlckBhZGFjb3JlLmNv bV0NCj4gU2VudDogV2VkbmVzZGF5LCBNYXkgMjEsIDIwMTQgNzoxNiBQTQ0K PiBUbzogQWppdCBLdW1hciBBZ2Fyd2FsDQo+IENjOiBNaWNoYWVsIEVhZ2Vy OyBNaWNoYWVsIEVhZ2VyOyBnZGItcGF0Y2hlc0Bzb3VyY2V3YXJlLm9yZzsg Vmlub2QgDQo+IEthdGhhaWw7IFZpZGh1bW91bGkgSHVuc2lnaWRhOyBOYWdh cmFqdSBNZWthbGENCj4gU3ViamVjdDogUmU6IFtQYXRjaCwgbWljcm9ibGF6 ZV06IEFkZCBzbHIgYW5kIHNociByZWdzIGFuZCANCj4gbGl0dGxlLWVuZGlh biBicmVha3BvaW50DQo+DQo+PiBIZXJlIGlzIHRoZSBwcm9ibGVtICBkZXNj cmlwdGlvbi4gVGhlIHByb2JsZW0gaXMgcmVsYXRlZCB0byANCj4+IHByb2Nl c3NfZ19wYWNrZXQgd2hlcmUgdGhlIGJ1Zl9sZW4gPiAyICogcnNhLT5zaXpl b2ZfZ19wYWNrZXQgYW5kIA0KPj4gdGhyb3dpbmcgdGhlIEVycm9yIHRoYXQg J2cnIHBhY2tldCBtZXNzYWdlIHJlcGx5IGlzIHRvbyBsb25nLiBUaGlzIGlz IA0KPj4gYmVjYXVzZSB0aGUgYnVmX2xlbiBjYWxjdWxhdGVkIGluIHRoZSBp bml0X3JlbW90ZV9zdGF0ZSBmdW5jdGlvbiBmb3IgDQo+PiBtaWNyb2JsYXpl IHRhcmdldCBpcyBiYXNlZCBPbiB0aGUgc2l6ZW9mX2dfcGFja2V0IGFuZCAN Cj4+IHJlbW90ZV9wYWNrZXRfc2l6ZSBhbmQgdGhlIG1lbW9yeV9wYWNrZXRf Y29uZmlnLT5zaXplLiBUaGUgDQo+PiBzaXplb2ZfZ19wYWNrZXQgaXMgMjM2 IGJlY2F1c2UgdGhlIG51bWJlciBvZiByZWcgbnVtIGlzIDU5IGFuZCAyKiAN Cj4+IHNpemVvZl9nX3BhY2tldCBjb21lcyB0byA0NzIgLldpdGggc2hyIGFu ZCBzaGwgZW50cnkgYW5kIHRoZSBidWZfbGVuIA0KPj4gaXMgNDcyLiBUaGlz IGRvZXMgbm90IG1hdGNoIHRoZSBncmVhdGVyIHRoYW4gY29uZGl0aW9uYWwg c3RhdGVtZW50IA0KPj4gYW5kIHdvcmtzIGZpbmUuIFdpdGhvdXQgc2hyIGFu ZCBzaGwgZW50cnksdGhlIHNpemVvZl9nX3BhY2tldHMgY29tZXMgDQo+PiB0 bw0KPj4gNTcqNCAqMiA9IDQ1Ni4gIFRoaXMgZG9lc24ndCBtYXRjaCB0aGUg Y3JpdGVyaWEgaW4gdGhlIA0KPj4gcHJvY2Vzc19nX3BhY2tldCBmdW5jdGlv biBsZWFkaW5nIHRvIHRocm93aW5nIG9mIGVycm9yIG1lc3NhZ2UgYXMgICIN Cj4+ICdnJyBwYWNrZXQgbWVzc2FnZSByZXBseSBpcyB0b28gbG9uZyIuDQo+ Pg0KPj4gVGhpcyBpcyBoYXBwZW5pbmcgd2hlbiB0YXIgcmVtb3RlIG1hY2hp bmU6MTIzNCBjb21tYW5kIGlzIHJ1biBpbiBnZGIuDQo+Pg0KPj4+Pj4gVGhl c2UgY2hhbmdlcyBkb24ndCBhcHBlYXIgcmVsYXRlZC4gIFNwbGl0IGluZGVw ZW5kZW50IGNoYW5nZXMgaW4gDQo+Pj4+PiB0byBzZXBhcmF0ZSBwYXRjaGVz Lg0KPj4NCj4+IEkgd2lsbCBzcGxpdCB0aGUgY2hhbmdlcyAgYW5kIHNlbmQg dGhlIHNlcGFyYXRlIHBhdGNoIHdpdGggc2hyIGFuZCANCj4+IHNobCByZWcg Y2hhbmdlcyBhbmQgdGhlIGxpdHRsZSBlbmRpYW4gYnJlYWtwb2ludCBzdXBw b3J0Lg0KPg0KPiBUaGFua3MsIEFqaXQuIEZXSVcsIEkgYWdyZWUgd2l0aCBN aWNoYWVsLg0KPg0KPiBBbHNvLCB3aGVuIHN1Ym1pdHRpbmcgdGhlIG5ldyBw YXRjaGVzLCBwbGVhc2UgaW5jbHVkZSB0aGUgZGVzY3JpcHRpb24gb2YgdGhl IHByb2JsZW0geW91IGFyZSB0cnlpbmcgdG8gc29sdmUgaW4gdGhlIHJldmlz aW9uIGxvZyBvZiB5b3VyIHBhdGNoLiBTb21ldGhpbmcgbGlrZSB0aGUgZGVz Y3JpcHRpb24geW91IGdhdmUgYWJvdmUsIGZvciBpbnN0YW5jZS4NCj4gVGhp cyBtYWtlcyBhcmNoZW9sb2d5IGEgbG90IGVhc2llciBmb3IgdXMuICBUaGUg Z29vZCBuZXdzIHdoZW4gZG9pbmcgdGhhdCBpcyB0aGF0IHN1Ym1pdHRpbmcg dGhlIHBhdGNoIGNvdWxkIGJlIGFzIHNpbXBsZSBhcyAiZ2l0IHNlbmQtZW1h aWwiLWluZyB0aGUgcGF0Y2g7IHRoYXQncyB3aGF0IEkgcGVyc29uYWxseSBk byBmb3IgbXkgb3duIHBhdGNoZXMsIGFuZCBpdCdzIGJlZW4gYSByZWFsIHRp bWUgc2F2ZXIuDQo+DQo+IC0tDQo+IEpvZWwNCj4NCg0KDQotLSANCk1pY2hh ZWwgRWFnZXIJIGVhZ2VyQGVhZ2VyY29uLmNvbQ0KMTk2MCBQYXJrIEJsdmQu LCBQYWxvIEFsdG8sIENBIDk0MzA2ICA2NTAtMzI1LTgwNzcNCg== >From gdb-patches-return-112738-listarch-gdb-patches=sources.redhat.com@sourceware.org Fri May 23 05:52:28 2014 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 26781 invoked by alias); 23 May 2014 05:52:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 26764 invoked by uid 89); 23 May 2014 05:52:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 X-HELO: qmta13.emeryville.ca.mail.comcast.net Received: from qmta13.emeryville.ca.mail.comcast.net (HELO qmta13.emeryville.ca.mail.comcast.net) (76.96.27.243) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 23 May 2014 05:52:22 +0000 Received: from omta09.emeryville.ca.mail.comcast.net ([76.96.30.20]) by qmta13.emeryville.ca.mail.comcast.net with comcast id 5Hns1o0010S2fkCADHsM9q; Fri, 23 May 2014 05:52:21 +0000 Received: from redwood.eagercon.com ([24.7.16.38]) by omta09.emeryville.ca.mail.comcast.net with comcast id 5HsL1o00A0pGQcg8VHsLGn; Fri, 23 May 2014 05:52:21 +0000 Message-ID: <537EE214.7030405@eagercon.com> Date: Fri, 23 May 2014 05:52:00 -0000 From: Michael Eager User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Ajit Kumar Agarwal , Michael Eager , Joel Brobecker CC: "gdb-patches@sourceware.org" , Vinod Kathail , Vidhumouli Hunsigida , Nagaraju Mekala Subject: Re: [Patch, microblaze]: Add slr and shr regs and little-endian breakpoint References: <537BC5B9.10601@eagercon.com> <537C5A25.9000003@eagerm.com> <5821f144-e431-4bee-9cd7-33971b5512a3@BN1AFFO11FD019.protection.gbl> <20140521134544.GL22822@adacore.com> <6ece3192-e76c-42b1-8554-a69c67e29d52@BN1BFFO11FD024.protection.gbl> <537E53AD.2070901@eagerm.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2014-05/txt/msg00576.txt.bz2 Content-length: 3951 On 05/22/14 21:16, Ajit Kumar Agarwal wrote: I can't tell which responses come from you or which you are repeating from previous email. See questions and comments below. You need to address all issues raised. > -----Original Message----- > From: Michael Eager [mailto:eager@eagerm.com] > Sent: Friday, May 23, 2014 1:15 AM > To: Ajit Kumar Agarwal; Joel Brobecker > Cc: Michael Eager; gdb-patches@sourceware.org; Vinod Kathail; Vidhumouli Hunsigida; Nagaraju Mekala > Subject: Re: [Patch, microblaze]: Add slr and shr regs and little-endian breakpoint > > On 05/22/14 10:58, Ajit Kumar Agarwal wrote: >> Thanks Joel for the review comments. Will make sure to consider your suggestions >> when Submitting the new patches. > > Please don't top post. Please trim your responses so they don't contain multiple copies of the same text. > >> Based on the feedback, the updated patch is given below. >> >> Okay for the upstream? > > An OK would only be appropriate if you had write access to the repository. > >> [Patch, microblaze]: Add slr and shr regs >> >> This patch add the support of slr and shr regs and also solves >> the problem > > also? Is there another unmentioned problem? > >> related to process_g_packet where the buf_len > 2 * rsa->sizeof_g_packet >> and throwing the Error that 'g' packet message reply is too long. This is >> because the buf_len calculated in the init_remote_state function for >> microblaze target is based On the sizeof_g_packet and remote_packet_size >> and the memory_packet_config->size. The sizeof_g_packet is 236 because the >> number of reg num is 59 and 2* sizeof_g_packet comes to 472 .With shr and >> shl entry and the buf_len is 472. This does not match the greater than >> conditional statement and works fine. Without shr and shl entry,the >> sizeof_g_packets comes to 57*4 *2 = 456. This doesn't match the criteria >> in the process_g_packet function leading to throwing of error message as >> " 'g' packet message reply is too long". > >>> Please make the description of the problem reasonably succinct. A detailed analysis of how you identified the problem is not needed, especially when you mention the error message >>and the cause of the error multiple times. > > I have addressed the Joel comments and incorporated his suggestions. Make sure you address my comments and incorporate my suggestions as well. > > What is running on the target? > >>> If this a problem using the XMD gdbserver stub which is returning more registers than GDB expects? > > This is not XMD gdbserver stub but related to number of registers we define microblaze-tdep.c. > >>> If that is the case, then say so. Otherwise, what is the cause of the mismatch >>between the gdb G packet and the target? > > I have already replied the cause of the error and let me know if you need additional info. I asked what is running on the target which is returning a different sized G packet. >> >> Thanks, Ajit. FWIW, I agree with Michael. >> >> Also, when submitting the new patches, please include the description of the problem you are trying to solve in the revision log of your patch. Something like the description you gave above, for instance. >> This makes archeology a lot easier for us. The good news when doing that is that submitting the patch could be as simple as "git send-email"-ing the patch; that's what I personally do for my own patches, and it's been a real time saver. Please resubmit the patch, following instructions. Please start over, dropping all the discussion, answers, and non-answers. Being unwilling to answer details of a patch which appears to be untestable is not likely to get it approved. The subject line should indicate the patch you are submitting, not something which no longer describes the patch. -- Michael Eager eager@eagercon.com 1960 Park Blvd., Palo Alto, CA 94306 650-325-8077