From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 375 invoked by alias); 13 Apr 2017 16:31:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 348 invoked by uid 89); 13 Apr 2017 16:31:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-10.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 13 Apr 2017 16:31:55 +0000 Received: from svr-orw-mbx-03.mgc.mentorg.com ([147.34.90.203]) by relay1.mentorg.com with esmtp id 1cyhf0-0006eV-CU from Luis_Gustavo@mentor.com ; Thu, 13 Apr 2017 09:31:54 -0700 Received: from [172.30.1.10] (147.34.91.1) by svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Thu, 13 Apr 2017 09:31:50 -0700 Subject: Re: [PATCH 2/4] Use mips_regnum instead of constants for FreeBSD/mips register operations. References: <20170412183727.22483-1-jhb@FreeBSD.org> <20170412183727.22483-3-jhb@FreeBSD.org> To: John Baldwin , Reply-To: Luis Machado From: Luis Machado Message-ID: Date: Thu, 13 Apr 2017 16:31:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170412183727.22483-3-jhb@FreeBSD.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SVR-ORW-MBX-07.mgc.mentorg.com (147.34.90.207) To svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) X-IsSubscribed: yes X-SW-Source: 2017-04/txt/msg00443.txt.bz2 On 04/12/2017 01:37 PM, John Baldwin wrote: > gdb/ChangeLog: > > * mips-fbsd-tdep.c (MIPS_PC_REGNUM): Remove. > (MIPS_FP0_REGNUM): Remove. > (MIPS_FSR_REGNUM): Remove. > (mips_fbsd_supply_fpregs): Use mips_regnum. > (mips_fbsd_supply_gregs): Likewise. > (mips_fbsd_collect_fpregs): Likewise. > (mips_fbsd_collect_gregs): Likewise. > --- > gdb/ChangeLog | 10 ++++++++++ > gdb/mips-fbsd-tdep.c | 29 ++++++++++++++++------------- > 2 files changed, 26 insertions(+), 13 deletions(-) This one looks correct to me. I have no comments.