From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id GysBCsnG/mIhZykAWB0awg (envelope-from ) for ; Thu, 18 Aug 2022 19:10:01 -0400 Received: by simark.ca (Postfix, from userid 112) id 1A1971E4A7; Thu, 18 Aug 2022 19:10:01 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=xtaqMbMs; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C14181E21F for ; Thu, 18 Aug 2022 19:10:00 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E30A23858C2D for ; Thu, 18 Aug 2022 23:09:59 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E30A23858C2D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1660864199; bh=8nWdi0VBDKZHDAm06Rw5OswpGNgeHYN65HUqOVDXe8M=; h=Subject:To:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=xtaqMbMsfUcJGa++c5OOFyk8xANL7Kk1O/TuoDIDz1HaLeuO1dzvOxs8RePxO5dzF JTiDpX+LzWsBo0TaesVToLnUFdntFjZ6Yi2I4eygVLqoM3mraHAlJtMx3HBVXLqMr+ TaORjaqyYBwzXJMKDcN+yFm0xQgOmaUghbg6yJ+w= Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 544643858C83 for ; Thu, 18 Aug 2022 23:09:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 544643858C83 Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 27IMsOZ2003646 for ; Thu, 18 Aug 2022 23:09:40 GMT Received: from ppma03dal.us.ibm.com (b.bd.3ea9.ip4.static.sl-reverse.com [169.62.189.11]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3j1xmdgeu6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 18 Aug 2022 23:09:40 +0000 Received: from pps.filterd (ppma03dal.us.ibm.com [127.0.0.1]) by ppma03dal.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 27IN5esI020851 for ; Thu, 18 Aug 2022 23:09:39 GMT Received: from b03cxnp08026.gho.boulder.ibm.com (b03cxnp08026.gho.boulder.ibm.com [9.17.130.18]) by ppma03dal.us.ibm.com with ESMTP id 3hx3kahryc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 18 Aug 2022 23:09:39 +0000 Received: from b03ledav004.gho.boulder.ibm.com (b03ledav004.gho.boulder.ibm.com [9.17.130.235]) by b03cxnp08026.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 27IN9cKG56557916 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 18 Aug 2022 23:09:38 GMT Received: from b03ledav004.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6130B78087; Thu, 18 Aug 2022 23:09:38 +0000 (GMT) Received: from b03ledav004.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1C30D78083; Thu, 18 Aug 2022 23:09:37 +0000 (GMT) Received: from li-e362e14c-2378-11b2-a85c-87d605f3c641.ibm.com (unknown [9.211.56.41]) by b03ledav004.gho.boulder.ibm.com (Postfix) with ESMTP; Thu, 18 Aug 2022 23:09:37 +0000 (GMT) Message-ID: Subject: Re: [PATCH ver 3] Fix hardware watchpoint check in test gdb.base/watchpoint-reuse-slot.exp To: Ulrich Weigand , "gdb-patches@sourceware.org" Date: Thu, 18 Aug 2022 16:09:37 -0700 In-Reply-To: <01b41aa2582852453aadb3ab5cdc80230e60eac2.camel@de.ibm.com> References: <3783e7e44fe188af5ca1f2ddcfa4c7f5cb7a818e.camel@us.ibm.com> <47fd087cd94544b980aab5eed9f6113ab5a183f9.camel@us.ibm.com> <01b41aa2582852453aadb3ab5cdc80230e60eac2.camel@de.ibm.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 (3.28.5-18.el8) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: mnunRMQfe6_2J8dANrfvNG5wORoLtbyn X-Proofpoint-GUID: mnunRMQfe6_2J8dANrfvNG5wORoLtbyn X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-08-18_16,2022-08-18_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 adultscore=0 bulkscore=0 phishscore=0 lowpriorityscore=0 mlxlogscore=564 mlxscore=0 suspectscore=0 malwarescore=0 impostorscore=0 priorityscore=1501 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2207270000 definitions=main-2208180084 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Carl Love via Gdb-patches Reply-To: Carl Love Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" Ulrich: On Thu, 2022-08-18 at 14:31 +0000, Ulrich Weigand wrote: > > + > > +set skip_hw_watchpoint_tests_p [skip_hw_watchpoint_tests] > > -if { ![target_info exists gdb,no_hardware_watchpoints]} { > > +if { ![skip_hw_breakpoint_tests] } { > > I guess this will *work* as the skip_hw_breakpoint_tests > function uses a cache to avoid re-running the test. > > But it would seem more logical here to use the > skip_hw_watchpoint_tests_p variable defined above. Yes, I agree I will update this patch and the patch for the other two patches to use skip_hw_watchpoint_tests_p. Thanks. Note, I will post them when I get back from vacation. Carl