Re: [PATCH v3] Add a 'starti' command.

Pedro Alves
2017-09-19T18:29:13Z

On 09/19/2017 06:49 PM, John Baldwin wrote:

> Hmm, how about:
>
> enum run_how
> {
> /* Run program without any explicit stop during startup. */
> RUN_NORMAL,

Sounds fine.

>> You have a "\n" in the middle of some lines above. Was that intended?
>> I'd expect to see instead lines broken at \n, ending with \n\ .
>
> Those were just copy and pasted from the run help. I think they were there
> to avoid overflowing 80 columns in the source. I've rewrapped the text so
> that newlines are at the end.

Thanks.

>> Space before parens, line break after return type.
>> We follow GNU convention in tests too, unless different syntax is
>> relevant for the test.
>
> Ok. (Ironically I copied both the spurious #include and bad style
> from start.c.)

Yeah, sorry about that. It was only in recent years that we
started following that rule; older tests will be using
random styles.

Thanks,
Pedro Alves