From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 126678 invoked by alias); 15 Nov 2017 20:23:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 126662 invoked by uid 89); 15 Nov 2017 20:23:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=BAYES_00,KB_WAM_FROM_NAME_SINGLEWORD,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 15 Nov 2017 20:23:44 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 52E87356D4; Wed, 15 Nov 2017 20:23:43 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 478BA99AF1; Wed, 15 Nov 2017 20:23:42 +0000 (UTC) Subject: Re: [PATCH v3] Add a 'starti' command. To: John Baldwin , Yao Qi References: <20170911220803.73819-1-jhb@FreeBSD.org> <86inerwm8t.fsf@gmail.com> <1615021.krJEU3LQPO@ralph.baldwin.cx> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: Date: Wed, 15 Nov 2017 20:23:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1615021.krJEU3LQPO@ralph.baldwin.cx> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-11/txt/msg00288.txt.bz2 On 11/15/2017 08:11 PM, John Baldwin wrote: > On Friday, November 03, 2017 01:00:18 PM Yao Qi wrote: >> John Baldwin writes: >> >>> +# Continue to the start of main(). The constructor should have run so >>> +# 'x' should be 1. >>> + >>> +gdb_breakpoint main >>> +gdb_test_sequence "continue" "" { >>> + "\\$2 = 1" >>> + ".*Breakpoint .*main \\(\\) at .*starti.c.*" >> >> Here is a test failure, captured by buildbot, >> https://sourceware.org/ml/gdb-testers/2017-q3/msg04381.html >> >> (gdb) gdb_expect_list pattern: /\$2 = 1/ >> continue^M >> Continuing.^M >> $2 = 1^M >> gdb_expect_list pattern: /.*Breakpoint .*main \(\) at .*starti.c.*/ >> ^M >> Breakpoint 1, Python Exception Installation error: gdb.execute_unwinders function is missing: ^M >> main () at /home/yao/SourceCode/gnu/gdb/git/gdb/testsuite/gdb.base/starti.c:29^M >> 29 return 0;^M >> (gdb) gdb_expect_list pattern: // >> FAIL: gdb.base/starti.exp: continue (pattern 3 + sentinel) (timeout) >> >> Can you take a look? > > Hmm, so it seems the python exception adds a newline which throws the regex > match off as 'main \(\)' is now on a second line. The 'start.exp' test > only looks for the 'main' bit and not the preceding 'Breakpoint', so > something like this instead? But is the Python exception expected? From Yao's earlier paste: (gdb) gdb_expect_list pattern: /\$2 = 1/ continue^M Continuing.^M $2 = 1^M gdb_expect_list pattern: /.*Breakpoint .*main \(\) at .*starti.c.*/ ^M Breakpoint 1, Python Exception Installation error: gdb.execute_unwinders function is missing: ^M main () at /home/yao/SourceCode/gnu/gdb/git/gdb/testsuite/gdb.base/starti.c:29^M 29 return 0;^M (gdb) gdb_expect_list pattern: // FAIL: gdb.base/starti.exp: continue (pattern 3 + sentinel) (timeout) "Installation error" looks quite odd to me. Why did that happen? Thanks, Pedro Alves