From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id lKnMF8H74mDpXQAAWB0awg (envelope-from ) for ; Mon, 05 Jul 2021 08:32:01 -0400 Received: by simark.ca (Postfix, from userid 112) id 52C021F1F2; Mon, 5 Jul 2021 08:32:01 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 4BD581E940 for ; Mon, 5 Jul 2021 08:32:00 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9E13E386FC0E for ; Mon, 5 Jul 2021 12:31:59 +0000 (GMT) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id EB3553857409 for ; Mon, 5 Jul 2021 12:31:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EB3553857409 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 285AA22676; Mon, 5 Jul 2021 12:31:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1625488283; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pVHpVQYs5EJHW4d3L085/XjMY3e71QSzL/x8uOU9wIA=; b=iRMmG9cMzwocNkQ14ibDfYoLLj2FS8IMeOMD2DcO+KSQi34GrDZSTKeRaMxb6vdRwGfgCH MzDkxGa5n9Ba+7MKlPQ6BjbgppflpJZ7o80jN4p+v9JJaK7dHEHK+WNABNva2TF+mNuQT6 vyU69b3lrBNgiXtn6LJJsrxWFQZDbiM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1625488283; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pVHpVQYs5EJHW4d3L085/XjMY3e71QSzL/x8uOU9wIA=; b=pvkmEowpsGLjRj/BUGMIjgnIhQ8xsP7jHf0TFAIZ5KGdaR6jmC6EfyhRD7Jre1tuOTMQc8 ZZ3YCfFfnGfm03Dg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 12D5F13A49; Mon, 5 Jul 2021 12:31:23 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id /XnxApv74mA0bQAAMHmgww (envelope-from ); Mon, 05 Jul 2021 12:31:23 +0000 Subject: Re: [PATCHv3 2/5] gdb: make struct output_source_filename_data more C++ like To: Andrew Burgess , gdb-patches@sourceware.org References: <44f3bcb87067e98b6ff670e133b366a902cc69ab.1623090529.git.andrew.burgess@embecosm.com> From: Tom de Vries Message-ID: Date: Mon, 5 Jul 2021 14:31:22 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <44f3bcb87067e98b6ff670e133b366a902cc69ab.1623090529.git.andrew.burgess@embecosm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 6/7/21 8:32 PM, Andrew Burgess wrote: > +bool > +info_sources_filter::matches (const char *fullname) const > +{ > + /* Does it match regexp? */ > + if (m_c_regexp.has_value ()) > + { > + const char *to_match; > + std::string dirname; > + > + switch (m_match_type) > + { > + case match_on::DIRNAME: > + dirname = ldirname (fullname); > + to_match = dirname.c_str (); > + break; > + case match_on::BASENAME: > + to_match = lbasename (fullname); > + break; > + case match_on::FULLNAME: > + to_match = fullname; > + break; > + } > + > + if (m_c_regexp->exec (to_match, 0, NULL, 0) != 0) > + return false; > + } > + > + return true; > +} When compiling with -O2, I run into: ... src/gdb/symtab.c: In member function ‘bool info_sources_filter::matches(const char*) const’: src/gdb/symtab.c:4247:28: warning: ‘to_match’ may be used uninitialized in this function [-Wmaybe-uninitialized] 4247 | if (m_c_regexp->exec (to_match, 0, NULL, 0) != 0) | ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~ ... Thanks, - Tom