From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id cXdIG4cNJWqz+DkAWB0awg (envelope-from ) for ; Sun, 07 Jun 2026 02:19:51 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=f9DL0WcU; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=KMqZcbLI; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=f9DL0WcU; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=KMqZcbLI; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 6C40F1E024; Sun, 07 Jun 2026 02:19:51 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 9DE0D1E024 for ; Sun, 07 Jun 2026 02:19:50 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3D2534C318A1 for ; Sun, 7 Jun 2026 06:19:50 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3D2534C318A1 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=f9DL0WcU; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=KMqZcbLI; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=f9DL0WcU; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=KMqZcbLI Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id C313C4B7A1CE for ; Sun, 7 Jun 2026 06:19:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C313C4B7A1CE Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C313C4B7A1CE Authentication-Results: sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1780813160; cv=none; b=tyAY9tan1o8YCb/deDFa6qnj3o0Lmywk6N6fyzpvZmZd+Q0gck2/6tEgR0zJty1HyfrLSAky1tRtDiT54oY7GDDQu0IV/gIVA0B+POTJkrYz1l0bdHM3zy8aXXwnVZ/NsT3a/xSUV+BwknZv+kfaCf2196FrAaE7XIT/Uv6znQc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1780813160; c=relaxed/simple; bh=lBtX6/++OIWBCfoCgVvUCYL4s4dm1CynvsS4Qy8ZChI=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=WId/NNeb33fdNE/l97Ww/KtjoBkYwega7EqpV1pjjnnej5h4Qd8fzzinz/71X6i1icrDk7yX8389OVjHPYxVY6DOpwloOQzvOjHEhg/3pXvKsQvCjH85d6tyR7Fx0TLmH3Gj0AvC9xIMcbxSae035Qaiv0kqp97obqdJpomm10w= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=f9DL0WcU; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=KMqZcbLI; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=f9DL0WcU; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=KMqZcbLI DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C313C4B7A1CE Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id B4C667591B; Sun, 7 Jun 2026 06:19:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1780813159; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8egS3Q4mxeyzaHTplyseQrkQL24ikCmxI6tBbre4a2M=; b=f9DL0WcUBqih8LJpmESkAy9A5UH2ZKgu+D+WjU1qbmOfgihXRHXnRWvViCfe7MRA9LxCg+ SRbpfGzGtHwD+ERZFq9fLM0ywDR5WwQBIbui9+W+5fyaapBAr09GklbNgfZutKonRrqQfP DD07XZvcUq/bDxykeds/Jpq8Iy0ulWk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1780813159; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8egS3Q4mxeyzaHTplyseQrkQL24ikCmxI6tBbre4a2M=; b=KMqZcbLIzCp4UxrBSE7vmqGqJG7McJO7+z5DRzAiAa2XnVNMFyL/cDtRCFFEPEyBKhmjDP cN1tOTYXaeHYErBg== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=f9DL0WcU; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=KMqZcbLI DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1780813159; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8egS3Q4mxeyzaHTplyseQrkQL24ikCmxI6tBbre4a2M=; b=f9DL0WcUBqih8LJpmESkAy9A5UH2ZKgu+D+WjU1qbmOfgihXRHXnRWvViCfe7MRA9LxCg+ SRbpfGzGtHwD+ERZFq9fLM0ywDR5WwQBIbui9+W+5fyaapBAr09GklbNgfZutKonRrqQfP DD07XZvcUq/bDxykeds/Jpq8Iy0ulWk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1780813159; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8egS3Q4mxeyzaHTplyseQrkQL24ikCmxI6tBbre4a2M=; b=KMqZcbLIzCp4UxrBSE7vmqGqJG7McJO7+z5DRzAiAa2XnVNMFyL/cDtRCFFEPEyBKhmjDP cN1tOTYXaeHYErBg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 992FC779A7; Sun, 7 Jun 2026 06:19:19 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id XNCUI2cNJWoLfgAAD6G6ig (envelope-from ); Sun, 07 Jun 2026 06:19:19 +0000 Message-ID: Date: Sun, 7 Jun 2026 08:19:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PUSHED] gdb: store gdbtk object files into their sources directory To: Patrick Monnerat , gdb-patches@sourceware.org References: <20260411141108.78765-2-patrick@monnerat.net> Content-Language: en-US From: Tom de Vries In-Reply-To: <20260411141108.78765-2-patrick@monnerat.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCPT_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid,suse.de:dkim]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:104:10:150:64:97:from,2a07:de40:b281:106:10:150:64:167:received]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Queue-Id: B4C667591B X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 4/11/26 4:11 PM, Patrick Monnerat wrote: > Do not list gdbtk required object file names, but generates them from > source file names. > > Use gdb object file list rather than static library for linking insight. This breaks building gdb.pot ( https://sourceware.org/bugzilla/show_bug.cgi?id=34212 ). Thanks, - Tom > --- > gdb/Makefile.in | 31 ++++++++++--------------------- > 1 file changed, 10 insertions(+), 21 deletions(-) > > diff --git a/gdb/Makefile.in b/gdb/Makefile.in > index 81a601dc448..b235edf6356 100644 > --- a/gdb/Makefile.in > +++ b/gdb/Makefile.in > @@ -559,29 +559,19 @@ GDBTK_LIBRARY = $(datadir)/insight$(GDBTK_VERSION) > # the testsuite won't run properly. > GDBTK_SRC_DIR = @GDBTK_SRC_DIR@ > > -SUBDIR_GDBTK_OBS = \ > - gdbtk.o \ > - gdbtk-bp.o \ > - gdbtk-cmds.o \ > - gdbtk-hooks.o \ > - gdbtk-interp.o \ > - gdbtk-register.o \ > - gdbtk-stack.o \ > - gdbtk-varobj.o \ > - gdbtk-wrapper.o > - > SUBDIR_GDBTK_SRCS = \ > gdbtk/generic/gdbtk.c \ > gdbtk/generic/gdbtk-bp.c \ > gdbtk/generic/gdbtk-cmds.c \ > gdbtk/generic/gdbtk-hooks.c \ > gdbtk/generic/gdbtk-interp.c \ > - gdbtk/generic/gdbtk-main.c \ > gdbtk/generic/gdbtk-register.c \ > gdbtk/generic/gdbtk-stack.c \ > gdbtk/generic/gdbtk-varobj.c \ > gdbtk/generic/gdbtk-wrapper.c > > +SUBDIR_GDBTK_OBS = $(patsubst %.c,%.o,$(SUBDIR_GDBTK_SRCS)) > + > SUBDIR_GDBTK_DEPS = $(LIBGUI) $(TCL_DEPS) $(TK_DEPS) > SUBDIR_GDBTK_LDFLAGS = > SUBDIR_GDBTK_CFLAGS= -DGDBTK -D@TCL_PLATFORM_DEFINE@ -D@TK_PLATFORM_DEFINE@ > @@ -599,7 +589,7 @@ HAVE_NATIVE_GCORE_TARGET = @HAVE_NATIVE_GCORE_TARGET@ > HAVE_GSTACK = @HAVE_GSTACK@ > > CONFIG_SRC_SUBDIR = arch cli dwarf2 mi compile tui unittests guile python \ > - target nat > + target nat gdbtk/generic > CONFIG_DEP_SUBDIR = $(addsuffix /$(DEPDIR),$(CONFIG_SRC_SUBDIR)) > > # -I. for config files. > @@ -2110,10 +2100,8 @@ $(CONFIG_DEP_SUBDIR): > # Python files need special flags. > python/%.o: INTERNAL_CFLAGS += $(PYTHON_CFLAGS) > > -# Rules for compiling .c files in the various source subdirectories. > -%.o: $(srcdir)/gdbtk/generic/%.c > - $(COMPILE) $(all_gdbtk_cflags) $< > - $(POSTCOMPILE) > +# Insight UI needs special flags. > +gdbtk/generic/%.o: INTERNAL_CFLAGS += $(all_gdbtk_cflags) > > installcheck: > > @@ -2343,6 +2331,7 @@ uninstall: force $(CONFIG_UNINSTALL) > # computing the list of source files from the list of object files. > > INIT_FILES_FILTER_OUT = \ > + gdbres.o \ > init.o \ > version.o \ > xml-builtin.o \ > @@ -2824,10 +2813,10 @@ clean-gdbtk: > rm -f insight$(EXEEXT) > > # Removing the old gdb first works better if it is running, at least on SunOS. > -insight$(EXEEXT): gdbtk-main.o libgdb.a $(CDEPS) $(TDEPLIBS) > - rm -f insight$(EXEEXT) > +insight$(EXEEXT): gdbtk/generic/gdbtk-main.o $(LIBGDB_OBS) $(CDEPS) $(TDEPLIBS) > + $(SILENCE) rm -f insight$(EXEEXT) > $(ECHO_CXXLD) $(CC_LD) $(INTERNAL_LDFLAGS) $(WIN32LDAPP) \ > - -o insight$(EXEEXT) gdbtk-main.o libgdb.a \ > + -o insight$(EXEEXT) gdbtk/generic/gdbtk-main.o $(LIBGDB_OBS) \ > $(TDEPLIBS) $(TUI_LIBRARY) $(CLIBS) $(LOADLIBES) > > gdbres.o: $(srcdir)/gdbtk/gdb.rc $(srcdir)/gdbtk/gdbtool.ico > @@ -2862,7 +2851,7 @@ endif > > # A list of all the objects we might care about in this build, for > # dependency tracking. > -all_object_files = gdb.o $(LIBGDB_OBS) gdbtk-main.o > +all_object_files = gdb.o $(LIBGDB_OBS) gdbtk/generic/gdbtk-main.o > > # All the .deps files to include. > all_deps_files = $(foreach dep,$(patsubst %.o,%.Po,$(all_object_files)),\