From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19859 invoked by alias); 31 May 2009 15:50:51 -0000 Received: (qmail 19849 invoked by uid 22791); 31 May 2009 15:50:50 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from yx-out-1718.google.com (HELO yx-out-1718.google.com) (74.125.44.153) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 31 May 2009 15:50:45 +0000 Received: by yx-out-1718.google.com with SMTP id 4so3804228yxp.48 for ; Sun, 31 May 2009 08:50:43 -0700 (PDT) MIME-Version: 1.0 Received: by 10.100.213.13 with SMTP id l13mr6032736ang.110.1243785043275; Sun, 31 May 2009 08:50:43 -0700 (PDT) In-Reply-To: References: <1243638987-4533-1-git-send-email-naesten@gmail.com> <1243638987-4533-2-git-send-email-naesten@gmail.com> Date: Sun, 31 May 2009 15:50:00 -0000 Message-ID: Subject: Re: [PATCH 2/2] Add "set/show debug unwinder" prefix commands. From: Samuel Bronson To: Doug Evans Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-05/txt/msg00660.txt.bz2 On Sat, May 30, 2009 at 3:24 PM, Doug Evans wrote: > On Fri, May 29, 2009 at 4:16 PM, Samuel Bronson wrote: >> Also add one subcommand for tracing the sniffing of stack frames by >> unwinders. >> >> [...] >> +/* trace unwinders called */ >> +static int trace_unwinders; > > [N.B. None of this is binding. =C2=A0Just "fwiw".] > > Just some nits: > > I don't care *too* much about the naming, but I do care about > following existing conventions and gdb seems to have a pretty > consistent convention of using "debug" in these situations instead of > "trace". =C2=A0E.g., debug_unwinders? Ah. Didn't realize it made much difference for static vars. > Adding another level of prefixes just for debugging the unwinder seems > excessive. Well, I had been planning to add another subcommand to trace the activities of the dawrf2 unwinder. I did start it, but then I discovered that the CFI for the code I was wondering about was being left out of the kernel image due to an incorrect linker script. I still think it might be useful to be able to add others, but I'm not going to be stubborn about it.