From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18451 invoked by alias); 30 May 2016 11:02:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 18430 invoked by uid 89); 30 May 2016 11:02:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=18777 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 30 May 2016 11:02:39 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1C310C0586C9; Mon, 30 May 2016 11:02:38 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u4UB2aEv022217; Mon, 30 May 2016 07:02:37 -0400 Subject: Re: [PATCH 5/5 v2] Add tests for 64bit values in trace-condition.exp To: Antoine Tremblay , gdb-patches@sourceware.org References: <1464375916-16369-1-git-send-email-antoine.tremblay@ericsson.com> <1464375916-16369-5-git-send-email-antoine.tremblay@ericsson.com> From: Pedro Alves Message-ID: Date: Mon, 30 May 2016 11:02:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: <1464375916-16369-5-git-send-email-antoine.tremblay@ericsson.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-05/txt/msg00540.txt.bz2 On 05/27/2016 08:05 PM, Antoine Tremblay wrote: > This patch adds tests for emit operations with 64 bit values. It takes > special care to avoid mistakes that one could make on a 32bit architecture > using 64bit values. > > gdb/testsuite/ChangeLog: > > * gdb.trace/trace-condition.exp: Add 64bit tests. > --- > gdb/testsuite/gdb.trace/trace-condition.exp | 73 +++++++++++++++++++++++++++++ > 1 file changed, 73 insertions(+) > > diff --git a/gdb/testsuite/gdb.trace/trace-condition.exp b/gdb/testsuite/gdb.trace/trace-condition.exp > index b7551b1..3f35489 100644 > --- a/gdb/testsuite/gdb.trace/trace-condition.exp > +++ b/gdb/testsuite/gdb.trace/trace-condition.exp > @@ -187,4 +187,77 @@ foreach trace_command { "trace" "ftrace" } { > test_tracepoints $trace_command "(66 <= 42 ? 0 : 1) == 0" 0 > test_tracepoints $trace_command "(11 >= 42 ? 0 : 1) == 0" 0 > test_tracepoints $trace_command "(11 > 21 ? 0 : 1) == 0" 0 18955_i386_failure > + > + # Test operations with 64 bit operands. > + test_tracepoints $trace_command "0xabababab00000000 == 0xcdcdcdcd00000000" 0 > + test_tracepoints $trace_command "!0xabababab00000000 == 0" 10 > + test_tracepoints $trace_command "0xababababcdcdcdcd + 0x1111111143434343 == 0xbcbcbcbd11111110" 10 > + test_tracepoints $trace_command "0xababababcdcdcdcd - 0x11111111dc111111 == 0x9a9a9a99f1bcbcbc" 10 > + test_tracepoints $trace_command "0xababababcdcdcdcd * 0xababababcdcdcdcd == 0x55320eeb91c3f629" 10 > + test_tracepoints $trace_command "0x00abababcdcdcdcd << 1 == 0x15757579b9b9b9a" 10 > + test_tracepoints $trace_command "0x00abababcdcdcdcd << 46 == 0x7373400000000000" 10 > + # signed rsh > + test_tracepoints $trace_command "0x00abababcdcdcdcd >> 1 == 0x55d5d5e6e6e6e6" 10 > + test_tracepoints $trace_command "0x00abababcdcdcdcd >> 46 == 0x2ae" 10 > + # unsigned rsh > + test_tracepoints $trace_command "0xababababcdcdcdcdUL >> 1 == 0x55d5d5d5e6e6e6e6UL" 10 > + test_tracepoints $trace_command "0xababababcdcdcdcdUL >> 46 == 0x2aeaeUL" 10 > + test_tracepoints $trace_command "-(0x00abababcdcdcdcd << 1) == -0x15757579b9b9b9a" 10 > + test_tracepoints $trace_command "-(0x00abababcdcdcdcd >> 1) == -0x55d5d5e6e6e6e6" 10 > + test_tracepoints $trace_command "(0xababababcdcdcdcd & 0x00000fffffffffff) == 0x00000babcdcdcdcd" 10 > + test_tracepoints $trace_command "(0xababababcdcdcdcd | 0x00000fffffffffff) == 0xababafffffffffff" 10 > + test_tracepoints $trace_command "(0xaaaaaaaaaaaaaaaa ^ 0x5555555555555555) == 0xffffffffffffffff" 10 > + test_tracepoints $trace_command "~0xaaaaaaaaaaaaaaaa == 0x5555555555555555" 10 > + # less unsigned > + test_tracepoints $trace_command "0x99999999bbbbbbbb < 0xaaaaaaaaaaaaaaaa" 10 > + test_tracepoints $trace_command "0x99999999bbbbbbbb < 0x99999999cccccccc" 10 > + test_tracepoints $trace_command "0x99999999bbbbbbbb <= 0x99999999bbbbbbbb" 10 > + # less signed > + test_tracepoints $trace_command "0x09999999bbbbbbbb < 0x0aaaaaaaaaaaaaaa" 10 > + test_tracepoints $trace_command "0x09999999bbbbbbbb < 0x09999999cccccccc" 10 > + test_tracepoints $trace_command "0x09999999bbbbbbbb <= 0x09999999bbbbbbbb" 10 > + test_tracepoints $trace_command "0x0aaaaaaaaaaaaaaa > 0x09999999bbbbbbbb" 10 > + test_tracepoints $trace_command "(0xabababab00000000 == 0xcdcdcdcd00000000 ? 1 : 0) == 0" 10 > + test_tracepoints $trace_command "(0xabababab00000000 != 0xcdcdcdcd00000000 ? 1 : 0) == 1" 10 > + test_tracepoints $trace_command "(0x09999999bbbbbbbb < 0x09999999cccccccc ? 1 : 0) == 1" 10 18955_i386_failure > + test_tracepoints $trace_command "(0x09999999bbbbbbbb <= 0x09999999bbbbbbbb ? 1 : 0) == 1" 10 > + test_tracepoints $trace_command "(0x09999999bbbbbbbb >= 0x09999999bbbbbbbb ? 1 : 0) == 1" 10 > + test_tracepoints $trace_command "(0x0aaaaaaaaaaaaaaa > 0x09999999bbbbbbbb ? 1 : 0) == 1" 10 > + > + # Counter-cases test operations with 64 bit operands. > + test_tracepoints $trace_command "0xabababab00000000 == 0xabababab00000000" 10 > + test_tracepoints $trace_command "!0x0 == 0" 0 > + test_tracepoints $trace_command "0xababababcdcdcdff + 0x1111111143434343 == 0xbcbcbcbd11111110" 0 > + test_tracepoints $trace_command "0xababababcdcdcdff - 0x11111111dc111111 == 0x9a9a9a99f1bcbcbc" 0 > + test_tracepoints $trace_command "0xababababcdcdcdff * 0xababababcdcdcdcd == 0x55320eeb91c3f629" 0 > + test_tracepoints $trace_command "0x00abababcdcdcdff << 1 == 0x15757579b9b9b9a" 0 > + test_tracepoints $trace_command "0x00abababcdcdcdff << 46 == 0x7373400000000000" 0 > + # signed rsh > + test_tracepoints $trace_command "0x00bcababcdcdcdcd >> 1 == 0x55d5d5e6e6e6e6" 0 > + test_tracepoints $trace_command "0x00bcababcdcdcdcd >> 46 == 0x2ae" 0 > + # unsigned rsh > + test_tracepoints $trace_command "0xcdabababcdcdcdcdUL >> 1 == 0x55d5d5d5e6e6e6e6UL" 0 > + test_tracepoints $trace_command "0xcdabababcdcdcdcdUL >> 46 == 0x2aeaeUL" 0 > + test_tracepoints $trace_command "-(0x00abababcdcdcdff << 1) == -0x15757579b9b9b9a" 0 > + test_tracepoints $trace_command "-(0x00cdababcdcdcdcd >> 1) == -0x55d5d5e6e6e6e6" 0 > + test_tracepoints $trace_command "(0xababababcdcdcdcd & 0x00000fffffffff00) == 0x00000babcdcdcdcd" 0 > + test_tracepoints $trace_command "(0xababababcdcdcdcd | 0x00000fffffffff00) == 0xababafffffffffff" 0 > + test_tracepoints $trace_command "(0xaaaaaaaaaaaaaaaa ^ 0x5555555555555111) == 0xffffffffffffffff" 0 > + test_tracepoints $trace_command "~0xaaaaaaaaaaaaaaaa == 0x5555555555555111" 0 > + # less unsigned > + test_tracepoints $trace_command "0xbb999999bbbbbbbb < 0xaaaaaaaaaaaaaaaa" 0 > + test_tracepoints $trace_command "0x99999999eebbbbbb < 0x99999999cccccccc" 0 > + test_tracepoints $trace_command "0xbb999999eebbbbbb <= 0x99999999bbbbbbbb" 0 > + # less signed > + test_tracepoints $trace_command "0x0bb99999ccbbbbbb < 0x0aaaaaaaaaaaaaaa" 0 > + test_tracepoints $trace_command "0x09999999ddbbbbbb < 0x09999999cccccccc" 0 > + test_tracepoints $trace_command "0x0aa99999bbbbbbbb <= 0x09999999bbbbbbbb" 0 > + test_tracepoints $trace_command "0x088aaaaabbaaaaaa > 0x09999999bbbbbbbb" 0 > + test_tracepoints $trace_command "(0xcdcdcdcd00000000 == 0xcdcdcdcd00000000 ? 1 : 0) == 0" 0 > + test_tracepoints $trace_command "(0xcdcdcdcd00000000 != 0xcdcdcdcd00000000 ? 1 : 0) == 1" 0 > + test_tracepoints $trace_command "(0x09999999eeebbbbb < 0x09999999cccccccc ? 1 : 0) == 1" 0 18955_i386_failure > + test_tracepoints $trace_command "(0x09999999eeebbbbb <= 0x09999999bbbbbbbb ? 1 : 0) == 1" 0 > + test_tracepoints $trace_command "(0x00099999bbbbbbbb >= 0x09999999bbbbbbbb ? 1 : 0) == 1" 0 > + test_tracepoints $trace_command "(0x00088888ccaaaaaa > 0x09999999bbbbbbbb ? 1 : 0) == 1" 0 > + > } > Same comment on splitting the counter-cases to their own section. It's very hard to match the counter-case with the corresponding "case" test this way IMO. Could you resort please? Maybe even add an empty line between each pair of case/counter-case, for added legibility. Thanks, Pedro Alves