From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12642 invoked by alias); 26 Jan 2010 08:01:51 -0000 Received: (qmail 12454 invoked by uid 22791); 26 Jan 2010 08:01:50 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail-pz0-f177.google.com (HELO mail-pz0-f177.google.com) (209.85.222.177) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 26 Jan 2010 08:01:33 +0000 Received: by pzk7 with SMTP id 7so1975230pzk.12 for ; Tue, 26 Jan 2010 00:01:32 -0800 (PST) MIME-Version: 1.0 Received: by 10.142.4.42 with SMTP id 42mr5340686wfd.78.1264492892102; Tue, 26 Jan 2010 00:01:32 -0800 (PST) In-Reply-To: References: <20100114101348.GA24756@host0.dyn.jankratochvil.net> <20100119075642.GA30154@host0.dyn.jankratochvil.net> From: Hui Zhu Date: Tue, 26 Jan 2010 08:01:00 -0000 Message-ID: Subject: Re: [RFA] Show some tips when file cmd get bfd_error_file_ambiguously_recognized To: Jan Kratochvil , gdb-patches ml , Tristan Gingold , Daniel Jacobowitz Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-01/txt/msg00571.txt.bz2 About this patch. There are a lot of function call "bfd_check_format". What about add a wrapper of "bfd_check_format_matches" to gdb. This wrapper call "bfd_check_format_matches" and if it get bfd_error_file_ambiguously_recognized, output the format and other help message before it return. Change the "bfd_check_format" to the wrapper. Then when gdb get bfd_error_file_ambiguously_recognized, putput the help message directly. What do you think about it? Thanks, Hui On Tue, Jan 19, 2010 at 16:08, Hui Zhu wrote: >> >>> + =A0 =A0 =A0 =A0 =A0 fprintf_filtered (gdb_stderr, _("It matchs format= s:")); >> >> "matches" >> > > Fixed. > > Thanks, > Hui > > 2010-01-19 =A0Hui Zhu =A0 > > =A0 =A0 =A0 =A0* exec.c (exec_file_attach): Output some tips when > =A0 =A0 =A0 =A0bfd_get_error is bfd_error_file_ambiguously_recognized. >