From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22816 invoked by alias); 6 Jan 2010 06:57:59 -0000 Received: (qmail 22804 invoked by uid 22791); 6 Jan 2010 06:57:57 -0000 X-SWARE-Spam-Status: No, hits=-1.0 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS,WEIRD_QUOTING X-Spam-Check-By: sourceware.org Received: from mail-pw0-f49.google.com (HELO mail-pw0-f49.google.com) (209.85.160.49) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 06 Jan 2010 06:57:53 +0000 Received: by pwj12 with SMTP id 12so12541700pwj.8 for ; Tue, 05 Jan 2010 22:57:52 -0800 (PST) MIME-Version: 1.0 Received: by 10.143.27.31 with SMTP id e31mr16071483wfj.173.1262761072158; Tue, 05 Jan 2010 22:57:52 -0800 (PST) In-Reply-To: References: <4B29018C.6060307@codesourcery.com> <4B3BEDCC.9040103@earthlink.net> From: Hui Zhu Date: Wed, 06 Jan 2010 06:57:00 -0000 Message-ID: Subject: Re: [RFC] Let "gcore" command accept a suffix argument To: Stan Shebs , Tom Tromey , Stan Shebs , Joel Brobecker , Michael Snyder Cc: gdb-patches ml Content-Type: multipart/mixed; boundary=00504502cc18246915047c79799d X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-01/txt/msg00098.txt.bz2 --00504502cc18246915047c79799d Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-length: 2165 Hello, I make a new patch that eval command use "" to point out the simple command. If want add " in normal string. Use \" If we want add \ in normal string. Use \\ It can be use like: (gdb) eval "echo \""$a++"\"" "7"(gdb) eval "echo \""$a++"\"" "8"(gdb) eval "echo \""$a++"\"" "9"(gdb) eval "echo \""$a++"\"" "10"(gdb) eval "echo \""$a++"\"" "11"(gdb) eval "echo \""$a++"\"" "12"(gdb) eval "echo \""$a++"\"" "13"(gdb) eval "echo \""$a++"\"" Please help me review it. Best regards, Hui 2010-01-06 Hui Zhu * printcmd.c (ctype.h): New include. (eval_command): New function. (_initialize_printcmd): New command "eval". On Mon, Jan 4, 2010 at 22:42, Hui Zhu wrote: > Sorry for my poor English, did you mean that we can use "eval" for this c= ommand? > > Thanks, > Hui > > On Thu, Dec 31, 2009 at 08:18, Stan Shebs wrote: >> Tom Tromey wrote: >>>>>>>> >>>>>>>> "Stan" =3D=3D Stan Shebs writes: >>>>>>>> >>> >>> Stan> BTW, Pedro nudges me out of my stupor and reminds me that the >>> Stan> soon-to-be-posted tracepoint action to evaluate without collecting >>> is >>> Stan> also called "eval" (it was originally proposed as "do" but that >>> Stan> ambiguates with "down", which seemed like a bad idea). >>> >>> Stan> The two versions are not necessarily mutually exclusive - the >>> Stan> downloading at the start of a trace run gives us a chance to filt= er >>> Stan> out eval's that don't make sense for the target agent - but if we= go >>> Stan> too afield on syntax (the tracepoint version is simply a >>> Stan> comma-separated list of GDB expressions), then that's going to be >>> more >>> Stan> of a problem to reconcile. >>> >>> "eval" seems awfully generic for a command which is specific to >>> tracepoints. >>> =A0I'm not super familiar with tracepoints but a lot of the other comma= nds >>> seem to start with "t". =A0Why not "teval"? >>> >> >> That's a good idea. =A0If we ever come up with a Grand Unified Semantics= of >> actions and commands for which generic "eval" matches tracepoint "teval"= , we >> can simply alias the two. >> >> Stan >> >> > --00504502cc18246915047c79799d Content-Type: text/plain; charset=US-ASCII; name="eval.txt" Content-Disposition: attachment; filename="eval.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_g43rnsfh0 Content-length: 4279 LS0tCiBwcmludGNtZC5jIHwgIDEwMyArKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrCiAxIGZp bGUgY2hhbmdlZCwgMTAzIGluc2VydGlvbnMoKykKCi0tLSBhL3ByaW50Y21k LmMKKysrIGIvcHJpbnRjbWQuYwpAQCAtNTEsNiArNTEsOCBAQAogI2luY2x1 ZGUgImNoYXJzZXQuaCIKICNpbmNsdWRlICJhcmNoLXV0aWxzLmgiCiAKKyNp bmNsdWRlIDxjdHlwZS5oPgorCiAjaWZkZWYgVFVJCiAjaW5jbHVkZSAidHVp L3R1aS5oIgkJLyogRm9yIHR1aV9hY3RpdmUgZXQuYWwuICAgKi8KICNlbmRp ZgpAQCAtMjY0OSw2ICsyNjUxLDEwNCBAQCBwcmludGZfY29tbWFuZCAoY2hh ciAqYXJnLCBpbnQgZnJvbV90dHkpCiAgIGRvX2NsZWFudXBzIChvbGRfY2xl YW51cHMpOwogfQogCitzdGF0aWMgdm9pZAorZXZhbF9jb21tYW5kIChjaGFy ICpleHAsIGludCBmcm9tX3R0eSkKK3sKKyNkZWZpbmUgQ01EU0laRSAxMDI0 CisgIGNoYXIgY21kW0NNRFNJWkUgKyAxXTsKKyAgY2hhciAqY21kcCA9IGNt ZDsKKyAgaW50IGlzX2V2YWwgPSAxOworICBpbnQgaXNfYmFja3NsYXNoID0g MDsKKyAgaW50IGlzX3F1b3RlID0gMDsKKyAgY2hhciAqZXZhbF9iZWdpbiA9 IGV4cDsKKworICBpZiAoIWV4cCkKKyAgICByZXR1cm47CisKKyAgd2hpbGUg KGNtZHAgLSBjbWQgPCBDTURTSVpFKQorICAgIHsKKyAgICAgIGlmICghaXNf YmFja3NsYXNoICYmIGV4cFswXSA9PSAnXFwnKQorICAgICAgICB7CisgICAg ICAgICAgaXNfYmFja3NsYXNoID0gMTsKKyAgICAgICAgICBleHAgKys7Cisg ICAgICAgICAgY29udGludWU7CisgICAgICAgIH0KKworICAgICAgaWYgKGlz X2V2YWwpCisgICAgICAgIHsKKyAgICAgICAgICBpZiAoIWV4cFswXSB8fCAo ZXhwWzBdPT0gJyInICYmICFpc19iYWNrc2xhc2gpKQorICAgICAgICAgICAg eworICAgICAgICAgICAgICBzdHJ1Y3QgdmFsdWUgKnZhbHVlOworICAgICAg ICAgICAgICBnZGJfYnl0ZSAqYnVmZmVyOworICAgICAgICAgICAgICBpbnQg bGVuZ3RoID0gLTE7CisgICAgICAgICAgICAgIHN0cnVjdCB0eXBlICpjaGFy X3R5cGUgPSBOVUxMOworICAgICAgICAgICAgICBjb25zdCBjaGFyICpsYV9l bmNvZGluZyA9IE5VTEw7CisgICAgICAgICAgICAgIGludCBpc19lbmQgPSAw OworCisgICAgICAgICAgICAgIGlmICghZXhwWzBdKQorICAgICAgICAgICAg ICAgIGlzX2VuZCA9IDE7CisgICAgICAgICAgICAgIGVsc2UKKyAgICAgICAg ICAgICAgICBleHBbMF0gPSAnXDAnOworICAgICAgICAgICAgICBpZiAoc3Ry bGVuIChldmFsX2JlZ2luKSkKKyAgICAgICAgICAgICAgICB7CisgICAgICAg ICAgICAgICAgICB2YWx1ZSA9IHBhcnNlX2FuZF9ldmFsIChldmFsX2JlZ2lu KTsKKworICAgICAgICAgICAgICAgICAgc3dpdGNoIChUWVBFX0NPREUgKHZh bHVlX3R5cGUgKHZhbHVlKSkpCisgICAgICAgICAgICAgICAgICAgIHsKKyAg ICAgICAgICAgICAgICAgICAgICBjYXNlIFRZUEVfQ09ERV9BUlJBWToKKyAg ICAgICAgICAgICAgICAgICAgICAgIExBX0dFVF9TVFJJTkcgKHZhbHVlLCAm YnVmZmVyLCAmbGVuZ3RoLAorICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgJmNoYXJfdHlwZSwgJmxhX2VuY29kaW5nKTsKKyAgICAg ICAgICAgICAgICAgICAgICAgYnJlYWs7CisgICAgICAgICAgICAgICAgICAg ICAgY2FzZSBUWVBFX0NPREVfSU5UOgorICAgICAgICAgICAgICAgICAgICAg ICAgYnVmZmVyID0gcGxvbmdlc3QgKHZhbHVlX2FzX2xvbmcgKHZhbHVlKSk7 CisgICAgICAgICAgICAgICAgICAgICAgICBsZW5ndGggPSBzdHJsZW4gKGJ1 ZmZlcik7CisgICAgICAgICAgICAgICAgICAgICAgICBicmVhazsKKyAgICAg ICAgICAgICAgICAgICAgICBkZWZhdWx0OgorICAgICAgICAgICAgICAgICAg ICAgICAgYnVmZmVyID0gZXZhbF9iZWdpbjsKKyAgICAgICAgICAgICAgICAg ICAgICAgIGxlbmd0aCA9IGV4cCAtIGV2YWxfYmVnaW47CisgICAgICAgICAg ICAgICAgICAgICAgICBicmVhazsKKyAgICAgICAgICAgICAgICAgICAgfQor CisgICAgICAgICAgICAgICAgICBpZiAobGVuZ3RoID4gQ01EU0laRSAtIChj bWRwIC0gY21kKSkKKyAgICAgICAgICAgICAgICAgICAgbGVuZ3RoID0gQ01E U0laRSAtIChjbWRwIC0gY21kKTsKKyAgICAgICAgICAgICAgICAgIG1lbWNw eSAoY21kcCwgYnVmZmVyLCBsZW5ndGgpOworICAgICAgICAgICAgICAgICAg Y21kcCArPSBsZW5ndGg7CisgICAgICAgICAgICAgICAgfQorCisgICAgICAg ICAgICAgIGlmIChpc19lbmQpCisgICAgICAgICAgICAgICAgYnJlYWs7CisK KyAgICAgICAgICAgICAgaXNfZXZhbCA9IDA7CisgICAgICAgICAgICB9CisK KyAgICAgICAgICBleHAgKys7CisgICAgICAgIH0KKyAgICAgIGVsc2UKKyAg ICAgICAgeworICAgICAgICAgIGlmICghZXhwWzBdKQorICAgICAgICAgICAg YnJlYWs7CisKKyAgICAgICAgICBpZiAoZXhwWzBdPT0gJyInICYmICFpc19i YWNrc2xhc2gpCisgICAgICAgICAgICB7CisgICAgICAgICAgICAgIGlzX2V2 YWwgPSAxOworICAgICAgICAgICAgICBldmFsX2JlZ2luID0gZXhwICsgMTsK KyAgICAgICAgICAgIH0KKyAgICAgICAgICBlbHNlCisgICAgICAgICAgICB7 CisgICAgICAgICAgICAgIGNtZHBbMF0gPSBleHBbMF07CisgICAgICAgICAg ICAgIGNtZHAgKys7CisgICAgICAgICAgICB9CisgICAgICAgICAgZXhwICsr OworICAgICAgICB9CisKKyAgICAgIGlmIChpc19iYWNrc2xhc2gpCisgICAg ICAgIGlzX2JhY2tzbGFzaCA9IDA7CisgICAgfQorICBjbWRwWzBdID0gJ1ww JzsKKworICBleGVjdXRlX2NvbW1hbmQgKGNtZCwgZnJvbV90dHkpOworfQor CiB2b2lkCiBfaW5pdGlhbGl6ZV9wcmludGNtZCAodm9pZCkKIHsKQEAgLTI4 MTIsNCArMjkxMiw3IEBAIFNob3cgcHJpbnRpbmcgb2Ygc291cmNlIGZpbGVu YW1lIGFuZCBsaW4KIAkJCSAgIE5VTEwsCiAJCQkgICBzaG93X3ByaW50X3N5 bWJvbF9maWxlbmFtZSwKIAkJCSAgICZzZXRwcmludGxpc3QsICZzaG93cHJp bnRsaXN0KTsKKworICBhZGRfY29tICgiZXZhbCIsIG5vX2NsYXNzLCBldmFs X2NvbW1hbmQsIF8oIlwKK0NhbGwgY29tbWFuZCB3aXRoIHZhcmlhYmxlLiIp KTsKIH0K --00504502cc18246915047c79799d--